Reports: My Feedback

report_myfeedback
Maintained by Picture of Jessica Gramp Jessica Gramp
A Moodle Report that shows all student feedback on one page.
359 sites
302 downloads
34 fans

The Moodle My Feedback report appears in the My Profile > Activity Reports menu and allows students to see an overview of all their grades and feedback for assessment activities such as Moodle Assignments, Turnitin Assignments (v1 & v2), Workshops and Quizzes. It provides their visible grades and a link to their submission and any feedback that has been released to them. Note: anything hidden in the gradebook or on the course will not display.

The report is intended to help students understand the variety of feedback they receive. It can also be used to identify similarities between feedback received from across modules and years to help students see how they can improve their work in future assessments.

See how it's being used at UCL: 

Potential privacy issues

All versions before v2.8.11 contain a bug that reveals grades before the post date on some, but not all, Turnitin assignments. Please update to v2.8.11 to ensure you don't encounter this error. V2.4 of this plugin shows numeric grades regardless of the settings on the course or grade item they represent. Displaying the grade in the format defined within each assessment is implemented in V2.5 (available for moodle V2.8+). Take care with using this plugin as it reveals grades to students, so any changes that you make need to be tested thoroughly to ensure they don't reveal hidden grades. E.g. Turnitin assignment grades are only visible after the post date; Hidden activities are not shown; Hidden grades (and 'hidden until' grades) as set in the gradebook don't show; Non-released grades don't show; Workshops only show feedback when they are closed; Moodle Assignments that have a workflow enabled don't show grades before they are finalised.

Screenshots

Screenshot #0
Screenshot #1
Screenshot #2
Screenshot #3
Screenshot #4
Screenshot #5
Screenshot #6

Contributors

Picture of Jessica Gramp
Jessica Gramp (Lead maintainer)
Picture of Alexis Nelson
Alexis Nelson: Developer
Picture of Delvon Forrester
Delvon Forrester: Developer
Please login to view contributors details and/or to contact them

Comments RSS

Show comments
  • Picture of Jessica Gramp
    Tue, 16 May 2017, 6:12 AM
    Hi Rob and Juha.

    I've asked our DB Admin what db optimisation he performed and will let you know what he says. I haven't seen anything that slow myself and we run much bigger queries than what you describe, so hopefully this is something that can be addressed with db indexing or similar. I'll keep you posted.
  • Picture of Juha Martikainen
    Tue, 23 May 2017, 6:39 PM
    Hi Jessica, and thank you for responding. I don't know if the problems are related, but I was referring to the GROUP BY / LIMIT issue where at the moment we get :
    Column 'mdl_role_assignments.roleid' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause.
    SELECT DISTINCT min(c.id) as id, r.roleid FROM mdl_role_capabilities c
    JOIN mdl_role_assignments r ON r.roleid=c.roleid AND userid = ? AND capability = ?
    [array (
    0 => '2',
    1 => 'report/myfeedback:personaltutor',
    )]
    Error code: dmlreadexception

    If we try to use the plugin.
  • Picture of Jessica Gramp
    Tue, 6 Jun 2017, 10:10 PM
    Hi Rob and Juha.

    So it turns out the report queries the Moodle log table, which is huge and is probably why you are having such slow page load times. We have optimised our Moodle logs table using the following SQL:

    create index mdl_logsstanlog_usecou_ix on mdl_logstore_standard_log (userid, courseid);

    Those who are able to apply the above index should do so, but I assume for some installations this won't be an option, so I'm wondering if a new setting in the site admin settings for My Feedback might be useful, to turn off this part of the query for those who experience performance issues. It means that the viewed date, which shows when the student first viewed the feedback after it was released, will not be viewable if this is disabled though, as the only way this could be retrieved was via the Moodle logs table.


    What do people think about making this a new setting in the MyFeedback report settings?
  • Picture of Jessica Gramp
    Wed, 7 Jun 2017, 2:50 AM
    Thanks Mark for the info and thanks for clarifying it was the same postgres issue you were mentioning Juha.

    I managed to get it working with postgres by implementing the group change you mentioned Mark, where I changed in lib.php:

    $sql .= "AND userid = ? AND capability = ?";
    to
    $sql .= "AND userid = ? AND capability = ? GROUP BY c.id, r.roleid";

    and changing all the
    -1 as partname
    to
    '' AS partname

    so the types match in the union.

    I have updated the code on github and moodle.org, so version 2.8.12 now has these fixes included, as well as a few other small fixes outlined in the change log.
  • Picture of Helen Axe
    Thu, 22 Jun 2017, 9:11 PM
    Hi All

    Through testing we have uncovered the below issue. Having switched on debugging the following was highlighted. (We use postgres.)

    The issue seems to be caused by the chunk of code on lines 1477 to 1486 in /report/myfeedback/lib.php - I believe the SQL query generated is using double quotes instead of a single quote mark, which is causing postgreSQL to throw the error (it's expecting to see 'turnitintooltwo' instead of "turnitintooltwo").

    Debug info: ERROR: column "turnitintooltwo" does not exist
    LINE 4: AND (itemmodule IN ("turnitintooltwo","works...
    ^
    SELECT id, itemname, itemtype, itemmodule
    FROM mdl_grade_items gi
    WHERE (hidden != 1 AND hidden < $1) AND courseid = $2
    AND (itemmodule IN ("turnitintooltwo","workshop","quiz","assign") OR (itemtype = 'manual'))
    [array (
    0 => 1498128829,
    1 => '3255',
    )]
    Error code: dmlreadexception

  • Picture of Juha Martikainen
    Wed, 9 Aug 2017, 3:10 PM
    Hi Jessica, and sorry for the delayed post.
    I installed the newest version to our testing environment and it seems to be working find. We well conduct more tests in the near future but it seems to be working fine. Thank you for the fix!

  • Picture of Juha Martikainen
    Wed, 27 Sep 2017, 9:03 PM
    Hi again, just ran into another problem concerning workshop assignments. If the user has workshop activities with assessments My Feedback overview tab gives :

    Debug info: ERROR: column "wa.feedbackauthorattachment" must appear in the GROUP BY clause or be used in an aggregate function
    LINE 1: SELECT DISTINCT max(wa.id) as id, wa.feedbackauthorattachmen...
    ^
    SELECT DISTINCT max(wa.id) as id, wa.feedbackauthorattachment
    FROM mdl_workshop_assessments wa
    JOIN mdl_workshop_submissions ws ON wa.submissionid=ws.id
    AND ws.authorid=$1 AND ws.id=$2 and ws.example = 0
    [array (
    0 => 14,
    1 => '33',
    )]
    Error code: dmlreadexception
    Stack trace:

    line 479 of /lib/dml/moodle_database.php: dml_read_exception thrown
    line 242 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
    line 776 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
    line 1551 of /lib/dml/moodle_database.php: call to pgsql_native_moodle_database->get_records_sql()
    line 292 of /report/myfeedback/lib.php: call to moodle_database->get_record_sql()
    line 3894 of /report/myfeedback/lib.php: call to report_myfeedback->has_workshop_feedback_file()
    line 108 of /report/myfeedback/student/overview.php: call to report_myfeedback->get_content()
    line 273 of /report/myfeedback/index.php: call to require_once()

    We are in Moodle 3.2.2+ with PostgreSql db.
  • Picture of Noor Abdulghani
    Tue, 17 Oct 2017, 8:19 PM
    Hi Jessica,

    We have disabled the Gradebook on our Moodle because last year we had reports where students were able to see their Turnitin grades via the Gradebook before the Post Date. We have upgraded our Moodle to 3.2, but the Gradebook is still disabled from students' view and we are going to install My Feedback plugin, but wondering whether the Gradebook needs to be enabled in order for My Feedback to work? Also, have you had any reports that My Feedback plugin releases grades to students before the Post date?

    Thanks

    Noor
  • Picture of Roberto Catanuto
    Thu, 19 Oct 2017, 7:33 PM
    Hi Jessica, I'm trying out your plugin.
    When I ask a student to submit an assignment, I grade it and then the student sees 4 entries for each submission, and the same grade in each row. Is it normal or is there any way to let the student see just one line for each grade received.
    I have a screenshot but can't attach it here sorry.
  • Picture of Jessica Gramp
    Wed, 1 Nov 2017, 12:54 AM
    Hi Noor,

    Yes, the My Feedback report does require the course gradbook to be enabled in order for items to show for that course. If the ‘Show gradebook to students’ has been set to ‘No’ in the course settings, meaning the course Gradebook is hidden from students, then no grades or feedback will appear for this course in the MyFeedback report. I will update the documentation with the list of requirements for items to show in My Feedback.

    Hopefully you can resolve this issue so you can still use the report.

    No, we thoroughly tested the report to ensure nothing is released to students before the post date, and also that it does not show anything not already visible to students in each Moodle course. If you find any evidence of the report doing otherwise, please do provide details so we can check this out, although I would be surprised if we missed something, as this was very thoroughly tested.

    Thanks,

    Jess
  • Picture of Jessica Gramp
    Wed, 1 Nov 2017, 1:00 AM
    Hi Roberto.

    We did see something like this when we ran our original tests, but it was resolved in a later version of the plugin. Which version are you using and which version of Moodle? Also, what type of assignment is it? A Moodle Assignment? I'll message you privately and perhaps you could send me that screenshot so I can see what's happening.

    Thanks,

    Jess
  • Picture of Noor Abdulghani
    Wed, 1 Nov 2017, 1:11 AM
    Thanks Jess
  • Picture of Jessica Gramp
    Wed, 1 Nov 2017, 2:10 AM
    Hi Juha,

    Do you happen to have a fix for this problem you are experiencing? It appears to be what is being described in the following forums, but we are still on 3.1 here:

    https://dba.stackexchange.com/questions/88988/postgres-error-column-must-appear-in-the-group-by-clause-or-be-used-in-an-aggre
    and
    https://stackoverflow.com/questions/19601948/must-appear-in-the-group-by-clause-or-be-used-in-an-aggregate-function

    Thanks,

    Jess
  • Picture of Jessica Gramp
    Mon, 6 Nov 2017, 5:24 AM
    Hi Delvon,

    Any clues on how to fix the missing bootstrap modal problem on Moodle 3.3 so self reflective notes and manually entered feedback can work?

    This is what you said previously:
    I found out what the issue is with self-reflective notes and non-moodle feedback not doing anything when you click to add/edit notes. The popup box is dependent on bootstrap and because in Moodle 3.0 they normally test with the clean theme (which has bootstrapbase as its parent theme), but this does not seem to use the bootstrap modal which is used for the popup box.

    Can the bootstrap modal code be added directly to the myfeedback plugin so it doesn't rely on particular themes?

    Any clues you have on where / how to add this so it works again in Moodle 3.3 will be gratefully received. Thank you.
  • Picture of Delvon Forrester
    Mon, 6 Nov 2017, 6:07 PM
    Hi Jess,

    I remember fixing it for an earlier version of Moodle. I am almost certain that this is the same issue. I will try and have a look today or tomorrow and post what the fix is here.
1 2 3 4 5 6
Please login to post comments