Moodle plugins directory: My Feedback

When starting plugin i got this:
pix_url is deprecated. Use image_url for images and pix_icon for icons.

line 267 of /lib/outputrenderers.php: call to debugging()
line 4066 of /report/myfeedback/lib.php: call to renderer_base->pix_url()
line 108 of /report/myfeedback/student/overview.php: call to report_myfeedback->get_content()
line 274 of /report/myfeedback/index.php: call to require_once()
Any IDEA?

When installing this plugin I get the following error while trying to visit report/myfeedback/index.php?userid=3176

Warning: session_start(): Cannot send session cache limiter - headers already sent (output started at /home/learntest/public_html/report/myfeedback/index.php:1) in /home/learntest/public_html/lib/classes/session/handler.php on line 42
error/An error occurred whilst communicating with the server
Debug info:
Error code: An error occurred whilst communicating with the server
$a contents:
Stack trace:
line 79 of /lib/classes/session/manager.php: core\session\exception thrown
line 785 of /lib/setup.php: call to core\session\manager::start()
line 29 of /config.php: call to require_once()
line 33 of /report/myfeedback/index.php: call to require()

Moodle 3.4, latest version of MyFeedback plugin

Hi Jessica,
I am trying out this plugin on Moodle 3.4.2, where My moodle installed on Windows with MS SQL Server Database. and when I pressed the My Feedback link I got the below errors, any advice?

Debug info: SQLState: 42000
Error Code: 102
Message: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near 'limit'.

SELECT roleid FROM mdl_role_context_levels WHERE contextlevel = '30' limit 1
[array (
0 => 30,
)]
Error code: dmlreadexception
×Stack trace:
line 486 of \lib\dml\moodle_database.php: dml_read_exception thrown
line 324 of \lib\dml\sqlsrv_native_moodle_database.php: call to moodle_database->query_end()
line 431 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->query_end()
line 896 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->do_query()
line 972 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->get_recordset_sql()
line 1571 of \lib\dml\moodle_database.php: call to sqlsrv_native_moodle_database->get_records_sql()
line 1161 of \report\myfeedback\lib.php: call to moodle_database->get_record_sql()
line 151 of \report\myfeedback\index.php: call to report_myfeedback->get_personal_tutor_id()

Is this not the place to post questions? I can't get this plugin installed... If I'm asking at the wrong place, please redirect me to the right place

Well, found the problem. If you look at index.php you will see a whole lot of spaces before the command <?php starts. Remove all these spaces and you're good to go...
https://github.com/jgramp/moodle-report_myfeedback/blob/master/index.php

Thanks Richard. I've fixed this in v2.14, along with another small change. I appreciate you locating the error and reporting it so it could easily be resolved for everyone. Cheers.

Hi Mohamed.

I don't know if this works with MS SQL. I've never come across anyone using this DB before and wasn't actually aware it was possible to run Moodle on MS SQL until now. It's been tested primarily on MySQL and also postgres, although there are some issues still with the latter I believe, looking at some of the comments from people using postgres. Please share a fix if you find one.
Thank you.

Hi Dinis.

It looks like these are warnings, rather than errors. It seems the way images are referenced has changed recently, although I think the old method is still supported as far as I can tell. We're running Moodle 2.4 and it seems to be working ok. I've raised a Moodle Tracker ticket for this:
https://tracker.moodle.org/browse/CONTRIB-7191

If you resolve this, please share the code back to the community.
Thank you.

Hi Marcel,

Apologies for the delay in replying. I missed your message somehow. Yes, we have the report working for our students. You need to update the student role to include MyFeedback access. You can view the installation guide here, which contains information about the permissions you need to enable for each role you wish to access the report. See: https://docs.moodle.org/35/en/report/myfeedback/install#Permissions

Thank you.

Hello everyone.

Has anyone written any behat test scripts for My Feedback?

Hi, belated commment, we are using PostgreSql and had some problems with workshop braking the view. We fixed it with :
report/myfeedback/lib.php -> // Is there any feedback file?
- $sql = "SELECT DISTINCT max(wa.id) as id, wa.feedbackauthorattachment

+ /* $sql = "SELECT DISTINCT max(wa.id) as id, wa.feedbackauthorattachment */

+ $sql = "SELECT count(wa.feedbackauthorattachment) AS feedbackauthorattachment
FROM {workshop_assessments} wa
JOIN {workshop_submissions} ws ON wa.submissionid=ws.id
AND ws.authorid=? AND ws.id=? and ws.example = 0";

Haven't tried with the latest version yet.

Thanks Juha. I'll take a look at this.
The latest version won't have this resolved yet.
I'm not familiar with this particular code, but I was wondering if leaving out the DISTINCT max() might mean you end up with a different output? I know at one point we saw duplicates when multiple feedback was left by a tutor. We only wanted to display the latest version. Hence the DISTINCT max() value being returned (I think). Now you are returning a count of another field, I wonder if this will still work the same way. Have you tested it with a tutor or peer having changed the feedback they leave for a student in the workshop? I believe you might end up with duplicates / old feedback showing in the report. What is the error you were receiving before?
Thank you for contributing.

Jessica Gramp - Still testing this, good point about the doubles. Will test what happens.

Hello, can somebody please help with this plugin?
We are running moodle 3.4., installed latest plugin version, and getting this kind of error

Debug info: SQLState: 42000
Error Code: 102
Message: [Microsoft][ODBC Driver 11 for SQL Server][SQL Server]Incorrect syntax near 'limit'.

SELECT roleid FROM mdl_role_context_levels WHERE contextlevel = '30' limit 1
[array (
0 => 30,
)]
Error code: dmlreadexception
×Stack trace:
line 486 of \lib\dml\moodle_database.php: dml_read_exception thrown
line 324 of \lib\dml\sqlsrv_native_moodle_database.php: call to moodle_database->query_end()
line 431 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->query_end()
line 896 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->do_query()
line 972 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->get_recordset_sql()
line 1571 of \lib\dml\moodle_database.php: call to sqlsrv_native_moodle_database->get_records_sql()
line 1161 of \report\myfeedback\lib.php: call to moodle_database->get_record_sql()
line 151 of \report\myfeedback\index.php: call to report_myfeedback->get_personal_tutor_id()