Moodle plugins directory: My Feedback

Well, found the problem. If you look at index.php you will see a whole lot of spaces before the command <?php starts. Remove all these spaces and you're good to go...
https://github.com/jgramp/moodle-report_myfeedback/blob/master/index.php

Thanks Richard. I've fixed this in v2.14, along with another small change. I appreciate you locating the error and reporting it so it could easily be resolved for everyone. Cheers.

Hi Mohamed.

I don't know if this works with MS SQL. I've never come across anyone using this DB before and wasn't actually aware it was possible to run Moodle on MS SQL until now. It's been tested primarily on MySQL and also postgres, although there are some issues still with the latter I believe, looking at some of the comments from people using postgres. Please share a fix if you find one.
Thank you.

Hi Dinis.

It looks like these are warnings, rather than errors. It seems the way images are referenced has changed recently, although I think the old method is still supported as far as I can tell. We're running Moodle 2.4 and it seems to be working ok. I've raised a Moodle Tracker ticket for this:
https://tracker.moodle.org/browse/CONTRIB-7191

If you resolve this, please share the code back to the community.
Thank you.

Hi Marcel,

Apologies for the delay in replying. I missed your message somehow. Yes, we have the report working for our students. You need to update the student role to include MyFeedback access. You can view the installation guide here, which contains information about the permissions you need to enable for each role you wish to access the report. See: https://docs.moodle.org/35/en/report/myfeedback/install#Permissions

Thank you.

Hello everyone.

Has anyone written any behat test scripts for My Feedback?

Hi, belated commment, we are using PostgreSql and had some problems with workshop braking the view. We fixed it with :
report/myfeedback/lib.php -> // Is there any feedback file?
- $sql = "SELECT DISTINCT max(wa.id) as id, wa.feedbackauthorattachment

+ /* $sql = "SELECT DISTINCT max(wa.id) as id, wa.feedbackauthorattachment */

+ $sql = "SELECT count(wa.feedbackauthorattachment) AS feedbackauthorattachment
FROM {workshop_assessments} wa
JOIN {workshop_submissions} ws ON wa.submissionid=ws.id
AND ws.authorid=? AND ws.id=? and ws.example = 0";

Haven't tried with the latest version yet.

Thanks Juha. I'll take a look at this.
The latest version won't have this resolved yet.
I'm not familiar with this particular code, but I was wondering if leaving out the DISTINCT max() might mean you end up with a different output? I know at one point we saw duplicates when multiple feedback was left by a tutor. We only wanted to display the latest version. Hence the DISTINCT max() value being returned (I think). Now you are returning a count of another field, I wonder if this will still work the same way. Have you tested it with a tutor or peer having changed the feedback they leave for a student in the workshop? I believe you might end up with duplicates / old feedback showing in the report. What is the error you were receiving before?
Thank you for contributing.

Jessica Gramp - Still testing this, good point about the doubles. Will test what happens.

Hello, can somebody please help with this plugin?
We are running moodle 3.4., installed latest plugin version, and getting this kind of error

Debug info: SQLState: 42000
Error Code: 102
Message: [Microsoft][ODBC Driver 11 for SQL Server][SQL Server]Incorrect syntax near 'limit'.

SELECT roleid FROM mdl_role_context_levels WHERE contextlevel = '30' limit 1
[array (
0 => 30,
)]
Error code: dmlreadexception
×Stack trace:
line 486 of \lib\dml\moodle_database.php: dml_read_exception thrown
line 324 of \lib\dml\sqlsrv_native_moodle_database.php: call to moodle_database->query_end()
line 431 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->query_end()
line 896 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->do_query()
line 972 of \lib\dml\sqlsrv_native_moodle_database.php: call to sqlsrv_native_moodle_database->get_recordset_sql()
line 1571 of \lib\dml\moodle_database.php: call to sqlsrv_native_moodle_database->get_records_sql()
line 1161 of \report\myfeedback\lib.php: call to moodle_database->get_record_sql()
line 151 of \report\myfeedback\index.php: call to report_myfeedback->get_personal_tutor_id()

Hi Jessica et al,
Sorry to trouble you. I’m having problems trying to get your MyFeedback plugin to work.
I’ve installed it on a development server running Moodle 3.5 with the Boost theme. I’ve adjusted the permissions for both students and tutors but I do not see anything in the MyFeedback table (see image - https://imgur.com/a/tYfpHOP ). The gradebook is visible and there are grades and feedback in it and these are visible to students. I suspect the issue is that there are no courses for the current academic year. However, I do not know how to define the current academic year. In the settings page for the plugin I left everything as default., i.e. DB Host – [empty], DB Name– [empty] etc.
Any ideas where I should start looking for a solution?
Thanks
Bob Ridge-Stearn
Newman University, Birmingham, UK.

Hi Bob,
It seems like you aren't enrolled as a tutor on those courses. Site admin access won't give you the adequate permissions to see students' grades and feedback via the report. You need to be enrolled as a tutor on the relevant courses to see the students' grades and feedback for that course. When you do this you will see a new tab called 'My students'. You can see this tab in the screenshots on this page.
The current year settings are no longer used, since the archiving feature never passed testing, so we don't recommend it for production systems. The report will simply display anything in your current installation that you have permission to see, so you don't need to worry about this. The archive settings were there to point to other Moodle installations for institutions who archive off their courses on a yearly basis, but as I mentioned I would avoid using this.
I hope this helps. Please let me know if this resolves the issue.
Jess

Thanks Jessica, OK we can rule out the "current year" idea. However, my screenshot was of a student view. That student is enrolled on three courses and has grades and feedback on two assignments on each course. The student role permissions are: report/myfeedback:student - ALLOW. (The student does see the grades and feedback in the Moodle gradebook.)

The tutor does see all the right tabs according to your screenshots but no data.

Another thing I should mention is that I reset the roles on our development server to ensure they were 'out of the box'. When I looked for Teacher - gradereport/myfeedbacklink:view it is not there.

Bob

All sorted! My problem ( in case others find themselves in the mess I got into) was that I inadvertently changed the shortname for the editingteacher role.

This plugin looks brilliant, Jess. I was unaware of it till Aurelie Soulier mentioned it in conversation. Congratulations to you and your developer team!

When do you envisage a 3.6 release?