Prechecker results: 79 errors / 0 warnings
http://integration.moodle.org/job/Precheck%20remote%20branch/12347/artifact/work/smurf.html

Thanks for uploading your code here, it looks like you've made a good effort to follow our guidelines,

I've just taken a quick look at the code and it appears that it only supports the Assignment activity but your code does not check if the api calls are coming from the assignment activity - Plagiarism API calls are also triggered from the workshop and forum activity modules and you should prevent db calls an un-necessary function calls by adding a check for the activities you support at the top of each core api call. This will need to be addressed before we can approve this plugin.

I have not tested or installed your plugin but will take another look once you have resolved that issue.

thanks!

I see you've uploaded a new version for review here but it's still not quite right. You have only added a check to get_form_elements and get_links. there are a number of other API functions that do not check the supported activity.

Also you have not added the checks high enough in get_form_elements or get_links. it should be the first thing you check before any other db calls or function calls are made so that it is as efficient as possible for other activities.

Thanks for updating the code, I've just installed it and given it an initial test and found a number of issues that should be resolved before we approve this plugin - particularly issues, 5,6,7 and 8

Thanks Dan for the peer-review, and thanks Eugene for addressing the raised issues. We will get to another round of review soon and will let you.

Prechecker results: success (0 errors/0 warnings)

I am still learning more about this.

Learning source

I am still learning about plugin. Do need to subscribe to get the latest version? By the way, thank you for sharing!