Prechecker results: 280 errors/107 warnings
https://integration.moodle.org/job/Precheck%20remote%20branch/28790/artifact/work/smurf.html

Hi Thomas. Thanks for sharing this plugin with the community. I am going to review it for potential approval into the plugins database.

Thanks Thomas. This is useful functionality, much requested. Technically teachers could use the feedback module on anonymous. But that may not be where teachers go looking or they may want something better designed for exactly what they need.

Some things I noticed:

1. With regards to the allowmoodlevoting setting: Try to avoid use of the word Moodle in the interface as the users of your plugin may not refer to it as Moodle.
2. I think that by default it should allow answers since most people who want to use this plugin won’t be coding applications to use the webservices for it.
3. You could add a disclaimer that the plugin is not 100% anonymous as you have to be logged in, and the admin could watch the logs.

Small, low priority things which can be fixed at any time later:
1. It seems to be working just fine on 3.2 as well. Have you thought about allowing it as an option?
2. A few variables still have camel case
3. Have you thought about expanding the plugin to allow guests to complete it much like the feedback plugin?
4. It helps if you change your github repo to moodle-mod_smartchoice https://docs.moodle.org/dev/Plugin_contribution_checklist#Code_repository_name
5. Generally the name of the plugin $string['smartchoice’] will start with a capital letter. No worries if this is stylistic
6. Perhaps the plugin name could be changed to be 'anonymous choice'? Or are you planning to make it allow both anonymous and identifiable choices? I think a lot of people will be searching for anonymous choice
7. We could use session to store the fact that the user has chosen an option. At the moment it sort of seems like you need to choose again after selecting. Not a huge problem but could be a little confusing. Or a simpler way would just be to not render the choices if the action is choicesaved.

At this time I don’t see anything worth holding this back from being added to the plugins DB. Just those first 3 notes are important for making the use of this plugin clearer.