Comments

• 

  Erwin Ancheta

  Fri, 25 Apr 2014, 8:53 AM

  Hi everyone! I really love this plugin. But I want to ask if I can use this to view activities like SCORMS, Assignments, Book, Page. Is it possible? Thanks in advance.
• 

  Tyron Delean

  Wed, 30 Apr 2014, 9:30 AM

  Just a suggestion to remove the deprecated code. The use of get_context_instance should be replaced. I have found that line 74 of view.php, and line 38 of imageadd.php should use $context = context_module::instance($cm->id, MUST_EXIST);. Also, line 56 of imageadd.php should be replaced with the following:
  if (!$files = $fs->get_area_files(
  context_user::instance($USER->id, IGNORE_MISSING)->id, 'user', 'draft', $draftid, 'id DESC', false)) {
  redirect($PAGE->url);
  }
  Thanks
• 

  Tyron Delean

  Wed, 30 Apr 2014, 9:38 AM

  Found 2 more. Line 74 of imageadd_form.php should be $usercontext = context_user::instance($USER->id, IGNORE_MISSING);. Line 51 of imageclass.php should be $this->context = context_module::instance($cm->id, MUST_EXIST);
  Thanks
• 

  Tyron Delean

  Wed, 30 Apr 2014, 9:48 AM

  After doing a full code search, there are a number of them. Sorry for doing this in 3 comments, but I only fixed the ones I got warnings for originally. The additional ones are as follows:
  \edit\base_class.php line 44
  \db\upgrade.php lines 209 and 210
  rsslib.php line 52
  locallib.php line 157
  index.php line 68
  lib.php lines 116 and 193
  imageedit.php line 44
  comment.php line 47
  I think that's all of them.
• 

  Tyron Delean

  Wed, 30 Apr 2014, 10:01 AM

  IGNORE_MISSING should be MUST_EXIST in both user context cases.
• 

  Adam Olley

  Wed, 30 Apr 2014, 11:03 AM

  Hi Tyron,
  Correct on all counts I'd say. Lightboxgallery hasn't had much code cleanup lately. I'll be doing some cleanup to make it work nicer with 2.7. Given all the api changes/deprecations since 2.3.
• 

  Adam Olley

  Wed, 30 Apr 2014, 11:03 AM

  Hi Tyron,
  Correct on all counts I'd say. Lightboxgallery hasn't had much code cleanup lately. I'll be doing some cleanup to make it work nicer with 2.7. Given all the api changes/deprecations since 2.3.
• 

  Tyron Delean

  Wed, 30 Apr 2014, 3:05 PM

  Ok great, as long as you are aware of it. Best Regards.
• 

  Jez H

  Thu, 22 May 2014, 9:02 PM

  Great plugin, a great improvement on the previous version, much appreciated, thanks!
• 

  Derek Chirnside

  Fri, 23 May 2014, 8:50 AM

  Any idea on an ETA for a 2.7 version?
  Just curious, as we start the upgrade testing
  -Derek
• 

  Nicolas Dunand

  Fri, 23 May 2014, 8:07 PM

  Hi, I just filed a pull request on GitHub, fixing these deprecated get_context() calls. Deprecated add_to_log() calls still to be fixed.
• 

  Adam Olley

  Tue, 3 June 2014, 3:15 PM

  Hi all,
  
  I've begun work on getting lightboxgallery working on 2.7. Strictly speaking, it should already work, however several parts of it are using deprecated functions/api's that need updating.
  
  I've flagged the following bits as needing attention for a 2.7 version.
  a) context classes (thanks to @ndunand for the context fixes - they've been merged in now.)
  b) Port add_to_log calls to events.
  c) Migrate comments to core comment API - lightboxgallery doesnt do anything fancy that core comments cant handle.
  d) fullname requiring additional name fields from queries to {user}.
  
  (a) has already been done as noted. I've partly completed (b) and am working on (c). I expect to have these all finished and a 2.7 version available this week.
• 

  Adam Olley

  Wed, 4 June 2014, 12:32 PM

  I've uploaded a version marked as a release candidate for 2.7. It takes care of a, b and d above. I haven't done (c) as it would actually make a few places in the module slower or more clumsy. Something for the future anyway.
  
  I also updated the user_complete and user_outline modules in lib.php to not require use of the {log} table. Lastly, I updated the javascript used for the lightbox to the version @brum1975 made a pull request with.
  
  Please file an issue on github if you try out the 2.7 version and run into any problems.
• 

  Alexander Deichman

  Mon, 9 June 2014, 10:41 AM

  I just left a comment on the discussion forum for a new future request: social image gallery - ability to add comments to picture(like facebook). Is it possible? From php and db perspective, it sure looks like it is but I haven't really looked too close.
• 

  Richard Chui

  Mon, 4 Aug 2014, 2:41 PM

  Is it possible to use Lightbox Gallery for videos? Thanks.