Hi Joseph,
Thank you for the sqlbuddy plugin submission. Your plugin installed fine and appeared to operate as expected on my Moodle 27. I browsed a few db's on my test system and dropped a few tables without any problems. I have to admit I've been a long time phpmyadmin guy but sqlbuddy seems like an interesting alternative.

The code checker plugin revealed a few minor style issues with the Moodle files in your plugin and a large number of style issues with the sqlbuddy code (mostly tab complaints). You should probably fix the style issues with the few moodle specific files version.php, settings.php etc.

i tested this on my Moodle 27 that uses mysql. What will happen if someone tries to uses Moodle/postgres?
Carl

Prechecker results: http://integration.moodle.org/job/Precheck%20remote%20branch/9617/artifact/work/smurf.html

Hi Carl,

Thanks for taking the time to review this plugin. I have made the necessary syntax changes and updated the plugin accordingly. Of course, I did not change the SQL Buddy source code, as that would have taken a while!

SQL Buddy works with MySQL. I do not believe it works with PostgreSQL. I created this plugin for clients using MySQL needing a simpler database interface.

Regards,
Joseph

Can we make it clear in the plugin description that this plugin works with MySQL sites please?

Hi David,

I updated the plugin description. Thanks for pointing that out!

Joseph

OK, so are we good for approval?

Joseph - Many thanks for your work on this. I see nothing that would hold up approval. Since it is a tool for working with MySQL databases it makes sense that it will only work for MySQL installs. It reminds me of the https://moodle.org/plugins/view/local_adminer. I did a quick search to compare Adminer and SQL Buddy and found a note at http://www.adminer.org/en/phpmyadmin/ indicating that SQL Buddy is no longer actively being maintained so folks may want to keep that in mind. Peace - Anthony

Joseph - One thing for us to consider before approving is whether you wish to rename the Github repository. When possible, I encourage folks to use the Moodle naming convention. So instead of https://github.com/CourseBit/local_sqlbuddy the better name would be moodle-local_sqlbuddy. This is not a requirement for approval but something I like to encourage just for consistency for those who do a lot of work with Git. Peace - Anthony

Repository name has been updated to moodle-local_sqlbuddy.

Joseph - With MDL-39840, it is now possible to include an environment.xml file with the plugin which could verify that the Moodle installation is using MySQL and if not prevent install on a Postgres database. The file would be ignored in versions prior to Moodle 2.8 but this may be a good way of testing that new functionality. Would you mind creating an environment.xml file and uploading a new version? If you prefer, you can just add an updated version for Moodle 2.8 with the environment.xml file. I'm going to go ahead and approve this but I think having the environment.xml file would be a nice addition and prevent someone from installing it if they are not using MySQL. Peace - Anthony

HI Joseph:

Thanks for the plugin! We had been using is in our Moodle 3.0, and now after upgrade to 3.6 this plugin gives an error : "Call to undefined function mysql_connect()". Would you please advise?
Thank you!
Leslie