Hi guys. Thanks for sharing this filter with the Moodle community. Prior to approving it, some issues must be clarified.

• Licensing of the ChemCollective code. I am afraid that the CC BY-NC-ND 3.0 license is not compatible with the GNU GPLv3. As such, it is not allowed to distribute your Moodle plugin code together with the ChemCollective code in one package. One option might be to distribute just the Moodle code via the Plugins directory, and admins would need to obtain required Java code themselves. It would help to have the plugin code restructured a bit so that it is clear what parts relate directly to Moodle and what is added to make the Java part work.
• Related to that is the fact that the Java code included in the JAR archives in your plugin seems to contain just the compiled .class files without the source .java files available. This again violates the GNU GPL license.
• On the same note, there is no sign on what license do the included fonts and assignments use and where they were obtained from.
• Localisation. Do I get it right that there is no English language pack available for the ChemCollective? We have a policy that all the plugins should provide the English interface at least.

I am going to mark this as needing more work for now to sort these issues out.

Hi guys. Thanks for the updated version. I appreciate your attempt to try and make the additional software downloader in-built into the filter to fix the licensing issues. There are some issues with the current implementation though.

• It is not clearly documented (here in the Plugins directory, in the README file and in the UI itself) what files and from what sources are to be downloaded and to where. Admins should be well informed on what is going on.
• If the web server process does not have write access to the filter directory, it does not cancel the installation but keeps trying to download and install all the files.

I would recommend to put the Java applet installer into a separate script within you filter and do to mix it with the filtering functionality. Make it available for the site admins only. Make it so the installation is not triggered by anybody but must be explicitly requested and confirmed by the site admin (as it is now, any call to format_text() may trigger the java applet installation). You can then put a link to this installer into the settings form of your filter and provide all the information about the process there. I really believe that would be cleaner solution from both technical and usability perspective. Let me know what you think.

Hi. Thanks for the new version. I think the new approach solves the licensing issue in a good way. While reviewing the code, I spotted two more issues that might be good to have sorted out before making the plugin available here. Especially the setting variables naming is better to have done correctly since the day 0, rather than having to write an upgrade step later.

Once the raised issues #2 and #3 are fixed, I believe this is good to be approved. Thanks for your patience with the review and approval process.