Comments

• 

  Plugins bot

  Wed, 25 Mar 2015, 4:50 PM

  Prechecker results: 26 errors / 12 warnings
  http://integration.moodle.org/job/Precheck%20remote%20branch/12090/artifact/work/smurf.html
• 

  David Mudrák

  Fri, 27 Mar 2015, 6:38 AM

  Thanks guys for sharing this plugin with the Moodle community. I appreciate the very clean coding-style and paying attention to details. I admit I did not have a chance to actually test the full functionality of the filter but I feel pretty confident in this case to go and approve it. You are cleared to land, welcome to the Plugins directory!
• 

  Ruslan Kabalin

  Sat, 28 Mar 2015, 12:44 AM

  @David, thanks for the feedback, it is a pleasure to hear! There are some minor issues which CI identified, I will fix them on master in due course.
• 

  Fernando Oliveira

  Tue, 21 Apr 2015, 10:49 PM

  Hello Ruslan and thanks for this plugin. Wondering if anyone has managed to remove the "jw player" watermark from the cloud-based player. Also wondering how to go about skinning the player. We purchased a license but there doesn't seem to be any way of modifying the player via the jw player website or the plugin config page. Thanks in advance.
  
• 

  Ruslan Kabalin

  Wed, 22 Apr 2015, 11:27 PM

  @Fernando, glad you like the plugin. We do not have JW Player watermark in our case, but we are using self-hosted version along with licence key. For cloud-based option, entering the account token, taken from your JW Player account page, should be sufficient to remove watermark, assuming the license you have allows that. Skins are not supported in the plugin, however adding support of standard skins is pretty easy task to do - I recorded this feature request: https://github.com/lucisgit/moodle-filter_jwplayer/issues/10
• 

  DPaW Web

  Wed, 29 Apr 2015, 10:31 AM

  This plugin is fantastic. Is there any chance to be able to make it responsive?
  http://demo.jwplayer.com/responsive-example/
  I'm trying to override with CSS but no luck so far.
• 

  Ruslan Kabalin

  Wed, 29 Apr 2015, 4:39 PM

  @DPaW Web Thanks, no plans to make it responsive unfortinately, the idea is to keep similar to core media player size at the moment for consistency reasons, though I will consider a pull request if respnsiveness will be an optional a plugin setting. I doubt you can do that via CSS, it is in setup parameters and only work in versions 6.3+.
• 

  DPaW Web

  Thu, 7 May 2015, 9:51 AM

  Thanks for the response Ruslan,
  
  One last thing to consider, if you know any better way to do it, is adding thumbnails.
  
  i'm currently doing like:
  < style > .jwuniform { background:url(/draftfile.php/2122/user/draft/5431423/Induction.jpg) no-repeat 0 0 !IMPORTANT;} < /style >
  Not ideal, and the WYSIWYG deletes the style tags every time you re-edit, but it does the jhob.
  
  thanks again
• 

  Ruslan Kabalin

  Wed, 2 Dec 2015, 11:02 PM

  @DPaW_Web FYI, plugin is now responsive and there is also a way to add "thumbnail" (you mean the image that is displayed when player is loaded?), just add a data-jwplayer-image="/draftfile.php/2122/user/draft/5431423/Induction.jpg" attribute to the media URL.
• 

  poorya md

  Tue, 15 Dec 2015, 3:45 AM

  I can not figure out how to use options in Jw-player.
  As I know, there must be a way to add image and/or subtitles to my player but I can not understand how!
  
  This is what I tried:

  
  And I'm sure that I'm doing it wrong! ))
  
  I'm using jw-player 6 (I need older IE compatibility)
• 

  poorya md

  Tue, 15 Dec 2015, 3:48 AM

  sorry!
  my code is like:
  /--a href="http://content.jwplatform.com/videos/3XnJSIm4-kNspJqnJ.mp4" data-jwplayer-image="http://content.jwplatform.com/thumbs/3XnJSIm4-640.jpg" data-jwplayer-subtitles="English,http://assets-jp.jwpsrv.com/tracks/2UEDrDhv.txt">Loading the player...//>
• 

  Owen Barritt

  Tue, 15 Dec 2015, 6:01 PM

  You want it to be as follows for the subtitles to work:
  
  /--a href="http://content.jwplatform.com/videos/3XnJSIm4-kNspJqnJ.mp4" data-jwplayer-image="http://content.jwplatform.com/thumbs/3XnJSIm4-640.jpg" data-jwplayer-subtitles="English: http://assets-jp.jwpsrv.com/tracks/2UEDrDhv.txt">Loading the player...//>
  Note this only works on the JW7 Moodle 2.9 version.
  
  You can also set a global default poster image in the filter settings on both versions of the plugin.
• 

  poorya md

  Wed, 16 Dec 2015, 1:20 AM

  Thank you,
  I'm using version: 2015080401 and JW6 (We need IE compatibility) in Moodle 3.
  I inspected code for 2 versions and found that some part of codes do not exist in my version (maybe was under development)
  So, I added codes to my version:
  1- // Process data-jwplayer attributes.
  to lib.php
  2- // Prepare options.
  to filter.php
  but it seems that "// Prepare options." is not working.
  
  Is there any other code I have to maintain somewhere?
  
  I'm trying because subtitles work fine when I use JW6 independent to filter using javascript codes in my content. But we need filters!
• 

  Owen Barritt

  Wed, 16 Dec 2015, 1:28 AM

  The commit that added the data-jwplayer stuff for the JW7 version is here: https://github.com/lucisgit/moodle-filter_jwplayer/commit/af1a5f097516a0fd5339bc41bdd3447dd9818fb8
  
  There were some changes in the filter.php file necessary to make this work too.