Comments

• 

  Anthony Borrow

  Sun, 25 May 2014, 1:14 PM

  aakon,
  
  Many thanks for sharing this plugin with the Moodle community. Please review the validation results and fix all of the issues mentioned. These changes are typically pretty easy to make but if you have any questions just let us know. In particular,
  
  Warning Release name ($plugin->release) not found in version.php
  
  I noticed that the zip files you uploaded did not specify for which version(s) of Moodle that they are intended but in the README file it said 2.3+ so I went ahead and selected that. I am testing with Moodle 2.7. I was successfully able to install the plugin and it appears to function as expected. I like the functionality and think this will be a really helpful addon for those making use of the book activity module.
  
  Please review http://docs.moodle.org/dev/Plugin_validation#Recommended_URLs and then edit the plugin entry to provide the source, tracker, and documentation URLs that will enable others in the community to more actively participate in using and maintaining this plugin.
  
  Please consider adding a screenshot of your plugin to help folks get an idea of what it looks like when installed.
  
  For now, I am going to mark this plugin as needing more work until we get the above issues resolved (mainly the URLs for source, tracker and documentation). Thanks for your patience with the review and approval process. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts.
  
  It is encouraged to follow Moodle's coding style as outlined in:
  
  http://docs.moodle.org/dev/Coding_style
  http://docs.moodle.org/dev/Coding
  
  Tthe code checker plugin can be quite helpful in fine tuning your code and can be found at:
  
  https://moodle.org/plugins/view.php?plugin=local_codechecker
  
  You may wish to consider using that tool to further improve your plugin. Below, are the initial results:
  
  Files found: 41
  mod/book/tool/importepub/locallib.php - 108 error(s) and 41 warning(s)
  mod/book/tool/importepub/lib.php - 26 error(s) and 2 warning(s)
  mod/book/tool/importepub/add_form.php - 21 error(s) and 4 warning(s)
  mod/book/tool/importepub/add.php - 36 error(s) and 8 warning(s)
  mod/book/tool/importepub/lang/sv/booktool_importepub.php - 14 error(s) and 0 warning(s)
  mod/book/tool/importepub/lang/es/booktool_importepub.php - 14 error(s) and 0 warning(s)
  mod/book/tool/importepub/lang/en/booktool_importepub.php - 14 error(s) and 0 warning(s)
  mod/book/tool/importepub/lang/nb/booktool_importepub.php - 15 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Rule/Rule.php - 290 error(s) and 3 warning(s)
  mod/book/tool/importepub/CSS/Value/Size.php - 119 error(s) and 3 warning(s)
  mod/book/tool/importepub/CSS/Value/ValueList.php - 74 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Value/RuleValueList.php - 9 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Value/URL.php - 34 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Value/String.php - 42 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Value/CSSFunction.php - 63 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Value/Value.php - 3 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Value/PrimitiveValue.php - 3 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Value/Color.php - 73 error(s) and 2 warning(s)
  mod/book/tool/importepub/CSS/Settings.php - 89 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Parser.php - 1441 error(s) and 11 warning(s)
  mod/book/tool/importepub/CSS/Parsing/UnexpectedTokenException.php - 63 error(s) and 1 warning(s)
  mod/book/tool/importepub/CSS/CSSParser.php - 14 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Property/Selector.php - 81 error(s) and 2 warning(s)
  mod/book/tool/importepub/CSS/Property/AtRule.php - 18 error(s) and 3 warning(s)
  mod/book/tool/importepub/CSS/Property/Charset.php - 48 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Property/Import.php - 74 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/Property/CSSNamespace.php - 90 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/RuleSet/AtRuleSet.php - 51 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/RuleSet/DeclarationBlock.php - 1461 error(s) and 13 warning(s)
  mod/book/tool/importepub/CSS/RuleSet/RuleSet.php - 220 error(s) and 3 warning(s)
  mod/book/tool/importepub/CSS/CSSList/KeyFrame.php - 93 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/CSSList/CSSBlockList.php - 183 error(s) and 1 warning(s)
  mod/book/tool/importepub/CSS/CSSList/CSSList.php - 126 error(s) and 1 warning(s)
  mod/book/tool/importepub/CSS/CSSList/AtRuleBlockList.php - 51 error(s) and 0 warning(s)
  mod/book/tool/importepub/CSS/CSSList/Document.php - 43 error(s) and 3 warning(s)
  mod/book/tool/importepub/index.php - 42 error(s) and 7 warning(s)
  mod/book/tool/importepub/import_form.php - 20 error(s) and 1 warning(s)
  mod/book/tool/importepub/db/access.php - 15 error(s) and 0 warning(s)
  mod/book/tool/importepub/version.php - 15 error(s) and 0 warning(s)
  mod/book/tool/importepub/modlib.php - 89 error(s) and 5 warning(s)
  mod/book/tool/importepub/README.txt - 1 error(s) and 0 warning(s)
  Total: 5286 error(s) and 114 warning(s)
  
  Peace - Anthony
• 

  Anthony Borrow

  Sun, 25 May 2014, 1:19 PM

  p.s. - I noticed that some of the copyrights reference a previous author. It is preferred that all of the files that you have modified for this plugin have your name added as a copyright holder.
• 

  Plugins bot

  Mon, 12 Jan 2015, 5:11 AM

  Prechecker results: error
  http://integration.moodle.org/job/Precheck%20remote%20branch/9591/artifact/work/smurf.html
• 

  Anthony Borrow

  Sat, 17 Jan 2015, 7:49 AM

  Haakon - Thanks for the updated version of the plugin. I was able to get the plugin to install with no issues using Moodle 2.7 and it functions as expected. Before approving, I would like to see some of the requested URLs for the source code, tracker and documentation so that the community can participate in giving feedback. Peace - Anthony
• 

  Anthony Borrow

  Sat, 17 Jan 2015, 7:50 AM

  p.s. - The previously mentioned copyright issues have been cleaned up and most of the coding issues are whitespace/comment related.
• 

  Anthony Borrow

  Sat, 17 Jan 2015, 8:03 AM

  Haakon - I discovered that you do have a Github account, I would suggest creating the repository moodle-booktool_importepub and adding the code there. You may also want to create branches like MOODLE_28_STABLE for each major version of Moodle. Then you can use the links to the repository for the source code URL and Github's issues for the Tracker URL. Since the code is fairly simple, you could simply point to the README file. A screenshot would be nice showing the options for importing epub (but not necessary). Peace - Anthony
• 

  David Mudrák

  Mon, 19 Jan 2015, 6:54 PM

  Thanks for the review Anthony. My +1 to go live with this once the missing meta-data are filled as you suggested. Haakon, you may wish to check https://docs.moodle.org/dev/Plugin_contribution_checklist#Meta-data for more details.
• 

  Anthony Borrow

  Wed, 21 Jan 2015, 5:53 AM

  Haakon contacted me and will be contacting the author of the plugin as well so that we can get the meta-data sorted out. For now, I am going to mark these as needing more work and once the meta-data is provided it can be scheduled for a quick review. Peace - Anthony
• 

  Haakon Meland Eriksen

  Thu, 11 June 2015, 1:37 PM

  I have imported Lucimoo ebook import into this Git repository at GitHub:
  
  https://github.com/HaakonME/Lucimoo-ebook-import