@Peter - thanks for the update - I'm glad it's usable for you again. I think the login screen is a system dialog so I'm not sure I can do anything about it.

Sadly ... a problem has seemed to come up with 3.3.1

The fixed shares seem to come up fine... but when I try to access my Home directory (presumably dynamic) .. it comes up with this error

Coding error detected, it must be fixed by a programmer: print_header() can not be used any more. Please use $PAGE methods instead.

More information about this error

Hi folks, I have uploaded the latest Master version from GitHub and it has now allowed access to the shares again, however the home directory is not accessible by students or staff even though as before the field is populated in AD. I should say that all was working fine before we upgraded to 3.3.1 on Ubuntu 16.04 at the beginning of the summer.

When accessing the home directory this message appears.

Sorry, you cannot view your homedirectory online

Error Message: No home directory specified in ldap for this user

Any ideas?

Cheers

Colin

Update, with debugging turned on this error message appears,
Notice: Undefined index: homeDirectory in /var/www/html/blocks/smb_web_client/class_smbwebclient_moodle.php on line 164

Colin

Hi Colin / Peter. Thanks for reporting these recent bugs. I'm sorry I haven't been unable to replicate it or fix it as I haven't had the time to set up an LDAP server + shares. I'll do this as soon as I get some time.

Hi Guy,
Have you had any opportunity to take a look at this issue. I know you are extremely busy and appreciate that this is not your full time. job.

I have staff and students really desperate to access their files from home.

Hope you are well.

Colin

I've fixed windows share web client with 3.3: You can download it from: https://github.com/gthomas2/moodle-block_smb_web_client

Sadly, to make the plugin pass all Moodle's coding style checks I'd have to do some significant rewriting which is why you can only get it from github.

Thanks Guy, much appreciated. Best regards, Colin

All good here too... many thanks

I just wonder if you can help. On Moodle 3.5 with PHP 7.1we are getting the following error: Coding error detected, it must be fixed by a programmer: print_header() can not be used any more. Please use $PAGE methods instead.

@Lukasz - I haven't had time to do a Moodle 35 version yet, sorry

Guy,

Sorry to be a pain.. but I have just upgraded to Moodle version 3.7.1 on Ubuntu 18.04, and more importantly, PHP 7.2.
When I try to use the block I get this error .................

Warning: session_name(): Cannot change session name when session is active in /mnt/d2/moodle/blocks/smb_web_client/class_smbwebclient.php on line 267

This appears to be a known problem with PHP 7.2 as other people are complaining as well..
For instance https://bugs.php.net/bug.php?id=76358

Would you have a moment to have a look... ?

Yours in hope
Peter

Think I have fixed it.. PHP 7.2
It was related to changing the session name when it had been previously defined.

After a look around, the session name has already been defined in the include file... so this is redundant ?? Cannot see anywhere to change it on the config page..

So I just commented out this line of code in the routine and it seems to work fine..

@Peter - thanks for fixing it. Would you like me to make you a maintainer of this project?

@Guy ... cheers for the kudos.... sadly it was more a matter of good luck, rather than skill. My php skillset is way below what is required for this sort of work.

But tx again for compliment...