Geoffrey - Thanks for sharing this plugin with the Moodle community and for all your work especially with creating Atto plugins for STEM courses. I have installed the plugin and it works as expected. I have 2 small concerns/questions. The first has to do with the name of the repository which ideally (ie strictly following the repository naming protocol that is encouraged would be moodle-atto_computing. I noticed that you have others which have been approved already with your own naming convention so it seems fine to leave it as it. The other has to do with the instructions listed in the readme file to copy the image file to pix/e. I want to take a closer look at the resolve_image_location function to see why it may not be finding the image. I am thinking that copying should be considered a workaround but that we will likely want to create an issue in the tracker so that copying it is not necessary. Otherwise, things look good and I think this can be approved rather quickly.

It is encouraged to follow Moodle’s coding style as outlined in: http://docs.moodle.org/dev/Coding_style and http://docs.moodle.org/dev/Coding The code checker plugin can be quite helpful in fine tuning your code and can be found at: https://moodle.org/plugins/view.php?plugin=local_codechecker You may wish to consider using that tool to further improve your plugin. Below, are the initial results (excluding the js files as they tend to throw a lot of issues):

Files found: 6

lib/editor/atto/plugins/computing/lib.php - 2 error(s) and 3 warning(s)
lib/editor/atto/plugins/computing/lang/en/atto_computing.php
lib/editor/atto/plugins/computing/styles.css
lib/editor/atto/plugins/computing/ajax.php
lib/editor/atto/plugins/computing/version.php
lib/editor/atto/plugins/computing/settings.php - 4 error(s) and 7 warning(s)

Total: 6 error(s) and 10 warning(s)

Most of these are rather insignificant spacing issues but I figured I would mention it so you can tidy it up when you have nothing else to do ;)

Peace - Anthony

Geoffrey - Is there a reason why you did not make computing/pix/e/desktop.png computing/pix/icon.png? This seems to be what would be expected in terms of the default image name/location.

Hi Anthony

I called it desktop.png because, as a workaround, it needed to be copied into core pix/e (but see below).

I tried using iconComponent: COMPONENTNAME, as suggested by David Mudrák, together with an svg version of the icon and keeping the icons in the plugin pix (or pix/e) but had issues. Blocked full display of the Atto toolbar at the 'offending' button.

So, reverted to the workaround of moving to core pix/e.

Suspect, I am doing something daft. Perhaps if I name them icon.png and icon.svg they will work? More than happy to implement a more elegant and installer-friendly fix.

Local icons (svg and png) now fixed!

Geoffrey - I am glad to see you were able to figure out how to use the icon image files in the plugin. I am going to go ahead and approve this plugin. Peace - Anthony

Thanks Anthony
I'll tidy the code with the code checker plugin, as suggested.
Then, if no more significant bugs emerge, make this a stable release (rather than release candidate).

I just wanted to say that this plugin is excellent and it is great to see contributed plugins for Atto that are so useful.

Thank you very much for creating and sharing this plugin.

will there be a version for moodle 3.3?