"There are only two hard things in Computer Science: cache invalidation and naming things."
-- Naming things is hard
This is not the first time when such a change is proposed. I believe I have already put my opinion before, but I can't find it now.
I do not think we should rename it, this has my -1 for now.
I do understand and respect the reasoning for proposing this change. But any module name will always be just a simplified label representing the wide range of features and pedagogical scenarios that a module can support. Some modules have more self-descriptive names, some are less obvious. If we rename Workshop, what should come next? Lesson? Hotpot? PoodLL? URL? SCORM? Dozens others from the Plugins directory?
I actually always liked the word Workshop for this. I have imagined it as a place where students are encouraged to create / craft something useful for the others, share it with the others, and get feedback from the others. It has always strongly resonated with the social constructivism pedagogy in my mind. I would actually prefer to improve the module so it feels even more like a real workshop with all the tools that can be used to actively produce awesome things, rather than renaming it to something that facilitates just the assessment part of it.
What I agree with is that all module names could and should be de-emphasized from the students UI. Students should not need to be aware what "Workshop" or "Foobar" module does. The name of the particular activity instance should be the primary guideline for them and the UI combined with the provided descriptions and instructions should be just intuitive. Let's work on that, no need to repaint this bike shed IMHO.