Themes

ATTO Editor More Font Colour display not showing in Adaptable Themes

 
This discussion has been locked because a year has elapsed since the last post. Please start a new discussion topic.
RabNawaz
ATTO Editor More Font Colour display not showing in Adaptable Themes
 

Hi Fernando Acedo,

Thanks for the great Adaptable theme, I am using adaptable theme with two MOODLE sites ( 3.1.1 and 3.0.1 versions) with Adaptable theme (1.2.3 and 1.2.1 respectivle). I have successfully installed MoreFontColors in Atto. 

Please see the below snapshot- when I try to change the color its dropdown menu doesn't show the color instead it shows the lines, though it change the color once i randomly select any lines.....  

It should show something like the below given image,

Thanks in advance for the time and consideration.

  

(Edited by Mary Evans - Split and changed subject title - original submission Sunday, 18 September 2016, 2:44 PM)

 

 
Average of ratings: -
Picture of Fernando Acedo
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Particularly helpful MoodlersGroup Plugin developersGroup Testers

Please, search before ask. This issue was already reported and fixed:

https://moodle.org/mod/forum/discuss.php?d=331879#p1354155

It will be included in next release.

 
Average of ratings: -
It's only an avatar...
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Documentation writersGroup Particularly helpful MoodlersGroup Plugin developersGroup Testers

Fernando,

Surely this is not a theme specific problem? I would have thought that this should be part of Moodle CORE in  lib/editor/atto CSS?

Just a thought?

Cheers

Mary

 
Average of ratings: -
Picture of Fernando Acedo
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Particularly helpful MoodlersGroup Plugin developersGroup Testers
Mary, in my personal opinion is an Atto issue but actually is already fixed in Adaptable.
 
Average of ratings: -
Gareth J Barnard
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Particularly helpful MoodlersGroup Plugin developers

Hi Fernando,

So.... its fixed in Adaptable for ATTO but in fact is an ATTO issue, therefore could / is there a core tracker issue with the patch so that we all benefit?

G

 
Average of ratings: -
Picture of Fernando Acedo
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Particularly helpful MoodlersGroup Plugin developersGroup Testers

Gareth,

the style that fix the issue is locate in the link I posted and was submitted by an user.

If you test Essential and find the same issue and you can fix it using the same patch then feel free to open an issue in the tracker.

I will not open no more issues in the tracker because tired of the answers and the response time.



 
Average of ratings: -
Gareth J Barnard
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Particularly helpful MoodlersGroup Plugin developers

Fair enough, as its the MoreFontColors plugin issue (therefore something Moodle Tracker will ignore), I've commented Hartmut's solution on: https://moodle.org/plugins/atto_morefontcolors for the plugin to supply the CSS.  Thus I've written:


Please read: https://moodle.org/mod/forum/discuss.php?d=339997 and add:

.editor_atto_menu .open ul.dropdown-menu {
min-width: 4em;
}

from: https://moodle.org/mod/forum/discuss.php?d=331879#p1354155

to the plugin style sheet.

 
Average of ratings: -
Picture of Fernando Acedo
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Particularly helpful MoodlersGroup Plugin developersGroup Testers

This looks better:

.editor_atto_menu .open ul.dropdown-menu {
min-width: 3.5em;
}

 
Average of ratings: -
It's only an avatar...
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Documentation writersGroup Particularly helpful MoodlersGroup Plugin developersGroup Testers

Hi Gareth,

I still think that there is a need to add a setting in Moodle Core for that the dropdown as it is in effect Bootstrap CSS as there is already that same group of CSS selectors present. See here: https://github.com/lazydaisy/moodle/blob/master/lib/editor/atto/styles.css#L179-L182

In actual fact might even be worth opening up a tracker to add a colour chart like TinyMCE has if ATTO is going to be the Moodle default editor?

@Fernando: As for never wanting to add a Tracker for anything, just because of past disappointments, then how will Moodle HQ ever know what users wants/needs...they are not Magicians by any stretch of the imagination?

Cheers

Mary

 
Average of ratings: -
Picture of Fernando Acedo
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Particularly helpful MoodlersGroup Plugin developersGroup Testers

Mary, I don't take care of the issue origin. Can't spend time if it is already fixed.  As I said, IMHO it is an Atto issue but not sure if directly or is part of the Atto plugin. I will not investigate it.

And you answered your question yourself. Why report an issue when nobody takes care of it? At the end, doesn't matter if you report it or not.

And especially, I will not report those issues related to Atto. All we know it is a crap but looks like only a few of us really know it is. For the rest (I mean HQ only) is the perfect editor (sorry, no. not perfect. Even beyond perfection).

So no, no more reporting except if it is a moodle core bug. For the rest of issues, they (HQ) can spend the time developing and testing like the rest do.

As we say in spanish, nos quieren vender la moto.



 
Average of ratings: -
It's only an avatar...
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Documentation writersGroup Particularly helpful MoodlersGroup Plugin developersGroup Testers

Actually, if you had investigated it you would have found what I found today.

Checkout my comment to Richard ...

https://moodle.org/mod/forum/discuss.php?d=339997&parent=1370517

hastas la vista...

Mary

 
Average of ratings: -
Gareth J Barnard
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Particularly helpful MoodlersGroup Plugin developers

Hi Mary,

Pragmatically even though it might be a good core change, you'll never get it past the 'Integrators' unless the change pertains to something in core itself.

G

 
Average of ratings: -
Picture of Richard Oelmann
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Particularly helpful MoodlersGroup Plugin developersGroup Testers

Has this issue been seen in any other theme? I wasn't able to replicate it in Clean, More, Essential, Flexibase, or a custom theme based on theme_bootstrap.

 
Average of ratings: -
It's only an avatar...
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Documentation writersGroup Particularly helpful MoodlersGroup Plugin developersGroup Testers

Hi Richard,

I saw this comment here last night but was too tired to check it out, but boy am I glad I did today!

The problem is an Adaptable one ONLY as far as I can see. It stems from this particular CSS in Adaptable/style/menu.css where the min-width is 250px

https://bitbucket.org/covuni/moodle-theme_adaptable/src/f3cf46e353839f7b89d584c83348024f870cc1ca/style/menu.css?at=master&fileviewer=file-view-default#menu.css-85

It appears that the More Colour Font plugin is geared up to use the width that Moodle has as default and so has set this in the plugins style.css

.atto_morefontcolors_button .dropdown-menu {
    min-width: inherit;
}

On top of this, it looks like Adaptable has set another CSS fix for ATTO with this CSS...

.editor_atto_menu .open ul.dropdown-menu {
    min-width: 3.5em;
}

https://bitbucket.org/covuni/moodle-theme_adaptable/src/f3cf46e353839f7b89d584c83348024f870cc1ca/style/adaptable.css?at=master&fileviewer=file-view-default#adaptable.css-795

 
Average of ratings: -
Picture of Fernando Acedo
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Particularly helpful MoodlersGroup Plugin developersGroup Testers

Mary, all you say was discovered when this issue raised in March. This Atto plugin uses the default style instead use its own. That is a bad practice because you relay all the styles to bootstrapbase and the theme the site uses. If some theme uses a different style or bootstrapbase changes in the future, the plugin breaks and this is what happened in this case.

So I repeat again. It is an Atto issue, not related to Adaptable.

Since the patch provided works, then the issue is fixed and solved.

If you take a look to the repo, we are updating it every day and you can see the issue was fixed 2 days ago. So it is not available in the stable version.

And yes, I still think Atto is crap that should be removed from the editors.






 
Average of ratings: -
It's only an avatar...
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Documentation writersGroup Particularly helpful MoodlersGroup Plugin developersGroup Testers

It's defiantly NOT an ATTO bug, as it works in Clean & More themes. It works in my Morecandy theme too. But it fails in Adaptable.

I suspect too that it will work in Essential, but I have not tested it yet.

 
Average of ratings: -
Picture of Richard Oelmann
Re: ATTO Editor More Font Colour display not showing in Adaptable Themes
Group Core developersGroup Particularly helpful MoodlersGroup Plugin developersGroup Testers

I have and it does

Tested:

Clean - OK

More - OK

Flexibase - OK

Pioneer - OK

Snap - OK

Essential - OK

Adaptable - FAIL

Therefore an Adaptable issue, regardless of what Fernando thinks of ATTO as an editor - But I'll stay out of that debate as i have my own views, both on ATTO itself and on the comments made and have no desire to prolong this discussion.

BUT - its already fixed in Adaptable, just waiting to be released, so really this is a dead topic, as it is already fixed in the theme, where the issue is.

 
Average of ratings: -