Essential Theme Broken on Latest Update

Essential Theme Broken on Latest Update

by Ron Walker -
Number of replies: 27

So, I just updated to the most current version of Moodle. Along with it came the update for the Essential theme. After it was installed, all of the theme fonts where a light blue, the background image are missing, and the category folders are no longer displayed.

I restored and reinstalled 3 times with the same result.

Is it just me? Or, is everyone having this problem?

Any thoughts, ideas, or suggestions?

Thanks, Ron


Average of ratings: -
In reply to Ron Walker

Re: Essential Theme Broken on Latest Update

by Howard Miller -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers

Have you installed the correct/latest version of the theme for your new version of Moodle? 

In reply to Howard Miller

Re: Essential Theme Broken on Latest Update

by Ron Walker -

Yes (4 times). It was upgraded automatically with the new version of Moodle.

Thanks for the reply

In reply to Ron Walker

Re: Essential Theme Broken on Latest Update

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Yes it is an it is a complete mess! There are no other words for it.

In reply to Mary Evans

Re: Essential Theme Broken on Latest Update

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok, I've torn myself away from what I was doing to attempt to sort the most contentious issue over font colour.

To this end I have produced a version with a new text colour setting: https://github.com/gjb2048/moodle-theme_essential/tree/MOODLE_26_text_colour - this is identical to the release version but with this new functionality (you may need to perform a Purge All Caches).  I cannot stress enough that you MUST test this on a test environment and make a backup of the theme before proceeding at your OWN risk.

The code needs to be reviewed by David (as we are working as a team) before it is officially released: https://github.com/DBezemer/moodle-theme_essential/pull/62.

I have deliberately not altered the release version from 2014071702 to make putting back the old code simpler.

In reply to Gareth J Barnard

Re: Essential Theme Broken on Latest Update

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

I think you need to disbable the Alternative colours as these seem to conflict with the default which is set seperately and yet seems to be coder differently as the default might be SHOCKING PINK, and the other colours RED / GREEN / BLUE  and for some reason all the colours seem to come together as a multicoloured dreamcoat of a theme, so all we need now is a BLACK background and some gif animations and we would have our own geoessentialntheme! LOL

It might help if the settings.php held ALL THE SETTINGS CSS, and the essential.css just the theme styles.

This way the custom settings would overrule the theme general CSS if the settings.css is called last.

Cheers

Mary

In reply to Mary Evans

Re: Essential Theme Broken on Latest Update

by Donna Hrynkiw -

Hello Mary,

Was that a reply to me? ("...you need to disable Alternative colours...") We don't currently have them enabled, and the pale blue colour in question doesn't appear there in any case.

Although it's interesting you should mention Alternative colours, as I'd been using them to temporarily distinguish the site in question from another instance of Moodle I was working on. It was the first thing I thought of checking when I noticed the light blue icons.


Hrynkiw, Kwantlen

In reply to Donna Hrynkiw

Re: Essential Theme Broken on Latest Update

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi, No I was talking to Gareth...at least answering him I thought! LOL

It's crazy busy here and I am loosing track on a laptop that is not mine while grandchildren running in and out. smile

In reply to Ron Walker

Re: Essential Theme Broken on Latest Update

by Donna Hrynkiw -
We're running Moodle v2.6.4 (Build: 20140714), and have just installed Essential v2014071701 (previously v2014020300).

I was surprised at how many of the previous version Essential theme settings were overwritten and had to be reset.

One of our primarily reasons for upgrading the theme was to re-enable block docking (I miss it desperately). https://tracker.moodle.org/browse/MDL-38923
I don't see any "dock this block" settings in the blocks. I'm guessing that the mods listed in this thread still need to be applied; can anyone confirm?  https://moodle.org/mod/forum/discuss.php?d=261390

I'm actually happy that the monstrous category icons are gone (I much prefer a list view, or at worst, much smaller icons), but the odd category boxes as mentioned by Ron are a non-starter.

We're also seeing this (screenshot below), which is probably related to Ron's light-blue theme fonts issue above. Our theme is a dark red, but many icons are ignoring the theme colour settings and showing in light blue.


Screenshot; some icons are red, many are light blue


Hrynkiw

Kwantlen Polytechnic University

In reply to Donna Hrynkiw

Re: Essential Theme Broken on Latest Update

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Docking works in 2.7 for Bootstrapbased themes like Essential. It is just that essential is not got the setting in the config.php.

$THEME->enable_dock = true;

In reply to Donna Hrynkiw

Re: Essential Theme Broken on Latest Update

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Some of the icons are FontAwesome and some a SVG's with a fixed colour.  There is nothing the theme can do to replace all icons with FontAwesome and therefore no way for the UI to dynamically change the SVG's colour.  Therefore I'll probably fix the FontAwesome colour in CSS such that it matches the RGB code of the icons.  Then anybody wishing to change them can change the CSS and recolour all of the icons.

In reply to Gareth J Barnard

Re: Essential Theme Broken on Latest Update

by Jeremy Schambaugh -

Why even have fixed colored icons at all?  Doing so essentially defeats the purpose letting users customize the theme colors.  Why not revert back to the default Moodle icons that were in place before this current version of Essential with the grey color?  From a design standpoint wouldn't grey, for the most part, match any custom theme colors users choose?


I'm also not fond of the idea that if a user wants to use different colored font they would have to manually recolor then all.  That would be tedious to the "342" files listed in both the pix_core and pix_plugins folders!


screenshot

In reply to Jeremy Schambaugh

Re: Essential Theme Broken on Latest Update

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

I am in aggrement with the gray icons.

Perhaps if the fontawesome colour was left at grey that would give us some breathing space. Then have a vote for those who want a font colour setting?

In reply to Mary Evans

Re: Essential Theme Broken on Latest Update

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
In reply to Gareth J Barnard

Re: Essential Theme Broken on Latest Update

by Jeremy Schambaugh -

I like that the color of the FontAwesome icons are tied to the theme color, to me that makes sense.


Not so much with the hard coded colored icons as seen above in Donna Hrynkiw's post.

In reply to Jeremy Schambaugh

Re: Essential Theme Broken on Latest Update

by David Bezemer -

Jeremy and others, the actual problem is that ideally we would not use any of the svg icons, but unfortunately Moodle is made that way. As a way to show that we can actually color them we included default colored icons. 

When Moodle solves  this very annoying tie in to the hardcoded icons, we can check this off as well

 

In reply to Mary Evans

Re: Essential Theme Broken on Latest Update

by Jeremy Schambaugh -

I agree completely with what Mary said about the gray icons/FontAwesome.

In reply to Donna Hrynkiw

Re: Essential Theme Broken on Latest Update

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok, I've updated https://github.com/gjb2048/moodle-theme_essential/tree/MOODLE_26_text_colour such that the icon colour is fixed to that of the SVG colour.  This has happened in a few places and does fix the navigation menu.  However, it need not be so drastic as there are places where only the FontAwesome icon is used and therefore could be changeable in a setting (including alternative colours) if desired and you tell us.

In reply to Gareth J Barnard

Re: Essential Theme Broken on Latest Update

by Usman Asar -
Picture of Plugin developers Picture of Testers

This fix has fixed plenty of color issues, can we get text color as default black/grey as it use to be in Julian's version, as shown in picture below. 



Apart, there is a weird issue I experienced.


I have used Font Awesome in course summary block as shown.




Now as if click HOME on my Bread Crumb, it shows up as it is, but when clicking COURSES or CATEGORY link on bread crumb, it shows up like this.  Normal Text written however remains OK.



In reply to Usman Asar

Re: Essential Theme Broken on Latest Update

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok,

Please can I ask a question?  Is anybody actually reading my posts?

There seems to be multiple repeated complaints about the same thing over and over and over again.  Yes, I realise that the perception of the latest release is that it has gone backwards.  But, David and I have spent hours addressing issues with the theme.  We do understand that there is much more to do.  And at the same time there is a need to progress the theme forwards after months of stagnation.

To repeat again what I stated here: https://moodle.org/mod/forum/discuss.php?d=264247#p1145548 - I have conceded that the font issue needed to be addressed and hence the improvement in this version: https://github.com/gjb2048/moodle-theme_essential/tree/MOODLE_26_text_colour.

And just to be sure, this version: https://github.com/gjb2048/moodle-theme_essential/tree/MOODLE_26_text_colour.

But in case you missed it, this version: https://github.com/gjb2048/moodle-theme_essential/tree/MOODLE_26_text_colour.

This version: https://github.com/gjb2048/moodle-theme_essential/tree/MOODLE_26_text_colour addresses both the font issue and the FontAwesome / icon colour discrepancy.  Which is further detailed in this post: https://moodle.org/mod/forum/discuss.php?d=264247#p1145548.

I have listened and realised the issue over the font and icon and then done something about it.  So please kindly stop complaining and bashing me over the head multiple times about the same thing that has been reported before.  If its a new issue, then good, David and I want to make Essential even better with more functionality and brought up to date.  But this will take time, be patient, and even better, contribute to this 'community' driven theme.

In reply to Gareth J Barnard

Re: Essential Theme Broken on Latest Update

by Usman Asar -
Picture of Plugin developers Picture of Testers

Apologies Gareth,

I just over looked the new text color box that appeared as when installation completed, did re-install again and text color worked perfect.

In reply to Usman Asar

Re: Essential Theme Broken on Latest Update

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Apology accepted Usman.

In reply to Gareth J Barnard

Re: Essential Theme Broken on Latest Update

by Jeremy Schambaugh -

Gareth I have a question about the "text colour" version you mentioned a couple of posts up.  In the official 2.7.3 release the FontAwesome icons look to be tied to the theme color, whereas in the text colour version they are now blue and don't seem to be able to be changed.  Am I missing something or can the FontAwesome icons color be changed?

In reply to Jeremy Schambaugh

Re: Essential Theme Broken on Latest Update

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hi Jeremy,

Oh absolutely.  The FontAwesome colour can be changed and indeed via a setting in the user interface.  The problem arises when the JavaScript injects images despite the core code knowing the replacements.  To explain further, Essential has these methods: https://github.com/DBezemer/moodle-theme_essential/blob/master/renderers/core_renderer.php#L208-L255 - they tell the core what to use as replacement icons.  However, this information is not passed to the JavaScript code: https://github.com/moodle/moodle/blob/MOODLE_27_STABLE/lib/yui/src/dragdrop/js/dragdrop.js#L7-L9 and https://github.com/moodle/moodle/blob/MOODLE_27_STABLE/lib/yui/src/dragdrop/js/dragdrop.js#L147-L160 where an img tag is directly used instead of the code returned here: https://github.com/DBezemer/moodle-theme_essential/blob/master/renderers/core_renderer.php#L251 therefore you get the situation as shown here: https://moodle.org/mod/forum/discuss.php?d=264247#p1145617.  This sort of thing has been known about for some time, i.e.: MDL-40759 and indeed would help with MDL-41739 when you wanted to change the colour easily given a theme's background to support accessibility.

So, in the places where the two systems collide, then the icons must be of fix colour.  Where they are all FontAwesome, then a CSS colour changer can be employed.  Please let us know where these areas are from your perspective by raising an issue on: https://github.com/DBezemer/moodle-theme_essential/issues if not already reported.

Cheers,

Gareth

In reply to Gareth J Barnard

Re: Essential Theme Broken on Latest Update

by Donna Hrynkiw -

Yay! You fixed the "bright green background in the login username/password fields" thing. Been driving me NUTS. (The green with our red theme was making the site look annoyingly... Christmas-y.)

In reply to Ron Walker

Re: Essential Theme Broken on Latest Update

by Ron Walker -

Hi Gareth,

I am just happy to know it wasn't something I did. 

3 weeks ago, I  spent hundreds of dollars to have my Wordpress site match the Essential Moodle theme.

I trust it will be fixed and am awaiting the next stable update.


In reply to Ron Walker

Re: Essential Theme Broken on Latest Update

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Gosh...hundreds of dollars...wow! I am sure Gareth would make you a bespoke Essential theme for a few dollars! smile

Joking apart it may be easier for you if you made a list of requirements specific to your site which could in the end be a child theme with only the bare essential settings to make it more compact and easier to use and possibly faster at the same time..just a thought seeing that you have gone to such lengths to customise Wordpress!

 cheers

Mary