Gradebook

Just to clarify, were the grades calculated correctly, and just the total incorrectly displayed or were the grades given calculated as though the category was worth 240 points?
Very difficlult to said because in my case in fact each student has only 1 grade out of the 12 in the category (this is the reason why I use "drop lowest 11" : I can group 12 differents tests submitted in small students groups in computer labs) so the resulting grade is in fact the only grade each student has.

And this is working as expected : if for instance a student has :

- - - - - 16 - - - - - - the grade for the category is 16 (good) so from my point of view only the displayed total (260) is wrong. And what I don't clearly understand is why for the first category it worked (the total displayed for the category is 20 as expected).

As You see I don't use %, only points and points total, but just to test I displayed percentages and a student having 20 is displayed as 8.33% (EVEN FOR THE FIRST CATEGORY showing points (20) in the header) so clearly it is counted as 20/240 = 8.33%

Next Monday I am starting the 3rd category with 12 other tests so just to better understand the problem I created a 3rd category with another serial of 12 tests and it also showed as points(240).

Concerning you gradebook implementation, May I add that I find the GUI very well done and I just had a look at the code but it appear very structured and clear.

I don't know if I am the only one using it on a non english website but there is still some hardcoded strings in grades.php :

 if ($preferences->use_advanced ==0) {
  print '<option value=0 selected>No</option><option value=1>'.$stryes.'</option>';
 }
 else {
  print '<option value=0>No</option><option value=1 selected>Yes</option>';
 }

should be :

 if ($preferences->use_advanced ==0) {
  print '<option value=0 selected>'.$strno.'</option><option value=1>'.$stryes.'</option>';
 }
 else {
  print '<option value=0>'.$strno.'</option><option value=1 selected>'.$stryes;'</option>';
 }

Again thanks a lot for this nice Moodle addition.

Jay,

Thanks for your reply. The problem here is one associated with the forum module. It does not return a max grade as suggested by the module template (there is no API for this, my mistake in suggesting so). So if the grade is to show up in the gradebook and count towards a students grade we should expect the module to let us know what the maximum available should be, right? I do not quite follow your calculation of a grade. Where do the numbers 0+2+12+12 come from? How do we know these are correct? Regardless, all of these details should be handled by the module and the results returned as a max grade in the module lib.php file.

Michael has suggested to assign 100 as the max grade for any graded item that does not return a max grade. I think this is probably the most correct/universal solution as any other number is to some effect going to be arbitrary. If it should be something else then the module should let us know. The scale grade in the advanced settings could be used to to adjust the assumed max grade of 100 as appropriate.

I think this is the solution we will go with as any other solution overly complicates the gradebook when it is the modules responsibility to return a max grade. This way graded items are not "thrown out" as well.

Jeff