Prechecker results: http://integration.moodle.org/job/Precheck%20remote%20branch/9624/artifact/work/smurf.html

Andreas - Before we move forward with the review, I would like to make sure that we have the meta-data. Please review https://docs.moodle.org/dev/Plugin_contribution_checklist#Meta-data, update the entry, and then re-schedule this for review. For now, I am going to mark this plugin as needing more wok until we get these issues resolved. Thanks for your patience with the review and approval process. Peace - Anthony

Hello Anthony, sorry about that, I had the information filled in but parts of it got lost - anyway I updated again, hope this works now, regards Andreas

Thanks Andreas, could you also fill in the Tracker url. Peace - Anthony

done! cheers, Andreas

Thanks Andreas. I was able to install the plugin and did some simple testing. In looking at the code, I was curious about classes/question_bank_column.php - you do not seem to be using it. Was that just something from testing? From the UI, I am missing where you can save, list and delete filters. I see that you are creating a table to store some information in but I'm missing how it is actually used. Also, in the lib.php there seems to be some unusual code:
function local_question_filters_question_bank_column_types($question_bank_view) {
echo 'z'; exit;
Could you help me to better understand the purpose of what is happening? I want to make sure that there are not any unnecessary files included in the zip and from what I can tell the classes folder is not needed but I may have been overlooking something. Peace -Anthony

hi anthony,

question_bank_column.php and the function local_question_filters_question_bank_column_types
where just for testing, i deleted those.

the table local_question_filters is storing the current filter settings for a question.
it is used in the lib.php

the plugin actually also contains custom scripts which we do not want to publish. everything can be found on github: https://github.com/gtn/moodle_question_filters/tree/master

the main function of the module is to easily find questions in large question-pools using logic:
it enhances the question bank with following search fields:
question name: text is searched within a title
question text: text is searched within a text
default mark: operators like < > = >= and <= can be used to filter questions with certain marks.

regards,
Andreas

Andreas - I like the additional functionality and I was able to test it; however, I noticed some hard coded German phrases in lib.php that you can fix up pretty easily by using get_string calls for the labels. For example,

$return .= html_writer::label('Fragetitel', 'filter_name');

Let's make Fragtitel translatable. You may just want to use questionname, questiontext, and defaultmark from lang/en/question.php rather than creating extra strings.

For now, I am going to mark this plugin as needing more work until we get these issues resolved. Thanks for you patience with the review and approval process. Peace - Anthony

Hello David, it is fixed, regards Andreas

Will it be updated to 3.1 of moodle ?

it should work with moodle 3.1, regards andreas