Mike - Many thanks for sharing this plugin with the Moodle community. In order to review the plugin I need to know for which version(s) of Moodle it is intended to work. Kindly edit the version and you will notice the different Moodle versions listed under Supported software.

It looks like this plugin may require a third-party subscription based service. Since I may not be unable to test the functionality of the plugin without a temporary account we may want to consider setting up a time for a quick demo so that I can see the plugin in action.

Some formal issues were detected and reported by our automated plugin checker tool (source, tracker, and documentation URLs). Please review all the plugin checker results and fix the issues mentioned, if possible. These changes are typically pretty easy to make but if you have any questions just let us know.

Please resolve these formal issues so that the plugin code can be fully reviewed. For now, I am going to mark the plugin as needing more work. Peace - Anthony

Mike,

Could you kindly resolve:

Code validation errors - Important In your version.php you have specified $plugin->requires = 2010112400, which is earlier than the official release of Moodle 2.6 (2013101800)

If you want this plugin in be used on earlier versions of Moodle then we should tag it as such. If it is for 2.6+ then we need to update $plugin->requires. Either way it should be trivial. Also, I sent an email asking if there might be a demo PCBook site that I could use for testing this plugin. Let me know either way, I do not have to do extensive testing but I generally like to review the basic functionality.

Peace - Anthony

p.s. - Thanks for providing the various URLs (source, tracker, docs, etc.)

Mike - I noticed that the recommended boilerplate was not used in the version.php file. The boilerplate is recommended at the beginning of each file and makes explicit the GPL license. You may want to review http://docs.moodle.org/dev/Coding_style#Files to learn more about the boilerplate comments. I also noticed that there was no copyright references. It is preferred that all of the files that you have modified for this plugin have your name added as the copyright holder. I think once we tidy up the version.php file (copyright, boilerplate, and $plugin->requires) that we should be able to get this approved for you.

It is encouraged to follow Moodle's coding style as outlined in: http://docs.moodle.org/dev/Coding_style and http://docs.moodle.org/dev/Coding

The code checker plugin can be quite helpful in fine tuning your code and can be found at: https://moodle.org/plugins/view.php?plugin=local_codechecker

You may wish to consider using that tool to further polish your plugin. Below are the initial results:

Files found: 6

blocks/pcbook/README.txt - 1 error(s) and 0 warning(s)
blocks/pcbook/block_pcbook.php - 173 error(s) and 0 warning(s)
blocks/pcbook/db/access.php - 34 error(s) and 0 warning(s)
blocks/pcbook/edit_form.php - 38 error(s) and 0 warning(s)
blocks/pcbook/lang/en/block_pcbook.php - 17 error(s) and 0 warning(s)
blocks/pcbook/version.php - 1 error(s) and 0 warning(s)

Total: 264 error(s) and 0 warning(s)

Mike - I am going to mark this as needing more work until you have a chance to make the requested changes to the version.php file. Once those are done then I think we are ready to approve. Peace - Anthony

Mike - Thanks for tidying up the version.php file. Everything looks good so I am going to go ahead and approve. Peace - Anthony

Please, update moodle for moodle 2.8 and 2.9