Moodle plugins directory: Stamp collection

Hi David,

There's a serious problem with the Manage Stamps page in IE 8. Your code is breaking the layout of the page, especially in the header area, but also effecting the sidebars. I've tested with multiple themes (all unedited, straight-out-of-the-box) and all have an issue here.

I've been doing some testing to try and fix it and it appears to be a HTML issue, rather than a CSS issue. Maybe there's an un-closed element somewhere?

The issue doesn't appear in Firefox, Chrome and Safari.

I can send you screenshots if that helps.

We have many schools who really like your module, but they're also stuck using IE 8 (I know, I know, a hateful browser, but it's beyond my control to get rid of it). If the layout issue can't be fixed they won't be able to use your module.

Hope you can fix this.

Kind regards,

Barry

Hi Barry, first time I've heard of this. Hope David replies. I've forwarded to him your request.

Hi Barry. Yes please, can you provide me with as many details as possible. Thanks in advance.

(Frankie, no need to forward, I am subscribed to these comments, too. Thanks anyway)

Hi Guys,

Thanks for the fast response. I did some more digging and realised the issue isn't with David's original plugin – I installed a copy of that and it displays the 'Manage Stamps' page fine in IE 8. The problem is in Frankie's modified multi-stamp version which I got from

http://www.moodlenews.com/2012/motivating-students-through-badges-with-the-stamp-collection-module-moodle-2-2-x/

I'll email you both with as much information as I can gather.

Kind regards,

Barry

Actually guys, no need to email. I've found the problem in Frankie's code. It's the first few lines of managestamps.php, in particular this code:

[style type="text/css"]
.expandedNode div{
display: block;
margin-left:3px;
}
.collapsedNode div{
display:none;
}
[/style]

Because this is outside the php and before the HTML element gets rendered it just gets dumped into the output before the HTML element, and this causes IE to freak out. Remove it and the page displays correctly.

I guess you have three options:

1) Use php to add it to the output in the correct position in the header
2) Move it to styles.css
3) Ditch it, and just display the stamp guide all the time

I'm going to go with number 3.

I spent hours yesterday trying to figure this out, this morning solved in an hour. It's amazing what a good night's sleep can do for you.

Kind regards,

Barry

NB Had to replace < and > with [ and ] to get the CSS code to display

Hi, I think this module is great and am just about to try out Frankie's version, as I like the look of the extra functionality. One question: are there any plans to import Frankie's functionality into the the original, so it can be downloaded/installed/supported against future Moodle versions like the original plugin?

Cheers

Hi, Unfortunately, it looks like Frankie's version does not work with Moodle 3.0.x . Is there any chance this will change?

Cheers

OK thanks David, no problem. It would be great if this can work with latest Moodle

OK no problem. I'm currently using your original stampcoll David with no problems on 3.0. Hopefully Frankie is listening to this forum, to see if his version can be made to support 3.0 .

Is the Stamp manually awarded to the student? Can it be issued automatically according to some conditions?

is it currently possible to add a search box to the stamps collection activity? We have many students enrolled in each course and it is hard for teachers to find the student they're looking for.