Comments

• 

  Aparup Banerjee

  Tue, 29 Jan 2013, 12:32 PM

  Hi,
  This looks good to me
  We just need to tidy up one bit picked up by the validator:
  "In your version.php you have specified $plugin->requires = 2011081700, which corresponds to Moodle 2.1 and will not install on Moodle 2.0 that you chose in the form". Either you need to bump up the 'requires' or you wish to support 2.0, please set it and resend for approval.
  
  Also, consider adding your code repository, issues tracker and perhaps any document or page that talks about the theme.
• 

  Aparup Banerjee

  Tue, 29 Jan 2013, 12:33 PM

  Ah, i'll keep this in the approval list (just to keep it in sight).
• 

  Aparup Banerjee

  Fri, 1 Feb 2013, 2:36 PM

  Please feel free to add the github url and others (docs, issue tracker etc) to 'Useful links' section via
  https://moodle.org/plugins/edit.php?plugin=theme_simple
  
• 

  Web ICT ZHAW

  Fri, 1 Feb 2013, 9:10 PM

  Thanks Aparup for Moodle Hat award
  
  As you suggested, I have just added here the link to the code repository in Github
• 

  Gareth J Barnard

  Fri, 15 Feb 2013, 11:10 PM

  Hi,
  
  Just installed and tried out on Moodle 2.3 and I love it . Really nice and crisp theme. The layout idea for 'MyHome' is excellent - would be great for core.
  
  Cheers,
  
  Gareth
• 

  Gareth J Barnard

  Fri, 15 Feb 2013, 11:19 PM

  P.S. It would be great to be able to change the background colour in the theme settings without having to change simple.css directly. This is really easy to do and should only take 30 mins - please see http://docs.moodle.org/dev/Themes_2.0_adding_a_settings_page#Using_the_settings_in_CSS on how to do this.
  
  Cheers,
  
  Gareth
• 

  Web ICT ZHAW

  Sat, 16 Feb 2013, 12:48 AM

  Thanks for your nice comments and this good idea Gareth!
  
  We are using this theme in many different colors for our different departments.
  Therefore we are making small themes which extend the simple theme. This is very easy to maintain. Then the theme includes more or less just a diffrent logo and one color. So if we update the simple theme all other themes are up to dat is well.
  I just upload one of the department color them. Maybe it could be useful for sombody:
  http://moodle.zhaw.ch/pluginfile.php/533060/mod_label/intro/simple_orange.zip
• 

  Gareth J Barnard

  Sun, 17 Feb 2013, 12:58 AM

  No worries
  
  I've just spotted a bug as I operate lots of Moodle's. This happens when moodle is in a sub-folder on the URL. So in 'fontsize_footer.js' the image 'slider' does not load because it cannot be found. i.e. you have:
  
  thumbUrl : '/theme/image.php?theme=simple&image=slider&component=theme'
  
  And my moodle install is 'http://x.x.x.x/moodle23/' - so you need to get the value of $CFG->wwwroot into the javascript as a prefix on the thumbUrl.
  
  Cheers,
  
  Gareth
• 

  Gareth J Barnard

  Sun, 17 Feb 2013, 3:18 AM

  By a strange quirk of fate, I've found that the javascript 'document.referrer' contains the same value as '$CFG->wwwroot' but with a trailing '/'.
• 

  Gareth J Barnard

  Sun, 17 Feb 2013, 8:11 AM

  Scrub last comment - wild goose chase!
• 

  Web ICT ZHAW

  Tue, 19 Feb 2013, 5:19 PM

  Good point Gareth
  
  I didn't found out good way doing that.
  The easiest way is adding the path to the sub-folder manually:
  
  example: http://x.x.x.x/moodle23/
  
  old: thumbUrl : '/theme/image.php?theme=simple&image=slider&component=theme'
  new: thumbUrl : '/moodle23/theme/image.php?theme=simple&image=slider&component=theme'
  
  in: simple/javascript/fontsize_footer.js
• 

  Gareth J Barnard

  Wed, 20 Feb 2013, 1:43 AM

  Hi,
  
  Can be done dynamically in code by adding:
  
  meta name="wwwroot" wwwroot="?php p($CFG->wwwroot); ? (code altered to post!)
  
  as the first element in the HEAD of the layouts, then you can:
  
  var wwwroot = document.head.firstElementChild.attributes[0].nodeValue;
  
  In JavaScript. As it's in the head and only invoked in a script that is loaded by the head then is safe even if the document's status is 'loading'.
  
  Cheers,
  
  Gareth
• 

  Philip Siwinski

  Wed, 27 Feb 2013, 7:07 PM

  Hi, it looks like we have javascript fans
  
  thumbUrl : M.cfg.wwwroot + '/theme/image.php...'
  
  Hope it's integrated soon in next release.
• 

  Web ICT ZHAW

  Fri, 1 Mar 2013, 11:33 PM

  Great Philippe!!!
  I just added a new release
• 

  Philip Siwinski

  Mon, 18 Mar 2013, 6:34 AM

  Thanks for the release.
  Should we use GitHub for reporting issues ?
  
  I'm not able to add block to the front page... It looks like some javascript is broken somewhere.
  
  Could you have a look at it ?