Comments

• 

  Plugins bot

  Wed, 27 Apr 2016, 6:52 PM

  Prechecker results: 0 errors/0 warnings
  http://integration.moodle.org/job/Precheck%20remote%20branch/23141/artifact/work/smurf.html
• 

  Mike Churchward

  Sat, 14 May 2016, 4:18 AM

  Hi Vadim. I am reviewing your plugin submission on behalf of the Plugins Guardians. This looks to be very well-written.
  I'll be honest, I didn't even know there was such a plugin as a "quiz access rule" until you submitted this.
  
  When I first installed it, it went to the new settings page (like all plugins do). It showed me a page with "New settings - IP address list quiz access rule" and a Save button, but there were no settings to make. Clicking the "Save changes" button just kept redisplaying the page. I was able to break out by going back to the site main URL.
  I was able to edit the settings from the main quiz activity settings.
  
  One other small problem. If I select a location set for a quiz, there doesn't seem to be a way to "unselect" it except by selecting another set. How do I choose to make the quiz available to anyone once I have selected location initially?
  
  
• 

  David Mudrák

  Sat, 14 May 2016, 4:37 AM

  I already experienced this "stuck on the new settings page" thing in other plugin (could not find it now). If I recall correctly, it might be caused by the configmultiselect $choices being empty array, or something like that.

• 

  Vadim Dvorovenko

  Sat, 14 May 2016, 1:43 PM

  As for "stuck on the new settings page", i think the problem is with empty configmultiselect. I think the best choice is not to show this settings on upgrade at all, but i currently have no ide how to make it. The subnets list does not shows on update at all, but i do not know why. I'll try look at it soon.
• 

  Vadim Dvorovenko

  Sat, 14 May 2016, 2:08 PM

  As for selecting none in multi select list. I agree that it is the usablility problem. Despite the fact that it is very easy to read the description and press Ctrl, my collegues were not able to perform such a simple action. So, i think, this will be problem for much more users.
  That's common moodle problem with multiselect - it's shown such way on PC. You should use Ctrl to unselect item, as written in caption. On some touchscreen browser this list is shown as list with checkboxes, that's much easier to use.
  Currently we have admin_setting_configmulticheckbox, but we do not have same element for mform. On the other hand I see, that if i use list of checkboxes, they will use a lot of screen size, if there are many items in list. Current list is limited in height.
  I do not want to code "allow from everywhere" predefined element in this list, as it may lead to contradiction, when you select such item and something else.
  Currently site administrator may add such item manually, by adding ip 0.0.0.0/0 to list
• 

  Vadim Dvorovenko

  Sat, 14 May 2016, 2:47 PM

  After a short thinking i have decided that this plugin whatever is not intended to be used with large subnets list, beacuse it wil be hard for admin to manage list larger then 10-20 elements (to much up/down) to order it. So i'm currently working on switching from multilist to checkboxes.
• 

  David Mudrák

  Sat, 14 May 2016, 3:08 PM

  Yeah, I was solving very same usability issues with the component selector field at the AMOS translator filter page (https://lang.moodle.org/local/amos/view.php). At the end I concluded that the list of checkboxes works best for multi-selection purpose and the issue with the space occupied by a long list can be solved via CSS by setting maximum height of the wrapping div.