Carl - Many thanks for another fine organic chemistry question type. I forget whether I asked you about creating a set for these Marvin related question types but we can create a set to group them together so that folks know that they enhance one another (even if there is no dependency upon one another). If you would like to create a set, just let me know the title and a brief description and we will make it happen.

I noticed that some of the copyrights reference a previous author. It is preferred that all of the files that you have modified for this plugin have your name listed (or added) as the copyright holder. You can patch those and the next time you have a new version you can incorporate those changes (in other words, no rush to fix it).

I was successfully able to install the plugin and it appears to function as expected. As such, I am going to approve it.

Code check results showed:


Files found: 16
question/type/easyoname/lib.php - 1 error(s) and 0 warning(s)
question/type/easyoname/renderer.php - 3 error(s) and 0 warning(s)
question/type/easyoname/edit_easyoname_form.php - 3 error(s) and 0 warning(s)
question/type/easyoname/easyoname_script.js - 39 error(s) and 0 warning(s)
question/type/easyoname/question.php - 1 error(s) and 0 warning(s)
question/type/easyoname/easyoname_styles.css
question/type/easyoname/lang/en/qtype_easyoname.php - 1 error(s) and 0 warning(s)
question/type/easyoname/backup/moodle2/restore_qtype_easyoname_plugin.class.php - 1 error(s) and 0 warning(s)
question/type/easyoname/backup/moodle2/backup_qtype_easyoname_plugin.class.php - 1 error(s) and 0 warning(s)
question/type/easyoname/db/upgrade.php - 1 error(s) and 0 warning(s)
question/type/easyoname/db/upgradelib.php - 1 error(s) and 0 warning(s)
question/type/easyoname/version.php - 1 error(s) and 0 warning(s)
question/type/easyoname/module.js - 1370 error(s) and 0 warning(s)
question/type/easyoname/settings.php - 1 error(s) and 0 warning(s)
question/type/easyoname/questiontype.php - 1 error(s) and 0 warning(s)
question/type/easyoname/README.txt
Total: 1425 error(s) and 0 warning(s)

It appeared most of the errors in question/type/easyoname/module.js were space related and may not be applicable since it is a js file.

Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony

Carl - When I attempted to approve this, I received an AMOS parsing error. Looking closely at the lang file, I noticed you had some string names with a capital H which apparently set off its own type of H-bomb ;) In any case, if you could rename those strings to all lowercase in the lang file and then in the code where they are used then we should be able to get this approved. Peace -Anthony

Anthony - I fixed the language strings and the copyright references. I also cleaned the code and ran code checker. Only problem is the minified plugindetect in module.js.

Can we include all of my question types and filters into one set called "EasyOChem Organic Chemistry Set"?

Thanks for all your help. - Carl

Thanks for tidying things up. I think we are ready to approve this plugin. I have created the set https://moodle.org/plugins/browse.php?list=set&id=59. Feel free to let me know if you have better ideas for the name or description. I figured EasyOChem was pretty straightforward for a name. If you need anything else just let me know. Peace - Anthony

Hi, Is there any plans to update this plugin to version 3.8 / 3.9 / 4.0?