Moodle plugins directory: CopyCheck Plagiarism Plugin

Prechecker results: http://integration.moodle.org/job/Precheck%20remote%20branch/9758/artifact/work/smurf.html

Hi, thanks for sharing this plugin with the Moodle community. Please see our policy on plugins relying on a subscription based external services at https://docs.moodle.org/dev/Plugin_contribution_checklist#Meta-data. Can you provide us with a temporary license so we can check the functionality of your plugin? Thanks in advance.

Waiting for the CopyCheck demo account as agreed with Gerie via e-mail.

Gerie - Could you kindly review https://docs.moodle.org/dev/Plugin_contribution_checklist#Meta-data and then update the entry with the appropriate meta-data (namely source control URL. This allows others to participate in providing patches, etc. You may also want to consider adding a screenshot of your plugin to help folks get an idea of what it looks like when installed. Peace - Anthony

I also noticed that there was an extra readme file (txt and md). Also, only the English language pack should be provided here and then once approved we can import the nl language file into AMOS. For now, I'm going to mark this plugin as needing more work until we get these issues tidied up. Thanks for your patience with the review and approval process. Peace - Anthony

Hi Gerie, Great to see another Plagiarism plugin for Moodle!

a brief look at the code suggest that this plugin only supports the Moodle Assignment plugin - can you please make this clear in both the readme and the description of this plugin? - In the readme you have the text "The plugin works for the assignment module, with file submissions and online text." but it would be good to be more explicit stating that it does not support other activities at this stage.

There are also a few places where you include variables directly in the sql instead of using correct Parameter placeholders as per the guidelines here:
https://docs.moodle.org/dev/SQL_coding_style

here are some examples in your code that should be adjusted:
https://github.com/onno-schuit/copycheck/blob/master/moodle-plagiarism_copycheck/lib.php#L61
https://github.com/onno-schuit/copycheck/blob/master/moodle-plagiarism_copycheck/lib.php#L65
https://github.com/onno-schuit/copycheck/blob/master/moodle-plagiarism_copycheck/lib.php#L71
https://github.com/onno-schuit/copycheck/blob/master/moodle-plagiarism_copycheck/report.php#L60

it would also probably be a nice idea (although not required) to shift the copycheck_submissions.php file into a "classes" directory in the plugin as mentioned here:
https://docs.moodle.org/dev/Automatic_class_loading
you may need to rename the class to have the prefix "plagiarism_copycheck_"

Thanks!

Thanks Gerie for sharing this plugin, and thanks Dan for the peer-review. I am going to mark this as needing more work to get the security related issue with SQL parameters - and ideally the others, too - sorted out. Thanks for your patience with the review and approval process.

Hi Gerie, thanks for fixing up those Sql query issues - can you please update the description here in the plugins db to state which activity types are supported?

Thanks for making those changes, I've had another quick look at your code and noticed a couple more things which I have reported to your github issues area, It would be really good if you fixed #1 and #2 as they should be quite easy. As your plugin is a commercial plugin I have not fully tested the functionality of the plugin but once those last 2 changes are made I think your code will be good enough to approve in the plugins database. Once you have made those 2 changes can you please upload an updated version of the code directly to this plugins db entry?

Updated plugin has been added

Hi Gerie, I could be missing something, but the only version I can see uploaded to this plugins entry under the "download versions" tab is the first version you uploaded when creating this entry on Tuesday, 13 January 2015. I can see the new code in your git repository but you don't appear to have updated the zip package available here.

Correct. Gerie, please note we do not automatically pull from your repository. Plugin maintainers are supposed to explicitly release new versions here in the Plugins directory.

Sorry, I must have missed the last button but now there are two versions available.

Hello, I've added CopyCheck to the Versions 2.9 and 3.0. Do you need to evaluate them first before the new versions are listed?