Moodle Code Checker

Changes in version 3.0.4 (20211204) - Downgrading expectations

• PR#162: Downgrade some recently code added to the "moodle" standard to make it PHP 7.0 compliant, needed to continue supporting old branches by various tools (stronk7).

Changes in version 3.0.3 (20211130) - Cyber releasing

• Various internal changes and improvements:
  • Own conformance with new PHPUnit naming rules.
  • New MoodleUtil class to be able to detect Moodle dir root, branch and components (calculated or imported) within code checker. This new awareness will help improving various sniffs.
  • Drop some Moodle own < 3.7 testing. Code checker continues supporting Moodle 3.4 and up.
  • Improvements to the base test case, now able to automatically verify phpcbf fixes.
  • Bye, bye to Travis for self-tests. Now relying only on GHA.
• PR#155: Make some common errors to be fixable by phpcbf (cameron1729).
• PR#158: Fixes for the MOODLE_INTERNAL sniff to better detect some allowed exceptions (stronk7).
• PR#161: New sniff to follow PHPUnit files, classes and namespaces naming rules (stronk7).

Information

This Moodle plugin uses the PHP CodeSniffer tool to check that code follows the Moodle coding style. It implements and reuses a set of 'sniffs' that check many aspects of the code, including the awesome PHPCompatibility ones.

It was created by developers at the Open University, including Sam Marshall, Tim Hunt and Jenny Gray. It is now maintained by Moodle HQ.

Available releases can be downloaded and installed from https://moodle.org/plugins/view.php?plugin=local_codechecker.

To install it using git, type this command in the root of your Moodle install:

git clone git://github.com/moodlehq/moodle-local_codechecker.git local/codechecker

Then add /local/codechecker to your git ignore.

Additionally, remember to only use the version of PHPCS located in phpcs/bin/phpcs rather than installing PHPCS directly. Add the location of the PHPCS executable to your system path, tell PHPCS about the Moodle coding standard with phpcs --config-set installed_paths /path/to/moodle-local_codechecker and set the default coding standard to Moodle with phpcs --config-set default_standard moodle. You can now test a file (or folder) with: phpcs /path/to/file.php.

Alternatively, download the zip from https://github.com/moodlehq/moodle-local_codechecker/zipball/master, unzip it into the local folder, and then rename the new folder to "codechecker".

After you have installed this local plugin, you should see a new option in the settings block:

Site administration -> Development -> Code checker

We hope you find this tool useful. Please feel free to enhance it. Report any idea or bug in the Tracker, thanks!

IDE Integration

Eclipse:

1. Outdated!: If if you use Eclipse for development, you might want to install the PHP CodeSniffer plugin (http://www.phpsrc.org/).
2. Create a new "CodeSniffer standard" in the preferences page.
3. Point it at the moodle directory inside the codechecker folder.
4. Thank Michael Aherne from University of Strathclyde who worked this out!

PhpStorm

1. Install the phpcs cli tool
2. Open PhpStorm preferences
3. Go to PHP > CodeSniffer and supply the path to the phpcs executable
4. Go to Inspections > PHP > PHP Code Sniffer Validation
5. In the 'coding standard' dropdown select 'custom' and press the [...] button next to the path to the coding standard. Point is at the moodle directory inside the this plugin directory.

Sublime Text

Find documentation here.

1. Install PHP CS following steps described in this moodle docs page.
2. Go in your Sublime Text to Preferences -> Package Control -> Package Control: Install Package
3. Write 'phpcs' in the search field, if you see Phpcs and SublimeLinter-phpcs, click on them to install them.
4. If not, check if they are already installed Preferences -> Package Control -> Package Control: Remove Package.

5. To set your codecheck to moodle standards go to Preferences -> Package Settings -> PHP Code Sniffer -> Settings-User and write:

   { "phpcs_additional_args": {
           "--standard": "moodle",
           "-n": "
       },
   }
   

6. If you don’t have the auto-save plugin turned on, YOU’RE DONE!

7. If you have the auto-save plugin turned on, because the codecheck gets triggered on save, the quick panel will keep popping making it impossible to type. To stop quick panel from showing go to Settings-User file and add:

   "phpcs_show_quick_panel": false,
   

   The line with the error will still get marked and if you’ll click on it you’ll see the error text in the status bar.

VSCode

Find documentation here.

1. Install PHP CS following steps described in this moodle docs page.
2. Install PHPSniffer.

3. Open VSCode settings.json and add the following setting to define standard PHP CS (if you haven't set it as default in your system):

   "phpSniffer.standard": "moodle",