Comments

• 

  Anthony Borrow

  Thu, 20 Dec 2012, 3:11 PM

  I need to come back to this. I have some concerns with the following in the README.txt file:
  
  If using a Unix based system, chmod 755 on config.php - I have not tested this but have been told that it
  needs to be done.
  6. In 'cnconfig.php' change the value of $CNCFG->defaultcolumns' for setting the default layout, structure and columns respectively for
  new / updating courses as desired by following the instructions contained within.
  
  I'm not sure why config.php permissions need to be modified. I don't recommend 755. I could understand 750 but I am hesitant about what it is that is causing you to recommend that. I also think that if there is something to be configured that it should be able to be done through the UI and not require hard coding that change in the file.
  
  Also, you create a separate global variable $CNCFG rather than using config_plugins table with get_config and set_config. I'd like to get Aparup's opinion on these before approving it. Peace - Anthony
• 

  Gareth J Barnard

  Thu, 20 Dec 2012, 10:39 PM

  Dear Anthony,
  
  The permissions thing was something I was told years ago. I'm happy to remove it.
  
  With the $CNCFG global variable, I'm happy to change that to in favour of get_config and set_config as I was unaware of that functionality in Moodle having assumed the way that $CFG worked was the way to do things. But if I do change, how do I provide an easy way for the user to set the value they want? Should I have defaults in the cnconfig.php file and check them against the table each time against the values in the database or provide a separate script with functions? I'd not be so keen on a separated form within the format, especially with 2.4 as I've worked hard to reuse Marina Glancy's course format code.
  
  Happy Holidays,
  
  Gareth