Comments

• 

  Plugins bot

  Fri, 20 Mar 2015, 6:14 PM

  Prechecker results: 13 errors / 13 warnings
  http://integration.moodle.org/job/Precheck%20remote%20branch/11887/artifact/work/smurf.html
• 

  Jetha Chan

  Wed, 8 Apr 2015, 5:11 PM

  I've fixed the prechecker issues and bumped the version number accordingly - ready for review.
• 

  Anthony Borrow

  Mon, 13 Apr 2015, 1:18 PM

  Jetha - It sounds like this is dependent on atto plugin so you may want to declare that dependency in the version.php file. Peace - Anthony
• 

  Anthony Borrow

  Mon, 13 Apr 2015, 1:24 PM

  Thanks for patching up the prechecker issues. I noticed that the styles.css is blank so I suspect that file is not needed. I think after patching up those two issues that it should be good to go; however, we will want to wait until we get the atto plugin approved first so that they can both be installed. Peace - Anthony
• 

  David Mudrák

  Thu, 16 Apr 2015, 4:47 AM

  Hi Jetha. Thanks for sharing this filter with the community. As I reported in the bug #1 in your tracker, the filter seems to have some regex issues yet. Also I agree with Anthony that the empty styles.css should be removed and dependency on the atto plugin should be declared - see https://docs.moodle.org/dev/version.php Even if the filter does not depend on the atto plugin technically (i.e. it does not use any of its code), it relies on explicit HTML made by that plugin. So from the user's perspective, this filter is usable together with the atto plugin only, which seems to be a good reason for declaring the dependency.
  I am going to mark this filter as needing more work, and will remove any mention of it from the atto plugin's page here. Once a new version with fixes is uploaded and approved, please feel free to link both plugin again.
  Thanks for your patience with the review and approval process.
• 

  Jetha Chan

  Thu, 16 July 2015, 5:53 PM

  Anthony, David - thanks for the reviews, and I'm sorry it took so long to get back to you. I've addressed the issues on the issue tracker, removed the empty styles.css, and explicitly declared the dependency on the atto plugin.
• 

  David Mudrák

  Sat, 18 July 2015, 12:54 PM

  Thanks for the fixes Jetha. The only thing I realised in both of your Sketchfab plugins is that you declare dependency on Moodle 2.7.7. Is there a specific reason why Moodle 2.7.0 is not supported? The thing is, if your plugin version declares support for Moodle 2.7 here in the Plugins directory, it will be available for people using any Moodle 2.7.x version. If there is a specific requirement in your plugins for particular 2.7.7 version (it should not be though), you would have declare supported versions as 2.8 and 2.9 only.

  I believe this can be easily fixed by using $plugin->requires = 2014051200; in your version.php of both plugins. You will want to release new version of your plugin with this fix, too.

  With the hope this will be corrected soon, I am going to approve this plugin now. You are cleared to land, welcome to the plugins directory!

• 

  Adilah Bisar

  Thu, 11 Jan 2018, 7:45 PM

  Please tell me the procedure that how to install this filter? https://www.perfectcv.ae/ and what are the advantages of this filter?
• 

  Adilah Bisar

  Thu, 11 Jan 2018, 7:45 PM

  Please tell me the procedure that how to install this filter? https://www.perfectcv.ae/ and what are the advantages of this filter?
• 

  Arif Hussain

  Fri, 8 Mar 2019, 4:18 PM

  It look like this is reliant on atto module so you might need to proclaim that reliance in the version.php document. https://www.writing4u.ae/
• 

  Cali Luna

  Mon, 16 Aug 2021, 8:03 PM
• 

  Liam Ford

  Wed, 31 Jan 2024, 6:34 PM

  Is anyone here who can tell procedure that how to install this filter? Also here to tell you guys that now students can easily get their Online Exams done with Real Assignments. Visit: https://realassignments.co.uk/online-exam-help