Comments

• 

  Jonas Rüegge

  Tue, 23 July 2013, 2:35 PM

  The "#" Special Chars exceptions is also solved in the new version (1.1.2)
  I didn't test it with anything below 2.4 though, so please report Problems with anything older than 2.4, should they occur.
• 

  Toshimi Hatanaka

  Sat, 12 Oct 2013, 4:46 PM

  The double-byte bookmark titles (ex. Japanese) are garbled in the version (1.1.2) I'm testing this block on Moodle 2.5.2.
• 

  Jonas Rüegge

  Tue, 15 Oct 2013, 5:21 PM

  Version 1.1.3 Should fix the Problem with garbled Titles in Bookmarks, aswell as a couple of other bugs
• 

  Germán Valero

  Tue, 15 Oct 2013, 9:29 PM

  Hi,
  I was translating the user bookmarks block in AMOS (http://lang.moodle.org/) and I found what I think are a couple of minor typos:
  
  2.5 [user_bookmarks:editbookmarktitle,block_user_bookmarks] "edit bookmark titel" , which I think should be "edit bookmark title"
  2.5 [user_bookmarks:enterbookmarktitle,block_user_bookmarks] "enter bookmark titel" , which I think should be "enter bookmark title"
  
  And maybe 2.5 [user_bookmarks:myaddinstance,block_user_bookmarks] "Add a new Block for Custom Bookmarks to my startsite" would be more in line with other plugins wording as "Add a new Block for Custom Bookmarks to MyMoodle" .
  
  Otherwise, it seems to be a very nice block.
  
  Thanks in advance for your help.
• 

  Jonas Rüegge

  Tue, 15 Oct 2013, 10:41 PM

  @ German Valero:
  Fits better. (titel instead of title was 50%typo 50%subconscious)
  I'll change it in the next update
• 

  Germán Valero

  Wed, 16 Oct 2013, 9:28 PM

  Thanks Jonas,
  I think that the only way to change the English language strings of a plugin is submitting a new version of the plugin.
  Thanks a lot.
• 

  Germán Valero

  Wed, 16 Oct 2013, 10:06 PM

  Hi Jonas,
  Could you please add a link to 'Moodle Docs for this plugin' in the 'Useful Links' section (not yet created) description for this plugin in this Moodle plugins database (up here) and point it to http://docs.moodle.org/25/en/User_bookmarks_block ?
  
  And could you please create your user page for Moodle Docs at http://docs.moodle.org/25/en/index.php?title=User:Jonas_R%C3%BCegge&action=edit&redlink=1 ?
  
  Please look at https://moodle.org/plugins/view.php?plugin=block_navbuttons as an example of a very comprehensive plugin description in Moodle plugins database.
  
  Thanks in advance.
• 

  Alexander Bias

  Wed, 5 Feb 2014, 8:14 PM

  Hi,
  
  I am keen on using your plugin in our Moodle installation. However, there are some things which I stumbled upon and which prevent me from running it in a productive environment:
  
  - File db/access.php does not have a <?php tag at the beginning. So, the capabilities in this file are not installed, instead the file is output in plain text when installing the plugin.
  
  - File block_user_bookmarks.php: get_context_instance(CONTEXT_SYSTEM) is deprecated, please use context_system::instance() like it is done in the admin_bookmarks plugin.
  
  - There's a mixture of space-indentation and tab-indentation which looks quite hacky when you look at the code. Moodle core uses spaces for indentation by default.
  
  - The JavaScript for editing or deleting bookmark links is hardcoded into HTML instead of using a separate JS file
  
  - Changing the title of a bookmark requires JavaScript, there is no fallback for non-JS-users. Without JavaScript, the user sees a button with no function.
  
  - Version 1.1.2 is listed as current version in the plugins repository instead of Version 1.1.3. I think you messed something up with the version numbers in version.php. Perhaps you could hide version 1.1.2 in the plugin repository to solve this.
  
  - There is no Github repository for this plugin like nearly all other Moodle plugins have (would be convenient for admins who manage their installation with GIT).
  
  - The typos in the english language pack which German reported in October are still there...
  
  - The german language is shipped with the plugin instead of managing it in AMOS (http://lang.moodle.org/).
  
  
  I would be very grateful if you could have a look at these things and polish your very useful plugin.
  
  Furthermore I think it might be very important that you track the changes on the core admin bookmarks plugin when new Moodle major versions are released and adopt important changes like the get_context_instance() thing I mentioned above to your plugin.
  
  Thanks in advance,
  Alex
• 

  Jonas Rüegge

  Wed, 5 Feb 2014, 9:12 PM

  
  It's already on Github:
  https://github.com/BBZ-ICT/moodle-user_bookmarks
  
  Feel free to start a new 2.X Fork for whatever Version you want to adapt.
• 

  alfren enriquez

  Fri, 7 Feb 2014, 11:03 AM

  Greetings!
  
  Is it possible to put the Bookmarks block in the user's homepage? I tried everything and I can't find the way on how to do this.
  
  Many Thanks!
• 

  Jonas Rüegge

  Thu, 13 Feb 2014, 3:26 PM

  @alfren: please check your personal messages.
  
  About comment from Alexander Bias
  Mi, 5. Feb 2014, 13:14:
  https://github.com/BBZ-ICT/moodle-user_bookmarks/issues?state=open
• 

  Randall Kujawa

  Thu, 13 Feb 2014, 10:26 PM

  We have been using this plugin for about 6 months and have been very happy with it. Unfortunately yesterday, a manager/instructor tried to add a bookmark and then was effectively locked out of Moodle. On almost every page she tried to access within the site (using ANY link) she got a "bad url" message. I have no idea what she did. She claims she just tried to add a bookmark like she has always done before without any problem. When I logged in as her, I started getting the same problem. When I am logged in as myself the problem goes away. It only seems to effect her account. When I disable User Bookmarks, the problem goes away. After searching the forums for help, I deleted the plugin from within Moodle, then logged into the server and deleted the directory "user_bookmarks". I then reinstalled it thinking I would have a clean install, but found when I logged in my old bookmarks were available to me again. I logged in as her, and still got the "bad url" message on every page I tried to go to.
  
  1. Anyone have any idea what's going on?
  2. Where are the bookmarks stored so I can delete them for a user without having access to the block interface?
  3. What tables does this plugin create? I couldn't find any that seemed to reference bookmarks.
  4. Are any configuration files created outside the \blocks\user_bookmarks folder?
  5. How can I get an absolutely clean install?
  
  We are using Moodle 2.3.8+ (Build: 20130719)
  
  Any help would be greatly appreciated!!!
• 

  Jonas Rüegge

  Thu, 13 Feb 2014, 10:52 PM

  I think I know what happened.
  An old Version of the plugin saves URL's and Data in a way where certain special Signs can cause critical Problems .
  The Next Major Version of the Plugin will fix this issue permanently.
  
  Which Version are you currently using?
  Did you change Version in between?
• 

  Jonas Rüegge

  Thu, 13 Feb 2014, 11:06 PM

  To solve your User Problem you need to access the DB manually, the table user_preferences to be specific
  
  Check the Table of the User with following query:
  "
  SELECT *
  FROM `user_preferences`
  WHERE `name` LIKE 'user_bookmarks'
  AND userid = XY
  "
  where XY stands for the Users ID (in table users) as an int
  
  Now save the Content of "value" in a Text editor and empty "value" in the database.
  
  The String in your Editor should look like:
  
  /My/Moodle/URL|Name for my Link | /My/Moodle/URL2|Name for my Second Link ....
  
  Or with the old and buggy Version:
  /My/Moodle/URL;Name for my Link ; /My/Moodle/URL2;Name for my Second Link ....
  
  Find the part of the string that doesn't follow that rule, correct it and put it back in the Database
• 

  Jonas Rüegge

  Thu, 13 Feb 2014, 11:10 PM

  Hint: It's probably the last part.
  
  Now if your String looks mixed up (; and | as separator) change them all to |.