Comments

• 

  Plugins bot

  Wed, 26 Oct 2016, 2:49 PM

  Prechecker results: 4419 errors/6920 warnings
  https://integration.moodle.org/job/Precheck%20remote%20branch/28738/artifact/work/smurf.html
• 

  Simey Lameze

  Mon, 5 Dec 2016, 12:41 PM

  Hello, thanks for sharing this plugin with the community. I am going to review it for the approval.
• 

  Simey Lameze

  Mon, 5 Dec 2016, 2:30 PM

  Hello guys, I have reviewed your plugin, it looks really cool a works well. I think it might be useful in some institutions...
  
  Here are some comments regarding the code itself:
  1- I would recommend create a lib directory and place chessboardjs library into it.
  
  2- Un-used global, also do not use upper case for php key words (GLOBAL in this case): https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/block_chessblock.php#L54
  
  3- Please, use just 8 spaces for wraping, also this line could be wrapped just in 1 lines, not 2 as it is now:
  https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/block_chessblock.php#L86
  
  4- Have you considered use moodle Jquery library instead of loading through CDN?
  https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/block_chessblock.php#L92
  That won't work for sites that does not have direct access to internet or if it is behind a proxy.
  
  5- Also, the thirdpartylibs.xml seems incorrect, accordingly to https://github.com/oakmac/chessboardjs chessboardjs github their software is under MIT license, not GPL and I believe the correct version is 0.3.0 and not 66.77 as stated on the file. In this case, you can remove tag.
  
  6- The globals $CFG, $OUTPUT, $USER, $DB are un-used all could be removed from this line: https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/block_chessblock.php#L75
  
  7- It is not recommended concatenate extra values to language strings, for example here:
  https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/block_chessblock.php#L89
  You could change the language string to $string['gamestatus'] = 'Status: {$a}'; and just pass the status as the third parameter of get_string call.
  
  8- A bit more of help would be good, for explaining what's the purpose of Download FEN and Download PGN links.
  
  9- Also, I don't see why display User ID:{ID} might be necessary to the end user.
  
  10- Typo found: intenral https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/version.php#L29
  
  11- Typo found: initalizing https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/block_chessblock.php#L20
  
  12- Typo found: upgarde https://github.com/TheGlobalATeam/moodle-block_chessblock/blob/master/db/upgrade.php#L20
  
  13- Several functions are missing ; on main.js.
  
  14- What's the purpose of use rand() on block_chessblock.php?
  
  Some of those points are just recommendations and won't prevent this plugin of being approved.
  
  Thanks for the awesome work!
• 

  David Mudrák

  Mon, 5 Dec 2016, 5:28 PM

  Thanks guys for sharing the block with the community, and thanks Simey for providing a peer-review for it. All the raised issues are good suggestions for further improvements of the block. With the hope they will be addressed in a future version of the block, I am happy to approve this now.

• 

  Fergie Kate

  Thu, 22 Feb 2018, 2:52 AM

  Hello, I have browsed most of your posts. This post is probably where I got the most useful information for my research. Similar games can also be found on friv websites, which add new brain or skill games, that children and adults love much much... I like this plugin and i think is good for my website...
• 

  durmuş burak

  Fri, 7 Feb 2020, 3:49 PM

  Hello, is there version in moodle 3.7?