Many thanks for sharing this plugin with the Moodle community. I noticed that the version (zip file) you provided did not specify for which version of Moodle it is intended to work. Also, I encourage folks to provide the source, tracker and documentation URLs so that those using your code can better collaborate with you on maintaining the code. For now, I am going to mark this as needing more work but once you specify the version for which the code is intended to work I can give it a test run and give you more feedback. Please do not hesitate to let me know if there is anything I can do to be supportive of your efforts. Peace - Anthony

p.s. - I also noticed a couple of validation warnings:

Release name ($plugin->release) not found in version.php
Release notes not found (searched for files README, README.*)

Those should be pretty easy to fix up. I think it would also help to describe the functionality of your plugin and what makes it advanced. I would also recommend that all files contain the licensing information. You may find it helpful to review http://docs.moodle.org/dev/Coding_style#Files and http://docs.moodle.org/dev/version.php.

I noticed in the lang/en/block_advrssfeed.php file you used a closing PHP tag which is not recommended - see http://docs.moodle.org/dev/Coding_style#PHP_tags

For Moodle 2.4 onward, you will want to have a look at http://docs.moodle.org/dev/Blocks#db.2Faccess.php as I did not notice an addinstance capability being defined.

Thanks for your comments. We have fixed the issues. Please check and feedback us.

Hi, moodle has an RSS block. As Anthony has mentioned above, it will help if you " describe the functionality of your plugin and what makes it advanced" so its easy to tell the difference.

Please click 'Schedule this plugin for re-approval' in the Administration block when you've made changes.

Thank you.

I've looked through now. (the Friday, September 27, 2013, 4:42 PM release, i've marked this as supporting moodle 2.5, please change it if that's not correct.)
It seems the features are to allow numerical restrictions to posts, length of titles etc

Please consider looking at :
https://moodle.org/plugins/stats.php?plugin=block_rss_plus
You both might want to join up.

I've installed this block and it install smoothly but there are some issues with it with trying to use it:
- doesn't allow changing settings (from default to tapchilaptrinh.vn)

-- QuickForm Error: nonexistent html element Element 'url' does not exist in HTML_QuickForm::addRule()
Backtrace :Array ( [0] => Array ( [file] => /Users/aparup/mtools/mdkinstances/stable_25/moodle/lib/pear/HTML/QuickForm.php [line] => 1988 [function] => PEAR_Error [class] => PEAR_Error [type] => -> [args] => Array ( [0] => nonexistent html element [1] => -3 [2] => 16 [3] => pear_handle_error [4] => Element 'url' does not exist in HTML_QuickForm::addRule() ) ) [1] => Array ( [file] => /Users/aparup/mtools/mdkinstances/stable_25/moodle/lib/pear/PEAR.php [line] => 531 [function] => HTML_QuickForm_Error [class] => HTML_QuickForm_Error [object] => HTML_QuickForm_Error Object ( [error_message_prefix] => QuickForm Error: [mode] => 16 [level] => 1024 [code] => -3 [message] => nonexistent html element [userinfo] => Element 'url' does not exist in HTML_QuickForm::addRule() [backtrace] => Array *RECURSION* [callback] => pear_handle_error ) [type] => -> [args] => Array ( [0] => -3 [1] => 16 [2] => pear_handle_error [3] => Element 'url' d

- Notice: Undefined variable: content in /Users/aparup/mtools/mdkinstances/stable_25/moodle/blocks/advrssfeed/block_advrssfeed.php on line 120
- Notice: Undefined variable: output in /Users/aparup/mtools/mdkinstances/stable_25/moodle/blocks/advrssfeed/block_advrssfeed.php on line 102

I think we must fix these issues up before approving this.

Thanks. We had fixed the issues.

ok great, can you also add to the urls section (when you edit the plugin):
- A code repository url (eg: github.com)
- An issue tracker url
- A documentation url

The block now functions nicely for me . Now we just need to get some urls up as mentioned.

Note that there is one last warning that i do see which you might want to fix later (with a issue tracker url, we can just report it there instead):

Warning: ./cache is not writeable. Make sure you've set the correct relative or absolute path, and that the location is server-writable. in /Users/aparup/mtools/mdkinstances/stable_25/moodle/lib/simplepie/library/SimplePie.php on line 1369
Call Stack
# Time Memory Function Location
1 0.0010 315064 {main} ../view.php:0
2 0.9329 49881864 core_renderer->header ../view.php:243
3 0.9415 49650192 core_renderer->render_page_layout ../outputrenderers.php:790
4 0.9417 49687568 include( '/Users/aparup/mtools/mdkinstances/stable_25/moodle/theme/clean/layout/columns3.php' ) ../outputrenderers.php:860
5 0.9421 49691088 core_renderer->standard_head_html ../columns3.php:45
6 0.9422 49692944 block_manager->ensure_content_created ../outputrenderers.php:355
7 0.9422 49693272 block_manager->create_block_contents ../blocklib.php:1003
8 1.0682 51220224 block_base->get_content_for_output ../blocklib.php:951
9 1.0682 51222296 block_base->formatted_contents ../moodleblock.class.php:238
10 1.0682 51222408 block_advrssfeed->get_content ../moodleblock.class.php:292
11 1.0683 51223464 block_advrssfeed->read_feed ../block_advrssfeed.php:102
12 1.0775 52805048 SimplePie->init ../block_advrssfeed.php:112
13 2.1500 53508800 trigger_error ../SimplePie.php:1369

No problem if you're not getting the warning, it may be a very edge case.

Thanks for the urls. We have a convention with naming repositories for moodle use with : 'moodle-{component}-{pluginname}' which would in your case be 'moodle-block_advrssfeed'. Do consider following the convention.

I note the direct repository url to the plugin is https://github.com/nvkvn/advrssfeed/tree/master/SourceCode/advrssfeed which may be more useful as the url.

(note that since you're not using github's issue tracker, you may want to mention the issues url in readme again)

Thanks.

Well written, thanks for sharing! 🙂
https://www.psiphon.onl

thnk you