Tim Hunt

https://webaim.org/projects/screenreadersurvey8/. For me, the three most interesting graphs are:

"Which of the following is your primary desktop/laptop screen reader?"

"When trying to find information on a lengthy web page, which of the following are you most likely to do first?"

"When navigating a web page by headings, how useful are the heading levels (e.g., "Heading 1", "Heading 2", etc.) to you?"

For years, it has been possible to add tags to questions in the question bank. Then in Moodle 3.5 (thanks to the MUA) it became possible to use tags to randomly select questions to fo into quizzes.

Then, in Moodle 3.6 we added the ability for questions and categories to have an idnumber (because we wanted it for the Embed questions filter).

However, until now, those things have not been displayed in the question-bank interace, which makes it more difficult than necesasry to organise things.

I dicided to have a go at fixing that, and here is what I have managed so far. Comments welcome

Also, when adding questions to the quiz:

and when editing the list of question categories:

(In case you are wondering, 0 is not a sensible idnumber for a category. However, it is a good way to find bugs like MDL-66796. Also, while working on this I discovered MDL-66801. Three fixes for the price of one, I hope!)

I just tried to work this out. If your plugin has an admin_setting_confightmleditor setting, what is the correct way to output that? Normally when you output something that was user intput, you pass it through format_text(), format_string() or s(), and doing this is an important security thing.

My normal approach to try to answer this question is to look for example in the standard Moodle code. There is no advice in the doc-comment on admin_setting_confightmleditor. There are only a few examples where it is used. However, in this case, looking at the example just left me confused:

• maintenance_message is a special case. The maintenance message can be displayed when Moodle is in mid upgrade, so you can't rely on anything working, so it is just output with no extra processing.
• backup/backup_async_message goes into an email, not displayed on-screen, so that is different.
• auth_instructions - if you decode auth/classes/output/login.php, this eventually gets passed through external_format_text (with hard-coded FORMAT_MOODLE). Since web services are almost certainly not involved, that seems like a dangerous example to copy.
• auth_shibboleth does format_text($config->auth_instructions); but that turns out to be a setting that came from an admin_setting_configtextarea.

Before doing all this research, my guess would have been format_text($CFG->thing, FORMAT_HTML).

If anyone thinks they know the 'right' answer here, please let me know. Thanks.

I am making this post to share what I have learned from other people. I certaninly did not work most of htis out, but I am sharing what I have lerned in the hope that it helps others.

Travis-CI

services:
  mysql

  apt:
    packages:
      - oracle-java8-installer
      - oracle-java8-set-default

  apt:
    packages:
      - openjdk-8-jre-headless

dist: bionic

  # The following line is a temporary work-around for https://tracker.moodle.org/browse/MDL-66378.
  # Once that is fixed, the next line can be deleted.
  - curl https://github.com/timhunt/php-webdriver/commit/7a0aa38f591b7395939df25d8cb6677bf99a481f.patch | git apply --directory moodle/vendor/instaclick/php-webdriver
  - moodle-plugin-ci behat --profile chrome

File is stale and needs to be rebuilt: amd/build/[filename].min.js

To see all this together (including a few other irrelevant changes) here is the commit I made to fix all these issues in one of my plugins: https://github.com/moodleou/moodle-qtype_pmatchjme/commit/4fccd62877bb2df3d5b34c24c78d44a49a53890b

I hope this is useful.

A lot of Moodle's Behat tests repeatedly test navigating around Moodle before getting to the feature they really want to test. For example:

    And I log in as "teacher"
    And I am on "Course 1" course homepage
    And I follow "Quiz 1"
    And I follow "Attempts: 1"
    And I follow "Review attempt"

This is bad for several reasons:

• When the Moodle navigation structure changes, all our Behat tests break. This is why, at one point, the 'I am on "Course 1" course homepage' step had to be introduced to fix one breakage. The breakage that caused the '... in current page administration' to be created is another example.
  
• It makes the test take longer to run, becuase you have to load a whole lot of pages that you are not interested in testing.

    And I am on "mod_quiz" "Quiz 1" "edit"
    And I am on "mod_quiz" "Quiz 1/student/1" "attempt review"