David Scotson
Posts made by David Scotson
I'm sure I filed a bug about this previously, but searching just now doesn't seem to bring it up. I remember it showing up when I was mucking around with a different way to show the menus, but that change got rolled back.
It seems there's a bug in core Moodle and live logs may have not been showing up where they should have been for a couple of years, and that the Afterburner theme (accidentally?) half-fixed it, by making a small change to the renderer for navigation nodes. And that Essential theme (and my earlier experiments with Clean) accidentally fixed the other half by overriding the CSS that made the bug invisible in most themes.
I assume that the root of the issue is the way the live logs "action link" is being added to the navigation tree is wrong, in report/loglive/lib.php but I don't know enough about that area to say exactly what they've done wrong and how to fix it. Possibly something to do with adding the icon to the nav link rather than to the action_link?
It would be interesting to know why that change was made in the afterburner theme's renderer too.
edit: just adding a text string for the menu item fixes it on every theme but Afternburner, but I don't know if that's a bodge or not. It's what all the reports that don't want to open in a new window do, but this appears to be the only one that wants a pop-up.
And this seems related: MDL-25991
It seems there's a bug in core Moodle and live logs may have not been showing up where they should have been for a couple of years, and that the Afterburner theme (accidentally?) half-fixed it, by making a small change to the renderer for navigation nodes. And that Essential theme (and my earlier experiments with Clean) accidentally fixed the other half by overriding the CSS that made the bug invisible in most themes.
I assume that the root of the issue is the way the live logs "action link" is being added to the navigation tree is wrong, in report/loglive/lib.php but I don't know enough about that area to say exactly what they've done wrong and how to fix it. Possibly something to do with adding the icon to the nav link rather than to the action_link?
It would be interesting to know why that change was made in the afterburner theme's renderer too.
edit: just adding a text string for the menu item fixes it on every theme but Afternburner, but I don't know if that's a bodge or not. It's what all the reports that don't want to open in a new window do, but this appears to be the only one that wants a pop-up.
And this seems related: MDL-25991
Just thought I'd draw attention to some nice theming on the new Moodle MOOC:
http://learn.moodle.net
http://learn.moodle.net
I hope you're reporting these glitches Joseph, it's the only way they'll get fixed.
I've posted a comment with what I believe is the fix.
Anyone who's seeing this bug could test the fix by adding a line of CSS to their theme's CSS box.
First you need to find a classname for the large img then set "max-width: none" on it.
I'll install the plugin and check this out myself when I get a moment but if anyone wants to help then that would be appreciated.
Anyone who's seeing this bug could test the fix by adding a line of CSS to their theme's CSS box.
First you need to find a classname for the large img then set "max-width: none" on it.
I'll install the plugin and check this out myself when I get a moment but if anyone wants to help then that would be appreciated.