Choice

this block pasted below doesn't look right:

couple of things - $countanswers = get_records isn't in HEAD - it's the line you replace it with. $countanswers = $DB->get_records.

also - you've removed a few Carriage returns, and added extra spaces on empty lines which makes the patch a bit messy. - the cleaner and tidier the patch, the easier it is for other developers to see where your exact suggested changes are! - thanks for this! - it's great to see patches for frequently requested features! - it doesn't look like you're far off!



Dan


-
- $current = get_record('choice_answers', 'choiceid', $choice->id, 'userid', $userid);
+ global $DB;
+
+ $current = $DB->get_record('choice_answers', array('choiceid' => $choice->id, 'userid' => $userid));
+ $current2 = $DB->get_record('choice_answers', array('choiceid' => $choice->id, 'userid' => $userid,'optionid' => $formanswer));
$context = get_context_instance(CONTEXT_MODULE, $cm->id);
- $countanswers = get_records("choice_answers", "optionid", $formanswer);
+ $countanswers = $DB->get_records("choice_answers", array('optionid'=> $formanswer));
if ($countanswers) {
+
$countans = 0;
foreach ($countanswers as $ca) { //only return enrolled users.
if (has_capability('mod/choice:choose', $context, $ca->userid, false)) {
$countans = $countans+1;
}
}
-

Hi Maiol.
I have probed the patch in a Xamplite windows intallation moodle 2.0.
I use Cygwin to extract the patch.


I had put it previously in Moodle/ but an error appear:
www/moodle
$ patch -p1 -b <new_multiple_choicesDOS.diff
can't find file to patch at input line 10
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|### Eclipse Workspace Patch 1.0
|#P moodle
|Index: mod/choice/index.php
|===================================================================
|RCS file: /cvsroot/moodle/moodle/mod/choice/index.php,v
|retrieving revision 1.42
|diff -u -r1.42 index.php
|--- mod/choice/index.php 23 May 2008 07:03:17 -0000 1.42
|+++ mod/choice/index.php 20 Jun 2008 19:07:08 -0000
--------------------------
File to patch:


When I have put the diff file in moodle/mod the first two files are changed but an error apperar in hunk#3

www/moodle/mod
$ patch -p1 -b <new_multiple_choicesDOS.diff
patching file choice/index.php
patching file choice/lib.php
Hunk #1 succeeded at 175 (offset 4 lines).
Hunk #2 succeeded at 234 (offset 4 lines).
Hunk #3 FAILED at 259.
patch: **** malformed patch at line 164: add_to_log($courseid, "choice", "choose", "view.php?id=$cm->id", $choice->id, $cm->id);

Thanks Dan.
The explanation is very clear... but for windows...and I use Linux in my MoodleServers. I will look for some information in the forums about patch and linux (I hope it would be not so difficult to find it).


I have a moodle 2.0 and a moodle 1.9 test servers and I test the files in both... perhaps the path would be Ok in both environments.