Possible small bug in Quiz Category naming with apostrophe?

Possible small bug in Quiz Category naming with apostrophe?

Paul Robinson írta időpontban
Válaszok szám: 7

Hi

I had a quiz category name with an apostrophe in it. When I tried to add a random question to a quiz from this category I got the "Could not add new question!" message. After trying everything else, I tried removing the apostrophe from the category name and then the question could be added! Anyone else seen this? I'm new to this too - how would this be logged as a bug?

regards

Paul

Értékelések átlaga: -
Válasz erre: Paul Robinson

Re: Possible small bug in Quiz Category naming with apostrophe?

Howard Miller írta időpontban
Kép Kép Kép Kép Kép
Which version of Moodle? I had a quick look and couldn't reproduce it in 1.7.
Válasz erre: Howard Miller

Re: Possible small bug in Quiz Category naming with apostrophe?

Paul Robinson írta időpontban

Hi

Version 1.7 too. I tried closing the browser and logging in again, resaving the questions, checked the settings for each question was compatible with other questions in the quiz, changing the question names. Nothing worked till I removed the apostrophe in the category name.

This only occurred when adding a random question using the Add button. It did not happen when adding a specific question to a quiz.

regards

Paul

Válasz erre: Paul Robinson

Re: Possible small bug in Quiz Category naming with apostrophe?

Joseph Rézeau írta időpontban
Kép Kép Kép Kép Kép

Hi Paul,

I confirm the bug in Moodle 1.7.1+

Solution: In file moodle/mod/quiz/edit.php, towards line 185, replace:

$form->name = get_string('random', 'quiz') .' ('. $category->name .')';

with

$form->name = get_string('random', 'quiz') .' ('. addslashes($category->name) .')';

Tested, it works. If the bug is confirmed (and my solution works) maybe Howard could you add a bug report for it? thanks

Joseph

image00.jpg csatolmány
Válasz erre: Joseph Rézeau

Re: Possible small bug in Quiz Category naming with apostrophe?

Tim Hunt írta időpontban
Kép Kép Kép Kép Kép
Thanks Joseph. Fix checked in to 1.7.1+ and later.
Válasz erre: Tim Hunt

תשובה ל: Re: Possible small bug in Quiz Category naming with apostrophe?

Miki Alliel írta időpontban
Kép

hello everyone

I just got this error when trying to add random questions from a category of a course which the name of the category includes an apostrophe , and  without it it worked.

I tried that on Moodle 1.9.1 and moodle 1.9

is it going to be fixed in build weekly Moodle 1.9.1 ?

Válasz erre: Miki Alliel

Re: תשובה ל: Re: Possible small bug in Quiz Category naming with apostrophe?

Tim Hunt írta időpontban
Kép Kép Kép Kép Kép
Oh, I see, this never got filed in the tracker. I have just created the report: MDL-14928 and am about to implement the fix (Joseph is right).