BUG? or just me- RESPONSES unchecked

BUG? or just me- RESPONSES unchecked

by Deleted user -
Number of replies: 19

In Moodle 1.6.4, I uncheck all the boxes related to "Student May Review Immediately After The Attempt", but after the student submits the test to be scored, it will still display all the questions and all the students answers they have chosen.

Students may review:
Immediately after the attempt:
Later, while the test is still open:
After the test is closed:
Responses Scores Feedback Answers Help, Allow review

Also, if you uncheck the RESPONSES column for "Later, while test is still open" and/or "After test is closed", then when you go to review a previous attempt, it will still display the all the questions and the students answers.

Does this column RESPONSES refer to something different than the students responses? If it does refer to student responses, then I think there is a bug!

Average of ratings: -
In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by Joseph Rézeau -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators

Hi Jeff,

I have just tried your scenario on a 1.6.4 Moodle and I cannot reproduce it. If all the boxes in Students may review have been unchecked, then nothing is displayed upon completing the quiz. Are you doint the quiz in teacher mode or are you actually logged in as a student?

Joseph

In reply to Joseph Rézeau

Re: BUG? or just me- RESPONSES unchecked

by Deleted user -

I created a new seperate student account with no special privileges, and if I leave the RESPONSES box unchecked, it still displays them.

I copied and pasted the screen above, but it didn't display properly. Is there a special way to copy and paste screen shots?

In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by Joseph Rézeau -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators
Jeff > I copied and pasted the screen above, but it didn't display properly. Is there a special way to copy and paste screen shots?

For screen capture I recommend the excellent SnagIt software from TechSmith. For uploading a screen shot to the Moodle forums you simpy attach it (Attachment optional just below of HTML editor). There is a limit of 100k to the size of such attachments.

Joseph

In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by Jeffery Watkins -
If the test has unlimited attempts, students will see their previous responses.... correct?

Jeff
In reply to Jeffery Watkins

Re: BUG? or just me- RESPONSES unchecked

by Deleted user -

Even if I change the Attempts from unlimited to 6, and leave Responses unchceked , it still displays the students responses right after they submit their test.

In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by Tim Hunt -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
I think this was a bug in 1.5.x, but I am not really sure. That is ancient history as far as I am concerned, and I don't have the time to be able to support it. Sorry.
In reply to Tim Hunt

Re: BUG? or just me- RESPONSES unchecked

by Deleted user -

We are using 1.6.4, but I actually don't need this feature, because I want them to see their responses. I just came across the issue, so thought I would mention it.

In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by Joseph Rézeau -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators
Jeff >We are using 1.6.4, but I actually don't need this feature, because I want them to see their responses. I just came across the issue, so thought I would mention it.

What do you mean by "this feature"? What do you mean by "the issue"? Do you mean that the "bug" you reported was not a bug after all? Please, try to be more explicit..

Josephthoughtful

In reply to Joseph Rézeau

Re: BUG? or just me- RESPONSES unchecked

by Deleted user -

Joseph Rezeau wrote "What do you mean by "this feature"? What do you mean by "the issue"? Do you mean that the "bug" you reported was not a bug after all? Please, try to be more explicit.."

By "feature", I mean the ability to display (or not display) the students responses, immediately after the submit their test to be scored. When I was "playing" around with these checkboxes, it didn't matter whether or not I checked or unchecked the RESPONSES column, the students responses were still displayed immediately after they submitted their test. That's okay for me, because I DO want them to see their responses right away, but their might be others that do NOT want their students to see their responses immediately after they submit their test for scoring.

In an earlier reply, you (I think it was you, Joseph) said you could not reproduce the problem, and then Tim Hunt wrote "I think this was a bug in 1.5.x, but I am not really sure. That is ancient history as far as I am concerned, and I don't have the time to be able to support it. Sorry."

So anyway, I was just saying that if it is a bug (which I'm still not sure if it is or not), it doesn't really cause me any problems, because I'm not trying to hide the students responses.

Hope this helps clear up what I'm talking about.

P.S.- I am using Moodle 1.6.4

In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by Joseph Rézeau -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators
Hi Jeff,
Thanks for clarifying things. As far as I can tell there is no bug at all here, but I do agree that the quiz settings are quite complex and not easy to work with...
Joseph
In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by stefano federici -

It seems exactly the same problem I have with quizzies 1.5. After having unchecked everything in quiz settings, a student account will get the following output after submitting (even if I wouldn't like it to be shown to the students):

Simulazione Quiz x prova in itinere del 21-02-07

Time limit: 30 mins

The quiz is available until: mercoledì, febbraio 28 2007, 02:00

Attempt Time taken Completed Marks / 2 Grade / 32
1 11 secs martedì, febbraio 20 2007, 06:50 2 32

No more attempts are allowed

Your final grade for this quiz is 32 / 32

In reply to stefano federici

Re: BUG? or just me- RESPONSES unchecked

by Joseph Rézeau -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators
Stefano > It seems exactly the same problem etc.

No, not the same problem! In his original post, Jeff complained that the quiz "will still display all the questions and all the students answers they have chosen".

You complain that the students will see their final Grade. This is different.

Moodle 1.5 is a really old version now, and I cannot say anything about it. But I can say that in Moodle 1.6 or 1.7 you can set a quiz in such a way that students will not see either their responses, the answers or their total grade after completing a quiz.

Joseph

In reply to Joseph Rézeau

Re: BUG? or just me- RESPONSES unchecked

by stefano federici -
Joseph, could you please post the relevant 1.6 or 1.7 files in which this check is performed so that I can compare them with my 1.5 files? Thanks.
In reply to stefano federici

Re: BUG? or just me- RESPONSES unchecked

by Joseph Rézeau -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators

Stefano,

Sorry, but this is far too complicated and I do not know where the various checkings are done. Plus there have been so many important changes to the way questions and quiz work between 1.5 and 1.6 that comparing 1.6 files with 1.5 would probably be no help and might lead to complete crash.

Why don't you simply upgrade to 1.6 or 1.7?

Joseph

In reply to Joseph Rézeau

Re: BUG? or just me- RESPONSES unchecked

by stefano federici -
I cannot change to 1.6 as my hosting provider (alterhosting.com, not very good at support but chaep) doesn't support the needed versions of PHP/MySQL. And I cannot afford changing provider (neither because of the increase in the cost nor because of the time spent in moving all my more-than-fifty sites).
In reply to Deleted user

Re: BUG? or just me- RESPONSES unchecked

by stefano federici -

I don't think I completely solved the problem (I mean, my problem), but at least I managed to get rid of those scores that are shown right after the attempt. It seems that this (at least in version 1.5) is due to the following check in /mod/quiz/review.php

        // If not even responses are to be shown in review then we
        // don't allow any review
        if (!($quiz->review & QUIZ_REVIEW_RESPONSES)) {
            redirect('view.php?q='.$quiz->id);
        }

This means that, if no responses must be shown, control is transferred to view.php. But in view.php there is no check of QUIZ_REVIEW_SCORES. So, to add this check, I did the following.

I added a new function at the end of view.php (after function quiz_review_allowed):

function quiz_scores_allowed($quiz) {
        // If not even responses are to be shown in review then we
        // don't allow any review
        if (!($quiz->review & QUIZ_REVIEW_SCORES)) {
            return false;
        }
        if ((time() < $quiz->timeclose) and !($quiz->review & QUIZ_REVIEW_OPEN)) {
            return false;
        }
        if ((time() > $quiz->timeclose) and !($quiz->review & QUIZ_REVIEW_CLOSED)) {
            return false;
        }
        return true;
    }

Then I changed line 171 from

    if ($numattempts) {

to

    if (quiz_scores_allowed($quiz) && $numattempts) {

and line 302 from

            if ($quiz->grade and $quiz->sumgrades) {
to

            if (quiz_scores_allowed($quiz) && $quiz->grade and $quiz->sumgrades) {

Hope file content and line numbers are not so different from 1.6.

Can I ask a favor? Could someone send me the file mod/quiz/report.php from 1.6 so that I can regrade my quizzies? Thanks.

In reply to stefano federici

Re: BUG? or just me- RESPONSES unchecked

by Joseph Rézeau -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators
Here you are (from Moodle 1.6.4 stable)
Joseph
In reply to Joseph Rézeau

Re: BUG? or just me- RESPONSES unchecked

by Tim Hunt -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
Just so that you know, you can get any version of any moodle file from http://moodle.cvs.sourceforge.net/moodle/.

So for this request, you would navigate to http://moodle.cvs.sourceforge.net/moodle/moodle/mod/quiz/report.php?view=log. Then, look through the log to find the line with 'CVS Tags:' that includes 'MOODLE_164' (which is how you know which version was used in Moodle 1.6.4), and therefore click on the 'view' or 'download' link next to 'Revision 1.40.2.1'.