When I'm trying to use LDAP-authentification with moodle 1.7, I get:
"This SQL relies on obsolete tables! Your code must be fixed by a developer."
after trying to log in an LDAP-User. Is this a tribute to beta-status and is it going to be fixed? LDAP is great...
regards,
Maik
Thanks. After deleting course creators everything is fine again.
Maik
Maik
In antwoord op Maik Riecken
Re: LDAP-authentification doesn't work in 1.7...
deur Gisela Hillenbrand -
Hi Maik,
what do you mean with "after deleting course creators everything works fine"?
We are using LDAP authentification but course creators are not identified correctly. Looking at the LDAP Server log file does not give an error.
Gisela
what do you mean with "after deleting course creators everything works fine"?
We are using LDAP authentification but course creators are not identified correctly. Looking at the LDAP Server log file does not give an error.
Gisela
In antwoord op Dan Marsden
Re: LDAP-authentification doesn't work in 1.7...
deur Gisela Hillenbrand -
It seem's to me that the code at line 2385 - ... in moodlelib.php is still not correct.
The original code is:
if (function_exists('auth_iscreator')) {
$sitecontext = get_context_instance(CONTEXT_SYSTEM);
if ($creatorroles = get_roles_with_capability('moodle/legacy:coursecreator', CAP_ALLOW)) {
$creatorrole = array_shift($creatorroles); // We can only use one, let's use the first one
// Check if the user is a creator
if (auth_iscreator($username)) { // Following calls will not create duplicates
if ($useriscreator) {
role_assign($creatorrole->id, $user->id, 0, $sitecontext->id, 0, 0, 0, 'ldap');
} else {
role_unassign($creatorrole->id, $user->id, 0, $sitecontext->id);
}
}
}
}
However, the variable $useriscreator is not defined.
If I change the code to the following LDAP authentification and course creators work fine:
if (function_exists('auth_iscreator')) {
$sitecontext = get_context_instance(CONTEXT_SYSTEM);
if ($creatorroles = get_roles_with_capability('moodle/legacy:coursecreator', CAP_ALLOW)) {
$creatorrole = array_shift($creatorroles); // We can only use one, let's use the first one
// Check if the user is a creator
$useriscreator = auth_iscreator($username); // Following calls will not create duplicates
if ($useriscreator) {
role_assign($creatorrole->id, $user->id, 0, $sitecontext->id, 0, 0, 0, 'ldap');
} else {
role_unassign($creatorrole->id, $user->id, 0, $sitecontext->id);
}
}
}
Sorry, I don't get the code formatted in a better readable way
Gisela
The original code is:
if (function_exists('auth_iscreator')) {
$sitecontext = get_context_instance(CONTEXT_SYSTEM);
if ($creatorroles = get_roles_with_capability('moodle/legacy:coursecreator', CAP_ALLOW)) {
$creatorrole = array_shift($creatorroles); // We can only use one, let's use the first one
// Check if the user is a creator
if (auth_iscreator($username)) { // Following calls will not create duplicates
if ($useriscreator) {
role_assign($creatorrole->id, $user->id, 0, $sitecontext->id, 0, 0, 0, 'ldap');
} else {
role_unassign($creatorrole->id, $user->id, 0, $sitecontext->id);
}
}
}
}
However, the variable $useriscreator is not defined.
If I change the code to the following LDAP authentification and course creators work fine:
if (function_exists('auth_iscreator')) {
$sitecontext = get_context_instance(CONTEXT_SYSTEM);
if ($creatorroles = get_roles_with_capability('moodle/legacy:coursecreator', CAP_ALLOW)) {
$creatorrole = array_shift($creatorroles); // We can only use one, let's use the first one
// Check if the user is a creator
$useriscreator = auth_iscreator($username); // Following calls will not create duplicates
if ($useriscreator) {
role_assign($creatorrole->id, $user->id, 0, $sitecontext->id, 0, 0, 0, 'ldap');
} else {
role_unassign($creatorrole->id, $user->id, 0, $sitecontext->id);
}
}
}
Sorry, I don't get the code formatted in a better readable way
Gisela
Hi Gisela,
Thanks very much for spotting it, and thanks very much for posting the patch, the right code is in CVS now. And thanks Dan for pointing me here =0
Cheers,
Yu
Thanks very much for spotting it, and thanks very much for posting the patch, the right code is in CVS now. And thanks Dan for pointing me here =0
Cheers,
Yu
Fine!
Thank you, Yu.
Gisela
Thank you, Yu.
Gisela