Adaptable: Missing information on what needs grading in group assignment

Adaptable: Missing information on what needs grading in group assignment

by Peter Diedrichs -
Number of replies: 7
Picture of Particularly helpful Moodlers

Hi, we recently upgraded to Moodle 3.11.10  and Adaptable Release 3.11.1.2, version 2021081007

There seem to be a bug regarding the "submissions to grade" information, when using group assignments.

  1. Individual assignment, grading info shows
  2. Group assignment, grading info does not show




Average of ratings: -
In reply to Peter Diedrichs

Re: Adaptable: Missing information on what needs grading in group assignment

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Dear Peter,

Adaptable calls the core API for this:

    protected static function assign_nums($courseid, $mod) {
        // Ref: get_assign_grading_summary_renderable().
        $coursemodulecontext = \context_module::instance($mod->id);
        $course = get_course($courseid);
        $assign = new \assign($coursemodulecontext, $mod, $course);
        $activitygroup = groups_get_activity_group($mod);
        $instance = $assign->get_default_instance();
        if ($instance->teamsubmission) {
            $participants = $assign->count_teams($activitygroup);
        } else {
            $participants = $assign->count_participants($activitygroup);
        }
        $submitted = ASSIGN_SUBMISSION_STATUS_SUBMITTED;
        return array(
            'participants' => $participants,
            'submissions' => $assign->count_submissions_with_status($submitted, $activitygroup),
            'ungraded' => $assign->count_submissions_need_grading($activitygroup)
        );
    }

Thus only an interface to what core Moodle tells it.

G

In reply to Gareth J Barnard

Re: Adaptable: Missing information on what needs grading in group assignment

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Dear Peter,

Ok as I'm a perfectionist, I've done a double check and looked at the core code, so does changing:

$activitygroup = groups_get_activity_group($mod);

to:

$activitygroup = groups_get_activity_group($mod, true);

make a difference? -> method 'assign_nums' in /theme/adaptable/classes/activity.php + purge all caches.

G



In reply to Gareth J Barnard

Re: Adaptable: Missing information on what needs grading in group assignment

by Peter Diedrichs -
Picture of Particularly helpful Moodlers
Thanks Gareth! I'll ask our server techs to put this in our test environment, so I can try it.
In reply to Gareth J Barnard

Re: Adaptable: Missing information on what needs grading in group assignment

by Peter Diedrichs -
Picture of Particularly helpful Moodlers
Hi Gareth, it seem not to be solved.


In reply to Peter Diedrichs

Re: Adaptable: Missing information on what needs grading in group assignment

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Peter,

In that case I'm stumped, bar investigating and seeing how the core code works. Could you perhaps try and replicate on a M4.0 instance where core provides such information? And what's shown when you click on the grouped assignment to show that there is an ungraded submisson?

G
In reply to Gareth J Barnard

Re: Adaptable: Missing information on what needs grading in group assignment

by Peter Diedrichs -
Picture of Particularly helpful Moodlers

Hi Gareth, no wonder it's not working... the "Needs grading" information on group assignment seems to be completely missing in core (I have switched to Boost theme here in the pictures). 

The group assignment is set to allow one student to submit for the whole group.