General plugins

You're right. That's true. Now, the text and sub-text for checkboxes appear, but when you check one of the boxes, all the boxes are checked in the admin/ teacher result.

All related code involved is here below:

    //hide the field if not teacher and it's hidden from the students
    if ($formfield->field != "") {
    
        //select and radio types might have more than 1 subs
        $howmany = substr_count("$formfield->multi", "|"); //For radiobutton
        $howmanys = substr_count("$datafield->multi", "|") + 1; //For Select      
        $val_array = explode("|", "$formfield->multi");

and then further down...

        if ($formfield->type == "checkbox") {
            if ($leftside && $rightside) {
                if ($formfield->side == "l") {
                    echo "<tr>";
                }
            } else {
                echo "<tr>";
            }
  //$val_array starts from 0
            $k=1; //We want that in excel table it starts from 1
               for ($j=0; $j<=$howmany; $j++) {
                if ($j == 0) {
            if (!$presentation || $form->hidequestions == 0) {
                if (isteacher($course->id) or $formfield->sright == "write") {
                    echo "<td $color align=\"left\" valign=\"top\"><b>".$formfield->field;
                    if ($editing && $formfield->required == 1) {
                        echo "*";
                    }
                } else {
                 echo "</b>&nbsp;";
                  }
                        echo "</td>";
                    }
                    echo "<td $color align=\"left\"><table><tr><td $color align=\"left\">";
                   } else {
   echo "<tr>";

            echo "<td $color align=\"left\">";
            }
            if (isteacher($course->id) or $formfield->sright == "write") {
                if ($formfield->value == "on") {
                    echo "<input type=\"checkbox\" name=v$i checked />";
                } else {
                    echo "<input type=\"checkbox\" name=v$i />";
                }
                echo "&nbsp;&nbsp;$val_array[$j]</td></tr>";
            } else {
                echo "&nbsp;</td></tr>";
            }
}
            echo "</table></td>";
            if ($leftside && $rightside) {
                if ($formfield->side == "r") {
                    echo "</tr>";
                }
            } else {
                echo "</tr>";
            }
            echo "<input type=\"hidden\" name=i$i value=\"$formfield->id\" />";
        }

I am looking into it right now. The scripts in bold should have caused the problem. Any help is appreciated.

I know there are still some other bugs, but if we fix this one, the form module should at least be functioning.

Perhaps I attach the file again. This file enclosed here is the latest version 1.10 and is then amended with the above script.

I hope some experts here would help to amend the code.

All the best

James

hello Teemu,

the file is:

/moodle/mod/form/details.php

thx for help

I checked with "manual debug", seems to be there is a problem somewhere in 10 line:   

if ($form = data_submitted($destination)) {

thx