Integration round 2020-04-02 - Spring or Autumn (depending on your hemisphere) is in the air :-)

Integration round 2020-04-02 - Spring or Autumn (depending on your hemisphere) is in the air :-)

by Sara Arjona Téllez -
Number of replies: 2
Picture of Core developers Picture of Moodle HQ Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Cold numbers

22 issues have been successfully integrated with 7 rejected and  30 delayed. That's 75% success rate this week!

Notes

  • Have you ever heard about the "ready_for_integration" label? It can be used for devs missing "pull-request" permissions to indicate that an issue is, after their review, ready. It has been added to the "Tracker issue labels" doc page. You can use this filter is to check which issues have that label. Important: the correct label is "ready_for_integration" (to match every other label). For now, we've kept in the filter the old using "-" just in case somebody reintroduces it wink
  • There are still 64 issues awaiting peer-review ... Will this number be under 50 any day? tongueout
  • MDL-45227 landed this week. It includes some RTL improvements to Atto but, for now, it has been only applied to master. In order to consider to backport it to stables safely (3.7 and 3.8), we would like to ask you to test it intensively: different operating systems, browsers, languages... TIA!
  • Four weeks for Moodle 3.9 LTS code freeze Monday, 4th of May.
  • This week we've started the "Moodle Party Daily ONLINE", a 30 minutes session open to all Moodlers around the world. You'll find more information here.

Hot topics

  • MDL-45227: Add text direction to default ATTO generated markup
  • MDL-67734: Create basic skeleton for a global xAPI library
  • MDL-64494: Contrast of colours for success, info, error and warnings text is not accessible
  • MDL-68116: Prepare Moodle to be ready when h5p.org down completely so that only the author can see the test content
  • MDL-58964: Add existing class attributes to Boost flat navigation nodes
  • MDL-67995: Single activity format dropdown from types of activity empty
  • MDL-52319: Failed environment.xml check does not prevent plugin from being installed
  • And lots more in areas like questions, LTI, H5P, accessibility...

One at a time

This (non-regular) new initiative in the integration posts aims to get various policy issues communicated and, with your collaboration, decided and applied in an organised way.

  • This week we have achieved an agreement about MDLSITE-5667 (Coding style ruling about function/method return types and nullables), matching the PSR-12:

1) No whitespace between the nullable character (question mark -?) and params or return types.

2) No whitespace between the function closing brackets and the colon.

With an image speaking a thousand words. Correct:

          public function foo(string $bar, ?int $baz): ?bool {}

(you can find the complete version already @ Moodle Docs / Coding style)

  • For the next week, we would like to propose the following issue, granting you the opportunity of commenting there over the next 4 days: MDLSITE-6096: One webservice per class. We'll be waiting for your comments there! wink

Remember you can find all the policies issues reviewed in the "One at a time" section in the following epic: MDLSITE-6092

Warm thanks

Average of ratings:Useful (5)
In reply to Sara Arjona Téllez

Re: Integration round 2020-04-02 - Spring or Autumn (depending on your hemisphere) is in the air :-)

by Nadav Kavalerchik -
Picture of Core developers Picture of Plugin developers Picture of Testers Picture of Translators
Thanks you Sara and HQ team for working so hard at making Moodle what it is, especially now at these challenging time!
Average of ratings:Useful (1)
In reply to Nadav Kavalerchik

Re: Integration round 2020-04-02 - Spring or Autumn (depending on your hemisphere) is in the air :-)

by Acqua Alta -
Thanks for everyone at HQ, of course.
And thank you, Nadav, for your contribution to the Moodle community at general, and to the Moodle RTL community specifically smile