forgotten password stopped working with https

forgotten password stopped working with https

oleh Martin Millmore -
Number of replies: 2

I tried to report this in the Moodle Tracker, but it blocked me saying I had not searched for an existing issue - which I had. Perhaps someone else can log the bug?

Forgotten password has stopped working for https connections in the latest release (3.1.2). It looks like issue MDL-50803 was attempted to be fixed, but it introduced this bug by adding the following line to login/forgotten_password.php

        redirect($CFG->wwwroot . '/login/forgot_password.php');

but it should check $CFG->loginhttps to decide whether to redirect to a secure URL;

        if($CFG->loginhttps){
            redirect($CFG->httpswwwroot . '/login/forgot_password.php');
        } else {
            redirect($CFG->wwwroot . '/login/forgot_password.php');
        }


Average of ratings: -
In reply to Martin Millmore

Re: forgotten password stopped working with https

oleh Jake Dallimore -
Gambar Core developers Gambar Moodle HQ Gambar Particularly helpful Moodlers Gambar Peer reviewers Gambar Plugin developers Gambar Testers

Thanks for reporting this, Martin. i've created a tracker issue for this here:  https://tracker.moodle.org/browse/MDL-55945

Average of ratings:Useful (1)