Links work only in some parts of items

Links work only in some parts of items

by mart van der niet -
Number of replies: 11

In Essential (2016061707) there seems to be a problem with hyperlinks in some places:

When adding Custom menu items  the link seems only to be active in the left hand side of the item

Same goes for collapsed topics.

Those are the red parts of the attached image.

 

Anyone seen this before?

 

MvdN

Attachment Naamloos.png
Average of ratings: -
In reply to mart van der niet

Re: Links work only in some parts of items

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hi Mart,

No I've not seen it and I can't reproduce it.

Once there was a slight issue with CT and the toggle, but I fixed that a while ago.  What version of CT are you using? - also it does not use links anymore.

G

In reply to Gareth J Barnard

Re: Links work only in some parts of items

by mart van der niet -

CT is ??

In reply to mart van der niet

Re: Links work only in some parts of items

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

CT = Collapsed Topic

I am wondering if you are adding the menu items wrongly..I mean the way you are writing them perhaps?

For example how have you written the Menu item in the example you highlighted in the image you uploaded?

Thanks

Mary

In reply to Mary Evans

Re: Links work only in some parts of items

by mart van der niet -

Code for menu items:

 

Resources PRINCE2
-Handleiding voor deze site|http://www.prince2leren.nl//MoodleCommon/Common_Docs/UG-NL-Essential-1.pdf" target="_blank"||nl
-Userguide for this site|http://www.prince2leren.nl//MoodleCommon/Common_Docs/UG-EN-Essential-1.pdf" target="_blank"||en
-PRINCE2 Syllabus|http://www.prince2leren.nl//MoodleCommon/Common_Docs/PRINCE2_Syllabus_2011_v1.5.pdf" target="_blank"||en,nl
-PRINCE2 Foundation examen richtlijnen|http://www.prince2leren.nl//MoodleCommon/Common_Docs/NL_PRINCE_Foundation_examen-Richtlijnen_voor_de_kandidaat.pdf" target="_blank"|nl
-PRINCE2 Foundation exam candidate guidance|http://www.prince2leren.nl//MoodleCommon/Common_Docs/EN_PRINCE2_Foundation_Exam_Candidate_Guidance_v1.7.pdf" target="_blank"||en
-PRINCE2 Practitioner examen richtlijnen|http://www.prince2leren.nl//MoodleCommon/Common_Docs/NL_PRINCE2_Practitioner_examen-Richtlijnen_voor_de_kandidaat.pdf" target="_blank"||nl
-PRINCE2 Practitioner examenvoorbereiding|http://www.prince2leren.nl//MoodleCommon/Common_Docs/Examenvoorbereiding_PRINCE2_Practitioner_v2.0.pdf" target="_blank"||nl
-PRINCE2 Practitioner exam candidate guidance|http://www.prince2leren.nl//MoodleCommon/Common_Docs/EN_PRINCE2_Practitioner_Exam_Candidate_Guidance_v1.7.pdf" target="_blank"||en
-Online overzicht van PRINCE2|http://online.prince2leren.nl" target="_blank"||nl
-Online overview PRINCE2 |http://online.prince2leren.nl" target="_blank"||en
-Online overview PRINCE2 documenten|http://online.prince2leren.nl/showpage.php?language=nl&path=documents&file=documents&topicNumber=2||nl
-Online overview PRINCE2 documents|http://online.prince2leren.nl/showpage.php?language=en&path=documents&file=documents&topicNumber=2 ||en
-eCertificates|http://www.prince2leren.nl//MoodleCommon/Common_Docs/eCertificates_Portal_-_Candidate_Guidance_(English).pdf" target="_blank"||en,nl
-eCertificates Video Explanation|http://www.prince2leren.nl//MoodleCommon/Common_Docs/ecert_training.mp4" target="_blank"||en,nl
-Online examen userguide (Engels)|http://www.prince2leren.nl//MoodleCommon/Common_Docs/APMG_International_Candidate_Online_Exam_Guidance.pdf" target="_blank"||nl
-Online exam userguide|http://www.prince2leren.nl//MoodleCommon/Common_Docs/APMG_International_Candidate_Online_Exam_Guidance.pdf" target="_blank"||en
-Online Examen verkennen|http://www.apmg-exams.com/index.aspx?masterid=1||nl
-Explore Online Exam|http://www.apmg-exams.com/index.aspx?masterid=1||en
-ProctorU Candidate Guidance|http://www.prince2leren.nl//MoodleCommon/Common_Docs/ProctorUCandidateGuidance.pdf" target="_blank"
-ProctorU FAQs|http://www.prince2leren.nl//MoodleCommon/Common_Docs/ProctorUFAQs2016.pdf" target="_blank"

In reply to Gareth J Barnard

Re: Links work only in some parts of items

by mart van der niet -

Version 2015103005

In reply to mart van der niet

Re: Links work only in some parts of items

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

The code is wrong in some places.

When you add the target="_blank" you do not need the last " so your menu item should look like this...

 Resources PRINCE2
-Handleiding voor deze site | http://www.prince2leren.nl//MoodleCommon/Common_Docs/UG-NL-Essential-1.pdf" target="_blank | | nl
-Userguide for this site | http://www.prince2leren.nl//MoodleCommon/Common_Docs/UG-EN-Essential-1.pdf" target="_blank | | en

I have added spaces so you can see better.

I hope that helps?

Mary

Average of ratings: Useful (1)
In reply to Mary Evans

Re: Links work only in some parts of items

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hi Mart,

I suspect Mary's reply is the answer to the problem.

Cheers,

Gareth

Average of ratings: Useful (1)
In reply to Gareth J Barnard

Re: Links work only in some parts of items

by mart van der niet -

Thanks a lot, solved the problem!

Average of ratings: Useful (1)
In reply to mart van der niet

Re: Links work only in some parts of items

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Seems to me to be an easy mistake to make.  Core improvement?

In reply to Gareth J Barnard

Re: Links work only in some parts of items

by mart van der niet -

A decent description of how this should be coded would help!

In reply to mart van der niet

Re: Links work only in some parts of items

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi,

It's not mentioned in the language files as it is not authorised by Moodle, it is a HACK that has arisen out of need. Making this into a Tracker issue in Moodle would be a good idea so I think the answer to Gareth is a resounding YES...an improvement in CORE.

Cheers

Mary