Lesson

Hello Wendi,

To suppress that warning, just add

$duration = 0;

just after the line

 $timespent = false;

and before the line

if ($attempttimes = $DB->get_records('lesson_timer', array("userid"=>$USER->id, "lessonid"=>$dependentlesson->id))) {

So here is how your code should look after the change:

            // check for the timespent condition
            if ($conditions->timespent) {
                $timespent = false;

                $duration = 0;
                if ($attempttimes = $DB->get_records('lesson_timer', array("userid"=>$USER->id, "lessonid"=>$dependentlesson->id))) {
                    // go through all the times and test to see if any of them satisfy the condition
                    foreach($attempttimes as $attempttime) {
                        $duration += $attempttime->lessontime - $attempttime->starttime;
                        if ($conditions->timespent < $duration/60) {
                            $timespent = true;
                        }
                    }
                }
                if (!$timespent) {
                    $errors[] = get_string('timespenterror', 'lesson', $conditions->timespent);
                }
            }

As a "reward" for helping you , can I ask you a service ? I am currently trying to add a time spend completion rule to lesson for Moodle 2.9

This will be more robust that the current feature (for instance for backup/restore) and will permit a lot of wonderful things because it will permit not only to make a lesson dependant of time spend in another lesson but for instance to allow access to a quiz, a document, a glossary or a survey, or any other activity based on the time spend in a lesson.

This feature will integrate Joseph's patch so all times spend in a lesson will be added to decide if the lesson is completed or not.

If you think this feature would be useful please can you vote for MDL-48715, this feature has currently only gathered one vote and I am fearing this will not be enough to persuade integrators to accept it .

The same is true for all lesson users, please vote for MDL-48715 if you think it would be good to have a completion rule based on time spend in a lesson. Thanks for your support.

I forgot to add something,

have you noted that since Joseph's departure there is no more any moderator to this forum so calling any moderator will most probably have no effect at all.

This is just another reason why I am sadly missing Joseph .