This was one of the first renderers I wrote for Moodle Bootstrap and I think it really makes a difference to usability, accessibility, code quality and simply looks much nicer but the bug to move it into core has somewhat languished.
https://tracker.moodle.org/browse/MDL-38260
The next steps are to convince core that it's better than what's there and rewrite the code to follow Moodle conventions (mostly the use of html_writer).
I believe that some of the bugs that this code fixes may have been independently fixed as there was some activity around this, so you may have to merge the two sets of changes.
Any takers?
David,
If you have been working on this renderer, then why not submit it for Peer Review? I noticed that there is no 'triaged' label, which is first line of defence for setting a tracker if it needs to be noticed.
If I were you I would assign it to yourself, add a 'triaged' label, also add 'Must fix for 2.6' in the Fix version section.
Fix the renderer, add the branches as usually, then get someone to Peer Review it, perhaps Tim Hunt or Marina Glancy if they have time? I could peer review too and anyone else who may be interested.
I would not worry too much about the HTML_writer in the early stages of testing, but if it works OK that part should be easy enough to work out and clean up before finally pushing for Integration Review.
Just my thoughts on a Friday afternoon.
Cheers
Mary
Re: Do you want to adopt the render_paging_bar renderer?
Hi David,
I'm interested in this but time has been an issue recently. Is the branch rebased to the latest master to determine what has actually been fixed? How is it tested and would this mean creating Behat tests?
Perhaps a collaboration is in order?
Cheers,
Gareth
Re: Do you want to adopt the render_paging_bar renderer?
There's a couple of tricky parts, but it's not a big job. There was a similar rewriting process for getting a Bootstrap tab renderer into core in MDL-39388.
And there's no big rush on the timing, if it gets merged into 2.7 then people will probably feel okay about using the renderer in their 2.5 or 2.6 themes.
Also, I got a page added to the Totara element library for testing this part of Moodle too, which helps massively:
https://github.com/totara/moodle/pull/1
edit: also a good guide to progress would be to try to work on output renderers that work for Bootstrap 2, Bootstrap 3 and Danny's Yui Pure theme, as you go to help avoid hardcoding any assumptions.
Also, I'm happy to help in any way to move this forward. Mostly just struggling with motivation since the interesting parts (for me anyway) were done a year ago, so thought a fresh pair of legs might help to carry it over the line.
Re: Do you want to adopt the render_paging_bar renderer?
Hi David,
As it was developed outside of Moodle core is it worth continuing to do so to make it 'Moodle core ready' as that seems to be the best way of making rapid progress. Perhaps as a branch of some of the excellent new Bootstrap based themes: Julian's Essential (https://moodle.org/plugins/view.php?plugin=theme_essential), Aardvark (bootstrap version - https://moodle.org/plugins/view.php?plugin=theme_aardvark), Richard's Buckle (https://moodle.org/mod/forum/discuss.php?d=227652), Mary's Mini-Bootstrap? and my Shoelace (https://moodle.org/plugins/view.php?plugin=theme_shoelace).
Then when completed and 'html_writer'fied then submit for peer review as a part of the 'Clean' theme. If it were in a branch of one of those themes then we could all work on it?
Cheers,
Gareth
Re: Do you want to adopt the render_paging_bar renderer?
P.S. Sorry, I don't have the link to Mary's Mini-Bootstrap.
Re: Do you want to adopt the render_paging_bar renderer?
Re: Do you want to adopt the render_paging_bar renderer?
Developing it for core and for themes is basically the same thing at the level of code though, it's just a question of who you need to convince to use it. And of course both can be pursued at the same time. So you could work on it in your shoelace or mutant banjo theme's github. As you rewrite it to use html_writer it'll become more self-contained and easier for other themers to grab the code.