Greylisted string from mod_quiz in the new HotPot module @Gordon

Greylisted string from mod_quiz in the new HotPot module @Gordon

by Bente Olsen -
Number of replies: 8

Hi Gordon

Working with the Danish translation of the new HotPot module (what a great effort - thanks!) I have discovered that HotPot is using a mod_quiz text string, allowreview, that is greylisted in AMOS. I just assume that you want to use allowreview from mod_hotpot instead (which is greylisted too, but I have notified David Mudrák so I am sure that he will fix this soon). The string is used in the Access control section of the module settings page.

BTW would you prefer that I have used the tracker?

Average of ratings: -
In reply to Bente Olsen

Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Gordon Bateson -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers
Hi Bente,
I'm afraid I don't understand "greylisted in AMOS". Could you explain?
thanks
Gordon
Average of ratings: -
In reply to Gordon Bateson

Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Gordon Bateson -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers

Bente,
I found the Moodle Docs page about "AMOS", so I know what that is now.

  • AMOS (Automated Manipulation of Strings)

However, I don't understand what it means for a string to be "greylisted". Is there an explanation of that somewhere you could point me to?

cheers
Gordon

Average of ratings: -
In reply to Gordon Bateson

Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Gordon Bateson -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers

On the following page ...

I found this explanation of "greylisting" ...

All the string names that were not found in Moodle 2.0 source code (as a pattern) are now marked as "greylisted" in AMOS. We have ~2000 greylisted strings at the moment, some of them are false positives. We can go through the greylist in AMOS and if we are 100% sure the string is not used any more, it can be removed from CVS HEAD. Although I would suggest to wait after we branch off MOODLE_20_STABLE.

The HotPot module for Moodle 2.x was rewritten completely from scratch - including the lang strings file, so I can say with almost 100% certainty that any string in the HotPot lang file is there because it needs to be.

Therefore, please arrange for "allowreview" to be removed from the AMOS greylist for the HotPot module.

thanks in advance
Gordon

Average of ratings: -
In reply to Gordon Bateson

Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Gordon Bateson -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers

Bente,
I checked the HotPot module for Moodle 2.x again and found that the "allowreview" string is used in the "mod_form.php". However, it was getting the string from the "quiz" module. This is what you pointed out in your original post - sorry to be so slow in fully understanding what you meant blush.

I have changed this occurrence of this string in "mod/hotpot/mod_form.php"

  • OLD: get_string('allowreview', 'quiz')
  • NEW: get_string('allowreview', 'hotpot')

You can download the modified script from Moodle CVS in due course, or from the following URL immediately:

many thanks for bringing this issue to my attention approve
Gordon

Average of ratings: -
In reply to Gordon Bateson

Ang: Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Bente Olsen -

Hi Gordon
I am glad that you found out what I was talking about. I just thought that as a member of the translator group you were familiar with lang.moodle.org and the translation toolkit, AMOS, there.
I have had a look for other greylisted HotPot strings, there is one more: clues. If it is still used I can add it to the 'Greylisted strings that can be taken back in favour' discussion.

Average of ratings: -
In reply to Bente Olsen

Re: Ang: Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Gordon Bateson -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers

Hi Bente,
the 'clues' string is used by the hotpot/attempt/review.php script, to report how many clues were requested by the student when they attempted the HP exercise.

The exact line is in "mod/hotpot/attempt/review.php", around line 388:

  • $cell = new html_table_cell(get_string($field, 'hotpot'), array('class'=>'responsefield'));

The 'score', 'weighting', 'hints', 'clues', 'checks' strings are all used by this line of PHP.

cheers
Gordon

Average of ratings: -
In reply to Gordon Bateson

Ang: Re: Ang: Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Bente Olsen -

Hi Gordon

I will add 'clues' to the list of strings that should be unmarked as greylisted & perhaps I now understad a little bit of what it means that a string it not found in the code 'as a pattern' big grin

And I have added AMOS to the Glossary of common terms ;), but it is hidden - I do not know if it has to be approved by someone.

cheers
Bente

Average of ratings: -
In reply to Bente Olsen

Re: Ang: Re: Ang: Re: Greylisted string from mod_quiz in the new HotPot module @Gordon

by Gordon Bateson -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers

Dear Bente,
thanks for your help in translating the HotPot strings for Moodle2.x and for making sure that none of the HotPot strings are greylisted.

I'm afraid I do not know about getting terms in the glossary approved either sad

kind regards
Gordon

Average of ratings: -