Posts made by Visvanath Ratnaweera

Picture of Particularly helpful Moodlers Picture of Translators

Thanks for coming back. No, I'm not sure what is causing the problem. I've missed the screenshot in my first post. I attach to to this post.

Otherwise everything I said in that post applies.

So far I've found that all "Interactive content" are defective. There are many other H5P content which are OK. Yes, I disabled the “Download available H5P content types from h5p.org” scheduled task - but only on the 17th inst.

Yes both H5P plugins are active.

Attachment Screenshot_2024-10-19_21-27-38.png
Picture of Particularly helpful Moodlers Picture of Translators

Hi

In my 4.1.14 I there is a ./h5p/h5plib/v124 directory with a version.php:

$plugin->version   = 2022112800;
$plugin->requires  = 2022111800;
$plugin->component = 'h5plib_v124';

As confirmed by the Plugins overview:

There is no v125 or 126 or 127. And Check for updates shows nothing.

The mod_hvp shows 1.27.0 though:

I updated Moodle to 4.1.14 on 10 October with Git. No errors reported.

I'm lost!

Picture of Particularly helpful Moodlers Picture of Translators
My subject title was not good. "Moodle 4.5 LTS breaking.." suggests that one has upgraded to 4.5 LTS - which is not the case. The release of 4.5 LTS breaks some earlier versions of Moodle, notably 4.1 LTS, because the plug-in developers march their plug-ins forward without looking back at 4.1. This ticket explains it well: https://github.com/h5p/h5p-php-library/pull/193.

I don't think plug-ins trying to say current with having different code sections for different Moodle versions is a good idea. They should provide different plug-in versions for different Moodle versions. "Sensitive" plug-ins do that already. See the example of Stream:

 
The "universal" (4.1-4.5) versions have this danger,. Example Questionnaire, when it wants to extend to 4.5:
 
 
Picture of Particularly helpful Moodlers Picture of Translators

you can't *assume* that a plugin will continue to work from one version to a next.

"plugin developers - please, urgently, test your plugins with 4.5"

That wasn't the problem this time. It is not those who upgraded to 4.5 found certain plug-ins not working, rather something unexpected.

The plug-in developers, at least in the two examples above, made their plug-ins 4.5-compatible. The problem was, that broke the 4.1-compatibility, taking the PHP range it'll run, beginning 7.4, in to account. So people who didn't do anything other than updating Moodle from say 4.1.12 to 4.1.14 or upgraded a plug-in that started nagging, found them breaking the activity or breaking the whole site. You need to read the two threads carefully. I know, long and winding.

What I see from a distance is that at the rate HQ is making changes to the core and API, plug-in developers will be forced to maintain more than one version (to support all the supported versions).

The idea behind the new numbering scheme (from memory) was that Moodle core will have "generations" or "series" or whatever, say x.0, x.1, x.2 and x.3, ending in a LTS. Adventurous changes are to be postponed to the next generation. In the case of the filters https://moodledev.io/docs/4.5/devupdate#filter-plugins broke that. It was introduced an interface change in Moodle 4.5, the LTS, which made the new version of the language filter incompatible with the previous and the still supported LTS, the 4.1.

The case of hvp was similar, the difference was that hvp is a core plug-in. So all those who upgraded to 4.1.14, that came together with 4.5 LTS, hvp broke! 

The language filter got a patch. The latest version now runs with 4.1 and 4.5. The hvp needs a "patch", a single liner, to the code, for it to run in 4.1.14. (Haven't tested yet, too hectic.)

Picture of Particularly helpful Moodlers Picture of Translators

The new 4.5 LTS can break older versions of Moodle!

The logic is that certain changes to 4.5 LTS core requires changes to contributed plug-ins. Since many plug-ins make one version for all Moodle stable versions, the changes in certain plug-ins make them incompatible to the older Moodle versions. Here are two examples:

So, test before you upgrade contributed plug-ins even in 4.1 LTS - 4.4.

Average of ratings: Useful (2)