This sounds like a Clean theme bug, but I thought it was fixed.
The problem is Bootstrap has a .label class, and so has Moodle, actually Moodle has several .label classes for different purposes. A bug to fix the core issue is here: MDL-38086.
Is it only happening on the front page? Perhaps the fix was too specific and only applies to labels within courses?
David Scotson
Posts made by David Scotson
As Mary says, it's a CSS hack to target old IE versions.
It appears to be a topic of debate whether we "support" IE7 or even IE8 in 2.6 (depends on what you mean by "support") but in my opinion we shouldn't and it would have made a lot of sense to upgrade to Bootstrap 3 which is quite a bit lighter in CSS precisely because it ditches support for IE7.
It appears to be a topic of debate whether we "support" IE7 or even IE8 in 2.6 (depends on what you mean by "support") but in my opinion we shouldn't and it would have made a lot of sense to upgrade to Bootstrap 3 which is quite a bit lighter in CSS precisely because it ditches support for IE7.
It should already work in basically any Bootstrap derived theme, just by dropping in the renderer (and any code it calls) but the feedback I got a year ago was that no-one wanted to wander too far from core Moodle when using renderers, so I assumed it would be easier to get acceptance to core and then people could adopt it as "the future" in Themes targetting earlier versions of Moodle with some confidence.
Developing it for core and for themes is basically the same thing at the level of code though, it's just a question of who you need to convince to use it. And of course both can be pursued at the same time. So you could work on it in your shoelace or mutant banjo theme's github. As you rewrite it to use html_writer it'll become more self-contained and easier for other themers to grab the code.
Developing it for core and for themes is basically the same thing at the level of code though, it's just a question of who you need to convince to use it. And of course both can be pursued at the same time. So you could work on it in your shoelace or mutant banjo theme's github. As you rewrite it to use html_writer it'll become more self-contained and easier for other themers to grab the code.
It was developed entirely outside of Moodle core, when Bootstrap was just a theme, which meant I could just code whatever I wanted since I considered it more a proof of concept. So all the code basically needs rewritten to be Moodle-compatible anyway. So, as I say in the bug, the existing code and tests is more like a very detailed bug report, rather than code that's ready to be pulled.
There's a couple of tricky parts, but it's not a big job. There was a similar rewriting process for getting a Bootstrap tab renderer into core in MDL-39388.
And there's no big rush on the timing, if it gets merged into 2.7 then people will probably feel okay about using the renderer in their 2.5 or 2.6 themes.
Also, I got a page added to the Totara element library for testing this part of Moodle too, which helps massively:
https://github.com/totara/moodle/pull/1
edit: also a good guide to progress would be to try to work on output renderers that work for Bootstrap 2, Bootstrap 3 and Danny's Yui Pure theme, as you go to help avoid hardcoding any assumptions.
Also, I'm happy to help in any way to move this forward. Mostly just struggling with motivation since the interesting parts (for me anyway) were done a year ago, so thought a fresh pair of legs might help to carry it over the line.
There's a couple of tricky parts, but it's not a big job. There was a similar rewriting process for getting a Bootstrap tab renderer into core in MDL-39388.
And there's no big rush on the timing, if it gets merged into 2.7 then people will probably feel okay about using the renderer in their 2.5 or 2.6 themes.
Also, I got a page added to the Totara element library for testing this part of Moodle too, which helps massively:
https://github.com/totara/moodle/pull/1
edit: also a good guide to progress would be to try to work on output renderers that work for Bootstrap 2, Bootstrap 3 and Danny's Yui Pure theme, as you go to help avoid hardcoding any assumptions.
Also, I'm happy to help in any way to move this forward. Mostly just struggling with motivation since the interesting parts (for me anyway) were done a year ago, so thought a fresh pair of legs might help to carry it over the line.
Inspired by the recent discussion of the magic of renderers in this forum (https://moodle.org/mod/forum/discuss.php?d=238097) I was wondering if someone wanted to adopt the render_paging_bar renderer and fix it to use Bootstrap conventions and (in the default renderer) compatible HTML.
This was one of the first renderers I wrote for Moodle Bootstrap and I think it really makes a difference to usability, accessibility, code quality and simply looks much nicer but the bug to move it into core has somewhat languished.
https://tracker.moodle.org/browse/MDL-38260
The next steps are to convince core that it's better than what's there and rewrite the code to follow Moodle conventions (mostly the use of html_writer).
I believe that some of the bugs that this code fixes may have been independently fixed as there was some activity around this, so you may have to merge the two sets of changes.
Any takers?
This was one of the first renderers I wrote for Moodle Bootstrap and I think it really makes a difference to usability, accessibility, code quality and simply looks much nicer but the bug to move it into core has somewhat languished.
https://tracker.moodle.org/browse/MDL-38260
The next steps are to convince core that it's better than what's there and rewrite the code to follow Moodle conventions (mostly the use of html_writer).
I believe that some of the bugs that this code fixes may have been independently fixed as there was some activity around this, so you may have to merge the two sets of changes.
Any takers?