David Scotson

One error that I see at roughly the same time is regarding Cross-Origin Policy blocking the download of the user image. Is that expected? I see the warning but it doesn't seem to actually block the download. Would that be enough for the downloads of remote addons to be aborted at the same time?

11/7/2016 5:47:55 PM $mmWS: WS: Data received from WS objectionic.bundle.js:26771:18

"11/7/2016 5:47:55 PM mmExternalContent: Using URL http://joule2.dev/webservice/pluginfile.php/24/user/icon/clean/f1?rev=1&token=ec17d395257607d3bd0fb583b24dc4ad for http://joule2.dev/pluginfile.php/24/user/icon/clean/f1?rev=1"ionic.bundle.js:26771:18

11/7/2016 5:47:55 PM $mmFilepool: Set status 'notdownloaded' for package mmAddonManager mod_certificate_mod_certificateionic.bundle.js:26771:18

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://joule2.dev/webservice/pluginfile.php/24/user/icon/clean/f1?rev=1&token=ec17d395257607d3bd0fb583b24dc4ad. (Reason: CORS header 'Access-Control-Allow-Origin' missing).(unknown)

11/7/2016 5:47:56 PM $mmEvents: Event filepool_package_status_changed triggered.ionic.bundle.js:26771:18

11/7/2016 5:47:56 PM $mmEvents: Event section_status_changed triggered.ionic.bundle.js:26771:18

11/7/2016 5:47:56 PM $mmFilepool: Set status 'notdownloaded' for package mmAddonManager mod_certificate_mod_certificate

Hi all, I'm trying to develop of a remote addon using the new functionality in 3.1.

I've found one existing plugin that supports this, mod_certificate, though both it and my plugin seem to be hitting a similar issue, where the app downloads the addon (I can see a GET request for /mod/certificate/mobile/mod_certificate.zip) but nothing seems different in the app, and it still requires me to visit the website for certificates. I tried with both Android and iOS.

Could someone explain how you would debug this? Is there somewhere I can look within the app to see what errors may have been produced when it installed the addon etc.

The last time I tried to get CSS linting happening in core, I was told that Moodle does not have any CSS coding guidelines.

The ones you might find on the wiki are apparently just somebodies suggestions, and the Moodle core dev team have never committed to following them.

This seems inconsistent to me, since they have solid guidelines for PHP (that even go so far as to complain about the punctuation in PHP comments!) and they've just adopted a very in-depth JS linting strategy, with plans to expand it further.

Meanwhile on the CSS side the automation stops at running csslint with this very minimal config:

--errors=errors,duplicate-properties

--warnings=known-properties,display-property-grouping,empty-rules,important

csslint itself is a bit old and outdated, and there's more modern options, I like:

https://github.com/stylelint/stylelint

Could you be more specific about the issues you found? There are multiple uses of aria in the Bootstrap docs, they even have a bug open about removing some of their uses of aria because real world screen-reader users find them sub-optimal:

https://github.com/twbs/bootstrap/issues/19738

So, if they're using aria, and following the topic enough to be aware of  problems with the aria spec, and have a Senior Accessibility Engineer from the famous Paciello Group on board (presumably because many of their clients want to use Bootstrap and need it to be accessible), then I'd say that's not a bad start. I'd expect a more in-depth critique than writing off a public alpha with a single sentence. Things like, do they already have an open bug about the issue? If so, how are they (planning on) dealing with it? And so on.

The README on the github gives multiple examples of how to encode exceptions like this in the Supported Directives section:

https://github.com/MohammadYounes/rtlcss#supported-directives

This allows those with RTL language skills to maximise the impact of their contributions, as the boring donkey work has already been done by the computer, they just have to spot and fix the exceptions.

Also, I forgot to include the link to the other tool I mentioned (which spits out a single combined file rather than the ideal two separate files):

https://github.com/rtsao/postcss-rtlcss-combined