Hello Themers,
I've just updated my M3.1 and noticed that MDL-54559 changes a margin in the modules.less file to '0px'. I thought (with Codechecker etc.) that it was now good practice to have just '0'. I realise that past code should not be changed, but when changes are made now then that should be the best practice.
Thoughts please before I raise a policy tracker issue.
Cheers,
Gareth
In CSS a zero value is 0, not 0px or 0% or 0em.
So looks an error.
IT just goes to show what mistakes are added to Moodle by thoses who. We think to be more knowledgable than ourselves.
I saw that and thought to open a new tracker issue, but then realised that there are others in both Bootstrap and other parts of Bootstrapbase code itself.
Technically though 0px is wrong so tracker issue sounds like a good idea.
Cheers
Mary
Thanks Gareth, Fernando and Mary - Voted
Just a silly question. Why should we vote to fix an issue that is obvious?
It is not an improvement. It is a wrong coding. If codechecker verify even indentation then 0px is also an error.
Ok, it is not serious. Could we live 10 years (like many other issues) with it but why to vote if it something obvious?
Just run CSSlint
We have to vote because that is the policy. It is not a bug as it does not breal anything so it is an Improvement.
Improvements need Votes
If you really want to get something fixed, then you can add a patch to the tracker issue (if you know now), instead of adding a vote. Much more effective!
True, some issues are messy, with no single clear solution. Then fixing it involves choosing which compromise is least bad and that can take a lot of discussion first.
However, such issues are rare. Many issues have a clear-cut fix or improvement. Getting those integrated is quite easy once the patch is created. (In my experience.)
Hi Tim,
Thank you for your reply.
Perhaps what I don't understand is that they are both easy decisions to make policy wise. Very clear cut:
I'm not sure really what is unclear about that. The first is easy as its implementing best practice. The second is a decision to take the rubbish out.
Cheers,
Gareth
True Tim, but... removing rubbish helps to reduce the amount of things that could go wrong. I'm not saying that what is there for older browsers is wrong, just that the more that is redundant the more there is to cause unexpected grief.
--errors=errors,duplicate-properties
--warnings=known-properties,display-property-grouping,empty-rules,important