Looks beautiful!
Are you planning to keep up to date with Bas's improvements? I'd like to make use of both his Bootstrap 3 stuff and your customisation options, so it would be easier for me if I could just direct the changes to the relevant place rather than duplicate them.
Talking of which, do you have a preferred venue for bug reports? You've got a github but I think you had a place in Jira for Essential?
Here's one while I'm here, the front page appears to be missing a .row to contain the two grid columns. But it's present elsewhere, e.g. inside a course. I thought this was the cause of some oddness when the responsiveness kicks in but I think it's actually more to do with the white background colour being attached to the grid column rather than a div within it. This means the left and right padding are different between the div#main-region and the aside#block-region-side-post, the latter applies the background color to the div.blocks within the grid column so you still get the padding either side on phones.
In the same area on the front page you have two div#page-contents as well.
David Scotson
Posts made by David Scotson
> How can i make it so the page shows the normal navbar under the logo and social links, then once you have scrolled passed it the navbar becomes fixed to the top?
Generally this is done with the Bootstrap Affix plugin:
http://getbootstrap.com/2.3.2/javascript.html#affix
Note that it requires JQuery.
You can see a live demo here:
http://www.bootply.com/77602
As Gareth says, there's a whole massive ecosystem of Bootstrap stuff out there, we've barely scratched the surface in Moodle Themes.
Generally this is done with the Bootstrap Affix plugin:
http://getbootstrap.com/2.3.2/javascript.html#affix
Note that it requires JQuery.
You can see a live demo here:
http://www.bootply.com/77602
As Gareth says, there's a whole massive ecosystem of Bootstrap stuff out there, we've barely scratched the surface in Moodle Themes.
Hi Gareth,
a random Github tip: if you shift-click on a second line you can highlight a section of code (or edit the url by hand):
https://github.com/moodleman/moodle-theme_essential/blob/ESSENTIAL_27/layout/frontpage.php#L55-L57
regards,
dave
a random Github tip: if you shift-click on a second line you can highlight a section of code (or edit the url by hand):
https://github.com/moodleman/moodle-theme_essential/blob/ESSENTIAL_27/layout/frontpage.php#L55-L57
regards,
dave
Looks like a rogue CSS rule that's overwritten (twice!) in Base/Standard/Canvas etc themes, but not in Bootstrapbase/Clean, and so can be deleted from both.
One less line of strange CSS to worry about.
It's this line:
https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/filemanager.less#L1055
and the same rule is part of this nicely readable line too:
https://github.com/moodle/moodle/blob/master/theme/base/style/filemanager.css#L353
One less line of strange CSS to worry about.
It's this line:
https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/filemanager.less#L1055
and the same rule is part of this nicely readable line too:
https://github.com/moodle/moodle/blob/master/theme/base/style/filemanager.css#L353