Các bài đăng được tạo bởi Urs Hunkler

Hình của Core developers

Sakshi, I checked the behavior you described in 

"2. When i singled click on the image the insert / edit image icon in editor backdground changes with grey. Tested with clean theme."

and can't confirm this behavior. When I single click on an image the image button does not change and does not get the focus. 

I checked with Moodle 2.7.1 and the "clean" theme.

Am I the only one who thinks the functionality to activate the image button with a single click on the image is known from other editors and it would be very convenient if those expectations would be met in Atto too?

Hình của Core developers

Joseph, thank you very much for your answer. I am working on a course format for a site with a custom theme and other add-ons, so it would be too complex to discuss the details here.

Your feedback that you also think that the second call to require_login might be not correct is very helpful. 

Do you know who maintains the glossary module that I can assign the right person to the tracker issue?

Hình của Core developers

I work on a course format for Moodle 2.7 which adds a fake block. All modules work quite well except glossaries.

The error message without the stack trace is:

"Coding error detected, it must be fixed by a programmer: The theme has already been set up for this page ready for output. Therefore, you can no longer change the theme, or anything that might affect what the current theme is, for example, the course."

I discovered that in glossary/view.php require login is called twice:

line 50: require_course_login($course->id, true, $cm);
line 120 ff: 
if ($course->id != SITEID) {
    require_login($course);
}

When I remove the second call the error is gone.

Is my guess correct that the second require_login may be a relict from earlier Moodle versions and that it is not needed? If so I would call it a bug and create a tracker issue.

Any feedback and a proposal how to solve the issue are very welcome.

Trung bình điểm đánh giá: -