This is an annoying bug fix that is out :
The scheduler did not properly remove calendar events when a student was changing its appointment. It's OK now.
Scheduler was experimented with success on a 180 appointement set over 3 weeks : less than 15 minutes overcrowd and no unexpected annulation on passed 110 meetings !!
Hi Sven, first of all do you have the last edited version of the scheduler ? If not get it here.
You should have version 2008021600 which is the last fixed version.
Other thing you could check out : you should have three scheduler tables : mdl_scheduler, mdl_scheduler_slots and mdl_scheduler_appointment, if not, you may run a new code over an old tableset, as we had some difficulties to have the upgrade running Ok for a while.
If the table model seems to be old, just uninstall and reinstall the scheduler module (uninstall, keep the files where they are and browse once again to admin->notifications).
Once you checked this, it should run nicely.
Cheers.
Well, let's check some technical things :
SELECT *
FROM mdl_capabilities
WHERE name LIKE 'mod/scheduler%'
in your PhpMyAdmin should have following results
224 mod/scheduler:appoint write 70 mod/scheduler 0
229 mod/scheduler:attend read 70 mod/scheduler 0
193 mod/scheduler:canscheduletootherteachers read 70 mod/scheduler 0
226 mod/scheduler:disengage write 70 mod/scheduler 0
225 mod/scheduler:manage write 70 mod/scheduler 0
192 mod/scheduler:manageallappointments read 70 mod/scheduler 0
227 mod/scheduler:seeotherstudentsbooking read 70 mod/scheduler 0
228 mod/scheduler:seeotherstudentsresults read 70 mod/scheduler
(except for id numbers which will be yours and not mine --- We check existence of capabilities ).
SELECT *
FROM `mdl_role_capabilities`
WHERE capability LIKE 'mod/scheduler%'
AND contextid =1
should show 39 lines of answer, which are the capabilities of the CONTEXT_SITE level (capabilities that will apply as default).
Setting debug level to "All errors" might show us an hidden php error message that could have raised locally on your implementation. Try setting for a moment such debug level and try back showing slots.
When adding slots, check dates are in allowed days. I made that mismatch once and was stonished with the result.
We'll keep on trying to see what's wrong there...
Of course it helps...
It seems that Postgress do not implement the LIMIT,OFFSET statement that allows result pagination when querying a heavy loaded table. I don't know how to bypass that problem right now, and I suspect many other module do use such limitation syntax in their queries.
I will ask Tim Hunt about that issue to check he has a portable method for that page limiting feature. I guess it would not really work on Oracle either.
As we would really like Moodle being dataase independant, I will check that particular point and review the Scheduler code if a solution can be found to that.
Obviously, this error is the master cause why you get no slots !! Slots cannot be fetched at all !!
Cheers.
LIMIT/OFFSET
The best way is to use the extended parameter list of the get_record_... functions :
$slots = get_records_sql($sql, $offset * 25, 25);
getting rid of proprietary SQL markup.
IF
I think the best way is to split the query in more simple parts. So the syntax could be pulled back to more compatible writings, despite of the performance (but here this should not have seemfull influence I guess).
I'll tell you about how to rewrite this ASAP.
Hi Sven,
I'm terribly upset by this. You're right, the release 7 do not solve this compatibility issue.
I worked a bit on the problem. There are some heavy duty queries that make multiple count compilation like this :
SELECT
s.*,
MAX(a.studentid = {$studentid}) as appointedbyme,
MAX(a.studentid) as appointed,
COUNT(IF(a.attended IS NULL OR a.attended = 0, NULL, 1)) as attended,
COUNT(IF(a.studentid IS NULL, NULL, 1)) as population
FROM
{$CFG->prefix}scheduler_slots AS s
LEFT JOIN
{$CFG->prefix}scheduler_appointment AS a
ON
a.slotid = s.id
WHERE
s.schedulerid = {$schedulerid}
GROUP BY
s.id
HAVING
((s.exclusivity > 0 AND population < s.exclusivity) OR
s.exclusivity = 0) OR appointedbyme
ORDER BY
s.starttime ASC
There are two or three queries like this that allows counting several conditional situations over one unique table product scan.
these are mainly in locallib.php, at §213 in
function scheduler_get_available_slots($studentid, $schedulerid, $studentside=false){
...
}
The other one resides in teacherview.php §523
SELECT
s.*,
COUNT(IF(a.studentid IS NOT NULL, 1, NULL)) as isappointed,
COUNT(IF(a.attended IS NOT NULL AND a.attended > 0, 1, NULL)) as isattended
FROM
{$CFG->prefix}scheduler_slots AS s
LEFT JOIN
{$CFG->prefix}scheduler_appointment AS a
ON
s.id = a.slotid
WHERE
{$select}
GROUP BY
s.id
ORDER BY
starttime ASC
These are obviously the two key points. Maybe you would like to change these to simpler queries, splitting them for getting the actual result. I think teacherview.php's one is easy, because counts are not involved in SELECT clauses. Might be harder for the former. I still didn't have time for this by now as we are in a heavy range with end of semester overbooking.
If you don't know how to find a way, I should spend a bit time on them before end of March...
Hi Sven,
here come two VERY IMPORTANT patches for you. I would very like you try them to check if compatibility is restored for PostgressSQL :
Both patches get rid of the IF() function in the SQL :
teacherview.php §523 : here is the rewriting for that complex query :
Then comes the patch for the other ocurence of IF() functions :
locallib.php §217 :
function scheduler_get_available_slots($studentid, $schedulerid, $studentside=false){
global $CFG;}
We should start have real results I hope on your instance of Moodle.
The patch applies on a Release 9, and should be propagated to next releases if you tell me it works fine on yours.
Cheers.
Sure it does !!
$slots = get_records_select('scheduler_slots', $select, 'starttime', '*', $offset * 25, 25);
if ($slots){
foreach(array_keys($slots) as $slotid){
$slots[$slotid]->isappointed = count_records('scheduler_appointment', 'slotid', $slotid);
$slots[$slotid]->isattended = record_exists('scheduler_appointment', 'slotid', $slotid, 'attended', 1);
}
}
is a much cleaner code. Fixed in development version.
If i click on the tab "overview" i get another error.
FEHLER: Spalte »s.starttime« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendent werden
SELECT COUNT(*) FROM mdl_course as c, mdl_scheduler as sc, mdl_scheduler_appointment a, mdl_scheduler_slots s, mdl_user u1, mdl_user u2 WHERE c.id = sc.course AND sc.id = s.schedulerid AND a.slotid = s.id AND u1.id = a.studentid AND u2.id = s.teacherid AND u2.id = '3' ORDER BY s.starttime
The ORDER BY clause is completely idiot for this count query !! 
delete ORDER BY s.starttime !!
MySQL is not strict enough to check that SQL inconsistency. Obviously Postgress is !!
On that last query §213 of viewstatistics.php
just
SELECT
s.starttime,
COUNT(*) as groupsize,
FROM
Should resolve the problem, as duration has the same value for all appointements at the same starttime in this scheduler. This form is once more stricter, and will also cope with strictness of Oracle aggregation rules.
I made all changes at home, and will check for correct behaviour of the module.
This might be a chance for scheduler's future that you were working on a stricter environment.
I'll check two problematic group API calls for 1.9compatibility JErome Demiaux told me before validating release 10.
no.gif : I found it in the pix/s folder, but maybe it is not a standard icon, and it was added by a plugin. I will take it back within the scheduler to avoid that miss.
For events, actually the code do (or tries) to delete all events when deleting a slot from the list (using "delete selection" link above the slot list, or clicking on the delete cross icon). At least should it...
Would you mind tell me exactly the process you used as you noticed events were till there ?
Thanks.
No, sorry but you are actually mistaken.
This options only allows that appointment become available again when the "seen" mark is enabled on the appointment.
This option was made for long run projects meetings, so that students MUST have concluded the next dated meeting to be allowed to reengage a new date. This allows multiple appointements to be kept in the same scheduler, and compile a single grade for them, either max or mean of all passed appointments.
When choosing the other value, students that have appointed and concluded meeting WOULD NEVER be allowed to appoint again. Scheduling is over for them.
Valery.
I recently got updated files from Ralf Hilgenstock,
maybe getting these new files could be of some help, Ralf added helpers in German. We just miss the mail templates now. They are available from CVS.
Regards.
Hi Sven, the exact meaning of the button should be told there :
http://docs.moodle.org/en/Scheduler:_My_Appointments
There was a confusing label in the last release.
Basically the four use cases are :
I should have updated labels in the lang files... I hope.
Deleting unused slots SHOULD NOT let events in the calendar, as there SHOULD not exist any events for that slots. If it does, it is a bug. If you delete all your personal slots, events for appointed but not met students should disappear, once again, if they do not, its also a trailing bug. Events for other teacher meetings will not be removed.
Collisions : the proper of a good information system is getting your information consistent from your point of view. This was essential that you could not make slots in a course when you be already engaged elsewhere.
Shared schedulers : working with Michael Schwab (Germany) were some enhancements in the direction : the summary screen summaries all appointments of all your schedulers. The page style is a bit rough and might be reviewed (css related).
Future of scheduler : except for light enhancements and trailing bug fixes, Scheduler should not change a lot from now. I'm now engaged in other developements such as the CodeTrainer module for teaching programming skills online, and have to finish a more general project with Task, TimeTrack and Techproject for student project control.
Regards.
I fear you are not completely up to date. §365 in locallib has no code in dev/last uploadable version. Current is 2008040900.
Last link at ethnoinformatique.fr on scheduler now points on the night build of contrib records from the CVS. Probably the most "up to date" code we could have, pursuant I have time to make commits !!
selective deletions work nice on dev implementation...
Cheers.
Sven, what could be checked is : when you select slots using checkboxes, do you see slot id list changing in status bar ? If not, this may be a Javascript related issue. I use Javascript to add or remove checked items from an id list. this is done by the /scripts/listlib.js file in the scheduler distribution. Tell me what is your client side configuration please, so we could attempt finding the cause.
Sven, try this :
on teacherview.php §599
replace :
$selectcheck = "<input type=\"checkbox\" name=\"sel_{$slot->id}\" name=\"sel_{$slot->id}\" onclick=\"document.forms['deleteslotsform'].items.value = toggleListState(document.forms['deleteslotsform'].items.value, 'sel_{$slot->id}', '{$slot->id}');\" />";
with
$selectcheck = "<input type=\"checkbox\" id=\"sel_{$slot->id}\" name=\"sel_{$slot->id}\" onclick=\"document.forms['deleteslotsform'].items.value = toggleListState(document.forms['deleteslotsform'].items.value, 'sel_{$slot->id}', '{$slot->id}');\" />";
This was a cut/copy error of mine.
Windows based IE merges id and name in one variable so getElementById find element on names and not Safari (more W3C compliant).
Maybe will we still have an error as name and id have same value, and Safari might not like it...
Cheers.
I've been a very naughty boy : I didn't test by myself the patch I submitted to you . Overconfidence is not a good behaviour when coding.
I'll check that straighter. I fear id<->name collision may be harmfull in some cases.