error in resuming saved questionnaires?

error in resuming saved questionnaires?

由Daniele Cordella發表於
Number of replies: 23
Core developers的相片 Plugin developers的相片
Moodle 1.9
Questionnaire for m1.9 downloaded this morning from
http://moodle.org/mod/data/view.php?d=13&rid=84.

I imported a questionnaire I made last month in Moodle 1.8.
Then I filled it and, before submitting it I saved it.
I closed and left.

Then I returned to my questionnaire.
I found my previous saved questionnaire form already filled BUT with all the radio button option questions without selections, still blank.

sorpreso

Is this a bug? Can someone help me, please?
Thank you in advance.
評比平均分數： -
In reply to Daniele Cordella

Re: error in resuming saved questionnaires?

由Joseph Rézeau發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片 Testers的相片 Translators的相片
Hi Daniele,
>I imported a questionnaire I made last month in Moodle 1.8.
Which method did you use to "import" your questionnaire from 1.8 into 1.9?
Joseph
評比平均分數： -
In reply to Joseph Rézeau

Re: error in resuming saved questionnaires?

由Daniele Cordella發表於
Core developers的相片 Plugin developers的相片
I made a backup of the course with the questionnaire inside in M18 and I restored the course to M19.

(thank you again for all your work)
評比平均分數： -
In reply to Daniele Cordella

Re: error in resuming saved questionnaires?

由Joseph Rézeau發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片 Testers的相片 Translators的相片
I imported a questionnaire I made last month in Moodle 1.8.

Did you import that questionnaire with or without user data?

What are the settings on that questionnaire: respond once/many, etc.

What type of questions: radio buttons, short text, etc.

Are all of some of the questions REQUIRED?

Then I filled it and, before submitting it I saved it.

When you saved the responses, what did you see on screen: were radio buttons still checked?

I closed and left.
Then I returned to my questionnaire.
I found my previous saved questionnaire form already filled BUT with all the radio button option questions without selections, still blank.

When you say "already filled" I suppose you mean the questions other than radio button ones where filled, and only the radio buttons questions had lost their selection?

Did you try to create a similar questionnaire in 1.9 and did you have the same problem?

Can you send me (privately) that questionnaire you imported from 1.8 to 1.9 so I can check?

Joseph

PS.- Today I shall be committing all the recent changes I made, especially the XHTML validation to moodle 1.8 and 1.9 and 2.0.

EDIT.- Just done exactly those manipulations on my moodle 1.8 and 1.9 local installations without encountering your problem.

評比平均分數： -
In reply to Joseph Rézeau

Re: error in resuming saved questionnaires?

由Daniele Cordella發表於
Core developers的相片 Plugin developers的相片
> Did you import that questionnaire with or without user data?
without

> What are the settings on that questionnaire: respond once/many, etc.
-> Type = respond many
-> Respondent Type = fullname
-> Respondent Eligibility = all
-> View responses = Teachers only
-> Questionnaire Type = Private
-> Save/Resume answers = Yes

> What type of questions: radio buttons, short text, etc.
each kind of question. It is the questionnaire you saw last month

> Are all of some of the questions REQUIRED?
all the missing answers were belonging to mandatory questions
Not all the questions of the questionnaire were mandatory

> When you saved the responses, what did you see on screen: were radio buttons still checked?
Yes, and to be sure I also printed it

> When you saved the responses, what did you see on screen: were radio buttons still checked?
Yes, it is

> Did you try to create a similar questionnaire in 1.9 and did you have the same problem?
No, I didn't

> Can you send me (privately) that questionnaire you imported from 1.8 to 1.9 so I can check?
I can do more.
My site is online. Go to check your private email.

> Today I shall be committing all the recent changes I made, especially the XHTML validation to moodle 1.8 and 1.9 and 2.0.
I made a lot of changes more to improeve the questionnaire as you can see from the copy I sent you last month. For instance, the visual aspect with the <div class="bla bla bla "> and the management of the question through the drop down menu. Do I have to post them in the tracker as feature request or you already know what I added more?
評比平均分數： -
In reply to Daniele Cordella

Re: error in resuming saved questionnaires?

由Joseph Rézeau發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片 Testers的相片 Translators的相片
There is definitely a bug in current Questionnaire version for Moodle 1.9. I am in contact with Mike Churchward about it. Be patient.
Joseph
評比平均分數： -
In reply to Daniele Cordella

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
I have just committed some changes to the 1.9 and 2.0 versions that fix problems with responses with choices. Please get the latest version from CVS or wait for the zip file and let me know if this fixes your issues.

mike
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Daniele Cordella發表於
Core developers的相片 Plugin developers的相片
Can you list, please, the names of the files you changed since I am not able to find them in
http://moodle.cvs.sourceforge.net/moodle/contrib/plugins/mod/questionnaire/?sortby=date#dirlist

Thank you in advance
評比平均分數： -
In reply to Daniele Cordella

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
MOODLE_19_STABLE: Commit in contrib/plugins/mod/questionnaire
crosstab.inc +3 -3 1.9.2.2 -> 1.9.2.3
locallib.php +13 -11 1.49.2.10 -> 1.49.2.11
order.inc +3 -3 1.11.2.1 -> 1.11.2.2
questions.inc +2 -2 1.16.2.4 -> 1.16.2.5

+21 -19
4 modified files
CONTRIB-252: Fixed missed table name changes and lowercase enums.
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Ryan Smith發表於
I downloaded the latest version from the Questionnaire page for my Moodle 1.9 test install and I get a slew of errors when it tries to update the tables.

I've attached a txt file of the errors.

Using MySQL 5.0.45.
評比平均分數： -
In reply to Ryan Smith

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
Hi Ryan -

I've just re-tested upgrading a questionnaire from 1.8 to 1.9, and I don't have any problems...

The errors in the text file look like something in your database library code is working differently than expected.

What do the structures of your 'questionnaire_' tables look like now?

mike
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Ryan Smith發表於
I've attached a sql dump of my questionnaire table structure.
評比平均分數： -
In reply to Ryan Smith

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
I don't know why that's happening...

Its not executing the Moodle call 'table_column' correctly. It's using the 'RENAME COLUMN' operation, which it should not be doing if you are running MySQL. Are you sure you are using MySQL, and that your config file says that you are using MySQL?

mike
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Ryan Smith發表於
Heh, yes I'm sure its MySQL. Version is 5.0.45.

My config has:

$CFG->dbtype = 'mysqli';
評比平均分數： -
In reply to Ryan Smith

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
'mysqli' isn't 'mysql' (but I'm not sure what it is)...

If you are using 'MySQL', maybe you should change that setting to 'mysql'?

Edit...
MySQLi

Not sure whether this should be used then... At least in this case, it doesn't work right... I'll see if there's a way to do what 'table_column' does using the XMLDB.
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
Okay... Just committed changes that get rid of the use of 'table_column' and use only the XMLDB functions. That should work for 'mysqli' as well.

mike
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Ryan Smith發表於
Here is more info on mysqli:

http://us2.php.net/mysqli

Here is the Moodle Tracker for it, support for mysqli was added almost exactly 1 year ago:

http://tracker.moodle.org/browse/MDL-8113

Thanks for your help with this! Questionnaire is a crucial module for our Moodle server.
評比平均分數： -
In reply to Ryan Smith

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
Ryan -

Please try the latest upgrade changes committed into CVS.

Mike
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Ryan Smith發表於
Mike,

I just grabbed the latest version, no errors with the db upgrade, everything works perfectly. Thanks for fixing it so fast!

I did update my version of Questionnaire on our live Moodle 1.8 server and noticed some alignment problems with the submit questionnaire and responses buttons. I'll put a tracker bug in for it with screenshots shortly.
評比平均分數： -
In reply to Mike Churchward

Re: error in resuming saved questionnaires?

由Matthew Davidson發表於
Core developers的相片 Plugin developers的相片
According to http://tracker.moodle.org/browse/MDL-6285

table_column is deprecated.
評比平均分數： -
In reply to Matthew Davidson

Re: error in resuming saved questionnaires?

由Mike Churchward發表於
Core developers的相片 Plugin developers的相片 Testers的相片
Well, it is still located in 'ddllib.php' all the same...

I think it will be deprecated at some point.
評比平均分數： -